Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038193Retail ModulesWeb POSpublic2018-03-21 16:372018-06-19 14:29
ReporterSandrahuguet 
Assigned ToSandrahuguet 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in VersionRR18Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038193: In updateOrCreateCashupInfo is updated all paymentmethods
DescriptionIn updateOrCreateCashupInfo is updated all paymentmethodcashup and only is necessary update the paymentmethod used in the ticket
Steps To ReproduceCheck this code in UpdateCashup.updateOrCreateCashupInfo

    // Update paymentmethodcashup
    if (jsonCashup.has("cashPaymentMethodInfo")) {
      JSONArray paymentCashupInfo = jsonCashup.getJSONArray("cashPaymentMethodInfo");
      for (int i = 0; i < paymentCashupInfo.length(); ++i) {
        JSONObject payment = paymentCashupInfo.getJSONObject(i);
        // Set Amount To Keep
        if (jsonCashup.has("cashCloseInfo")) {
          // Get the paymentMethod id
          JSONArray cashCloseInfo = jsonCashup.getJSONArray("cashCloseInfo");
          for (int j = 0; j < cashCloseInfo.length(); ++j) {
            JSONObject paymentMethod = cashCloseInfo.getJSONObject(j);
            if (paymentMethod.getString("paymentTypeId").equals(
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to design defect 0040078 new Retail If a new column is added to PaymentMethodCashup the data is inconsistent on WebPOS 
causes defect 0040019 closed ranjith_qualiantech_com Counted amount is wrong in the Cashup Report 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-21 16:37SandrahuguetNew Issue
2018-03-21 16:37SandrahuguetAssigned To => Retail
2018-03-21 16:37SandrahuguetOBNetwork customer => No
2018-03-21 16:37SandrahuguetTriggers an Emergency Pack => No
2018-03-21 16:38SandrahuguetTag Attached: Performance
2018-03-27 10:54ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-03-27 10:54ranjith_qualiantech_comStatusnew => scheduled
2018-03-27 11:21SandrahuguetAssigned Toranjith_qualiantech_com => Sandrahuguet
2018-04-10 16:35SandrahuguetReview Assigned To => marvintm
2018-05-23 09:24hgbotCheckin
2018-05-23 09:24hgbotNote Added: 0104640
2018-05-23 09:24hgbotStatusscheduled => resolved
2018-05-23 09:24hgbotResolutionopen => fixed
2018-05-23 09:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0797b3798881a9b775cb323b3c79e49159eac58 [^]
2018-06-19 13:56hgbotCheckin
2018-06-19 13:56hgbotNote Added: 0105256
2018-06-19 14:29marvintmStatusresolved => closed
2018-06-19 14:29marvintmFixed in Version => RR18Q3
2019-01-30 10:49guillermogilRelationship addedcauses 0040019
2019-01-31 06:48guillermogilRelationship addedrelated to 0040078

Notes
(0104640)
hgbot   
2018-05-23 09:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d0797b3798881a9b775cb323b3c79e49159eac58
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue May 22 15:42:52 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0797b3798881a9b775cb323b3c79e49159eac58 [^]

Fixed issue 38193 only update used payment method in current transaction

only update used payment method in current ticket and cash management

---
M src/org/openbravo/retail/posterminal/ProcessCashMgmt.java
M src/org/openbravo/retail/posterminal/UpdateCashup.java
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
M web/org.openbravo.retail.posterminal/js/model/paymentmethodcashup.js
M web/org.openbravo.retail.posterminal/js/utils/cashManagementUtils.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0105256)
hgbot   
2018-06-19 13:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c635a1d6a743821f8a887c0bc59930b2ebeceb76
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jun 19 13:56:16 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c635a1d6a743821f8a887c0bc59930b2ebeceb76 [^]

Related to issue 38193. Removed unnecessary call to ob-dal

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---