0038177: JS error when trying to pay a ticket with a payment method not in that terminal

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038177

Retail Modules

Web POS

public

2018-03-20 13:06

2018-03-22 09:43

Reporter

asiermartirena

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR18Q1.1

Fixed in Version

RR18Q1.1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Coding ( Testing )

Regression date

2017-10-11

Regression introduced in release

RR18Q1

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c903c081a0a [^]

Triggers an Emergency Pack

Summary

0038177: JS error when trying to pay a ticket with a payment method not in that terminal

Description

There's a javascript error when trying to pay a ticket in a terminal that doesn't contain the payment method of the payment used to pay (partially or totally) the ticket.

In the 'checkValidOverpayment' function there's a line that takes the payment method of the payment, and tries to take that payment method from the terminal. As the payment method is not in the terminal, there's a null pointer. This is the line:

overPaymentMethod = overPaymentUsed ? OB.MobileApp.model.paymentnames[overPaymentUsed.get('kind')].paymentMethod : undefined

This only occurs in a terminal that contains at least one payment method, otherwise this function is not called.

Steps To Reproduce

Load in a terminal with the payment method 'Card'.

Create a ticket and pay partially or totally by 'Card'.

Load the Web POS in a terminal that doesn't contain the 'Card' payment method.

Load the previously created ticket.

Click on the total amount button -----> A javascript error appears

Proposed Solution

Additional Information