Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038176Retail ModulesWeb POSpublic2018-03-20 13:062018-03-22 09:43
Reporterasiermartirena 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelCoding ( Testing )
Regression date2017-10-11
Regression introduced in releaseRR18Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c903c081a0a [^]
Triggers an Emergency PackNo
Summary0038176: JS error when trying to pay a ticket with a payment method not in that terminal
DescriptionThere's a javascript error when trying to pay a ticket in a terminal that doesn't contain the payment method of the payment used to pay (partially or totally) the ticket.

In the 'checkValidOverpayment' function there's a line that takes the payment method of the payment, and tries to take that payment method from the terminal. As the payment method is not in the terminal, there's a null pointer. This is the line:

overPaymentMethod = overPaymentUsed ? OB.MobileApp.model.paymentnames[overPaymentUsed.get('kind')].paymentMethod : undefined

This only occurs in a terminal that contains at least one payment method, otherwise this function is not called.
Steps To ReproduceLoad in a terminal with the payment method 'Card'.

Create a ticket and pay partially or totally by 'Card'.

Load the Web POS in a terminal that doesn't contain the 'Card' payment method.

Load the previously created ticket.

Click on the total amount button -----> A javascript error appears
Proposed Solution
Additional Information
TagsSER-QA
Relationships
depends on backport 0038177RR18Q1.1 closed ranjith_qualiantech_com JS error when trying to pay a ticket with a payment method not in that terminal 
caused by defect 0036974 closed jorge-garcia [SERQA 3316] It is possible to bypass the overpayments with Pay Open tickets 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-20 13:06asiermartirenaNew Issue
2018-03-20 13:06asiermartirenaAssigned To => Retail
2018-03-20 13:06asiermartirenaResolution time => 1522706400
2018-03-20 13:06asiermartirenaTriggers an Emergency Pack => No
2018-03-20 13:07asiermartirenaTag Attached: SER-QA
2018-03-20 13:13asiermartirenaDescription Updatedbug_revision_view_page.php?rev_id=16886#r16886
2018-03-20 13:31asiermartirenaRegression level => Coding ( Testing )
2018-03-20 13:31asiermartirenaRegression date => 2017-10-11
2018-03-20 13:31asiermartirenaRegression introduced in release => RR18Q1
2018-03-20 13:31asiermartirenaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c903c081a0a [^]
2018-03-20 14:01marvintmStatusnew => scheduled
2018-03-21 07:26ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-03-21 18:50dmitry_mezentsevRelationship addedcaused by 0036974
2018-03-22 07:29hgbotCheckin
2018-03-22 07:29hgbotNote Added: 0103404
2018-03-22 07:29hgbotStatusscheduled => resolved
2018-03-22 07:29hgbotResolutionopen => fixed
2018-03-22 07:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7fabb7fb5ed123ed5cb6d62c2378d48e0ff69bf5 [^]
2018-03-22 09:43marvintmReview Assigned To => marvintm
2018-03-22 09:43marvintmStatusresolved => closed
2018-03-22 09:43marvintmFixed in Version => RR18Q2

Notes
(0103404)
hgbot   
2018-03-22 07:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7fabb7fb5ed123ed5cb6d62c2378d48e0ff69bf5
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 22 11:59:13 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7fabb7fb5ed123ed5cb6d62c2378d48e0ff69bf5 [^]

Fixed issue 38176 : Validate receipt payment with terminal payment

* If receipt payment is not exists in terminal payments, it should not validate overpayment

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---