Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038158Openbravo ERPZ. Otherspublic2018-03-16 11:562018-05-09 19:29
Reporterngarcia 
Assigned Tocaristu 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038158: Payment details are lost if the payment is reactivated and Transaction Type is changed: credit is generated instead
DescriptionPayment details are lost if the payment is reactivated and Transaction Type is changed: credit is generated instead
Steps To ReproduceAs group admin role:
   Create two sales orders for same business partner, set their invoice terms as Immediate and book them
   Create a sales invoice for that business partner and add previously created two orders
   Complete it
   Create a Payment In header, set that business partner
   When adding details, select Transaction Type: Invoices
   Add the pending amount amount and process it
   Go to Financial Account, reactivate and remove the associated transaction in case it was automatically created
   Reactivate the payment selecting the Reactivate option (not deleting lines)
   Add details
   Change Transaction Type to Orders and invoices
   Check the lines are shown as selected
   Process it
   Check the payment lines disappear and a line with the generated credit is shown
   Payment In header is updated with the generated credit and description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-16 11:56ngarciaNew Issue
2018-03-16 11:56ngarciaAssigned To => Triage Finance
2018-03-16 11:56ngarciaModules => Advanced Payables and Receivables Mngmt
2018-03-16 11:56ngarciaResolution time => 1522965600
2018-03-16 11:56ngarciaTriggers an Emergency Pack => No
2018-03-16 12:54aferrazAssigned ToTriage Finance => AtulOpenbravo
2018-03-16 14:46ngarciaIssue Monitored: networkb
2018-04-04 19:39AtulOpenbravoStatusnew => scheduled
2018-04-06 12:06dmiguelezAssigned ToAtulOpenbravo => caristu
2018-04-06 13:15caristuNote Added: 0103713
2018-04-06 13:15caristuAssigned Tocaristu => platform
2018-04-06 13:16caristuStatusscheduled => acknowledged
2018-04-10 19:25caristuAssigned Toplatform => caristu
2018-04-10 19:26caristuStatusacknowledged => scheduled
2018-04-11 16:12hgbotCheckin
2018-04-11 16:12hgbotNote Added: 0103821
2018-04-11 16:12hgbotStatusscheduled => resolved
2018-04-11 16:12hgbotResolutionopen => fixed
2018-04-11 16:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4ed727aa048a7b09aaa54b5a992c06b50dfff762 [^]
2018-04-11 16:15caristuReview Assigned To => alostale
2018-04-11 16:15caristuNote Edited: 0103713bug_revision_view_page.php?bugnote_id=0103713#r16971
2018-04-13 09:05alostaleNote Added: 0103867
2018-04-13 09:05alostaleStatusresolved => closed
2018-04-13 09:05alostaleFixed in Version => 3.0PR18Q3
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104372

Notes
(0103713)
caristu   
2018-04-06 13:15   
(edited on: 2018-04-11 16:15)
When clicking on "Done" first a validation is executed on the server, when returning, the standard action handler is called using the actionHandlerCall() function[1]

At this point, the selection of the grid is not retrieved properly and this is because at this point the pneSelectedRecords[2] is empty (but there are records indeed selected on the grid load).

It must be reviewed why pneSelectedRecords is empty at that point.

[1] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js#l1191 [^]
[2] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-pickeditgrid.js#l101 [^]
(0103821)
hgbot   
2018-04-11 16:12   
Repository: erp/devel/pi
Changeset: 4ed727aa048a7b09aaa54b5a992c06b50dfff762
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Apr 11 10:24:48 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4ed727aa048a7b09aaa54b5a992c06b50dfff762 [^]

fixes bug 38158: wrong selection handling on trx type change in Add Payment

  The order_invoice grid of the Add Payment process implements its own mechanism to keep the selected records when changing the transaction type. This mechanism was not keeping the pneSelectedRecords array properly updated which in this case is the source eventually used to send the selection to the backend.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0103867)
alostale   
2018-04-13 09:05   
reviewed + tested
(0104372)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test