Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038155Retail ModulesStoreServerpublic2018-03-16 09:542018-04-05 11:03
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038155: SS: transition to online, use same logic as in reload when starting SS
DescriptionWhen starting the SS the SS calls the CS to check how many batches of data are to be loaded to the SS. It then waits for these batches to arrive before continuing. If any new replication batches are created during that process these are not considered, do not block.

See the logic here [1]

Similar logic has to be used when transitioning to online as transitioning to online is very similar to reloading at startup. The logic has to be only done in the pre-transition-to-online check as there we can do waits and loops. In the pre-transition-to-online phase the user is not blocked in webpos.

The logic has to be implemented here [2]

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/tip/src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java#l175 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/SyncStatusOnlineTransitionHandler.java [^]

Steps To ReproduceSee description
Proposed SolutionSee description
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-16 09:54mtaalNew Issue
2018-03-16 09:54mtaalAssigned To => mtaal
2018-03-16 09:54mtaalTriggers an Emergency Pack => No
2018-03-17 20:13hgbotCheckin
2018-03-17 20:13hgbotNote Added: 0103334
2018-03-17 20:17mtaalReview Assigned To => AugustoMauch
2018-03-17 20:54hgbotCheckin
2018-03-17 20:54hgbotNote Added: 0103335
2018-03-17 20:54hgbotStatusnew => resolved
2018-03-17 20:54hgbotResolutionopen => fixed
2018-03-17 20:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/9bed017478f52205221ced0afc15de9d01464b7b [^]
2018-03-17 20:58hgbotCheckin
2018-03-17 20:58hgbotNote Added: 0103336
2018-03-19 09:22hgbotCheckin
2018-03-19 09:22hgbotNote Added: 0103339
2018-03-19 09:27rafademiguelIssue Monitored: rafademiguel
2018-04-05 11:03AugustoMauchNote Added: 0103687
2018-04-05 11:03AugustoMauchStatusresolved => closed

Notes
(0103334)
hgbot   
2018-03-17 20:13   
Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 7e15663dab00f0c6a06ee0db032032dab03d7e7a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Mar 17 20:12:52 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/7e15663dab00f0c6a06ee0db032032dab03d7e7a [^]

Related to issue 38155: SS: transition to online, use same logic as in reload when starting SS
Moved methods to ReplicationUtils class for re-use

---
M src/org/openbravo/replication/symmetricds/SetupSymmetricListener.java
M src/org/openbravo/replication/symmetricds/util/ReplicationUtils.java
---
(0103335)
hgbot   
2018-03-17 20:54   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 9bed017478f52205221ced0afc15de9d01464b7b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Mar 17 20:54:19 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/9bed017478f52205221ced0afc15de9d01464b7b [^]

Fixes issue 38155: SS: transition to online, use same logic as in reload when starting SS
When transitioning to online check the CS for any pending batches

- RetailSynchronizationRequestHandler: method moved to ReplicationUtils
- SyncStatusOnlineTransitionHandler: call the CS to check that latest batch has been received, use methods from ReplicationUtils
- MobileServerEventHandler: methods moved to ReplicationUtils

---
M src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java
M src/org/openbravo/retail/storeserver/synchronization/SyncStatusOnlineTransitionHandler.java
M src/org/openbravo/retail/storeserver/synchronization/eventhandler/MobileServerEventHandler.java
---
(0103336)
hgbot   
2018-03-17 20:58   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4eecb7f8a416acb8f92141ebe81572c4affe5801
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Mar 17 20:55:16 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4eecb7f8a416acb8f92141ebe81572c4affe5801 [^]

Related to issue 38155: SS: transition to online, use same logic as in reload when starting SS
Wait also 10 secs between checks as the checks phase gets to become more important

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0103339)
hgbot   
2018-03-19 09:22   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: aede646bc74040002a61590d81913de08e5dbc50
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 19 09:22:11 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/aede646bc74040002a61590d81913de08e5dbc50 [^]

Related to issue 38155: SS: transition to online, use same logic as in reload when starting SS
Solve eclipse warning

---
M src/org/openbravo/retail/storeserver/synchronization/eventhandler/MobileServerEventHandler.java
---
(0103687)
AugustoMauch   
2018-04-05 11:03   
Code reviewed and verified