Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038145Retail ModulesWeb POSpublic2018-03-14 16:142018-03-27 17:47
Reportershuehner 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038145: org.openbravo.retail.posterminal.term.Warehouses (posterminal + mobile.procurement module) don't use bind-variables
DescriptionThis code should use bind-variables:

    return Arrays
        .asList(new String[] { "select ow.warehouse.id as warehouseid, ow.warehouse.name as warehousename, ow.priority as priority "
            + "from OrganizationWarehouse as ow where ow.$readableSimpleCriteria and ow.$activeCriteria and ow.organization.id = '"
            + orgId + "'" + "order by priority asc" });
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-14 16:14shuehnerNew Issue
2018-03-14 16:14shuehnerAssigned To => Retail
2018-03-14 16:14shuehnerTriggers an Emergency Pack => No
2018-03-14 16:15shuehnerRelationship addedblocks 0038136
2018-03-14 16:35shuehnerAssigned ToRetail => Sandrahuguet
2018-03-14 17:59SandrahuguetStatusnew => scheduled
2018-03-16 08:19hgbotCheckin
2018-03-16 08:19hgbotNote Added: 0103297
2018-03-16 08:19hgbotStatusscheduled => resolved
2018-03-16 08:19hgbotResolutionopen => fixed
2018-03-16 08:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/05fd42e3ed1e74062c66fcbb56c4784f0d4d5e33 [^]
2018-03-16 08:32SandrahuguetReview Assigned To => marvintm
2018-03-19 09:30marvintmStatusresolved => closed
2018-03-19 09:30marvintmFixed in Version => RR18Q2
2018-03-20 08:44SandrahuguetStatusclosed => new
2018-03-20 08:44SandrahuguetResolutionfixed => open
2018-03-20 08:44SandrahuguetFixed in VersionRR18Q2 =>
2018-03-20 08:44SandrahuguetNote Added: 0103360
2018-03-20 09:11hgbotCheckin
2018-03-20 09:11hgbotNote Added: 0103361
2018-03-20 09:13hgbotStatusnew => resolved
2018-03-20 09:13hgbotResolutionopen => fixed
2018-03-20 09:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/05fd42e3ed1e74062c66fcbb56c4784f0d4d5e33 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/21be7942bc2e9c036e93f2772880d19bc6c07c42 [^]
2018-03-20 09:22hgbotCheckin
2018-03-20 09:22hgbotNote Added: 0103362
2018-03-20 11:55hgbotCheckin
2018-03-20 11:55hgbotNote Added: 0103370
2018-03-20 17:59hgbotCheckin
2018-03-20 17:59hgbotNote Added: 0103378
2018-03-27 17:47marvintmStatusresolved => closed
2018-03-27 17:47marvintmFixed in Version => RR18Q2

Notes
(0103297)
hgbot   
2018-03-16 08:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 05fd42e3ed1e74062c66fcbb56c4784f0d4d5e33
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Mar 15 11:22:30 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/05fd42e3ed1e74062c66fcbb56c4784f0d4d5e33 [^]

Fixed bug 38145 use bind-parameters in Warehouses query

---
M src/org/openbravo/retail/posterminal/term/Warehouses.java
---
(0103360)
Sandrahuguet   
2018-03-20 08:44   
missing the fix in mobile.procurement
(0103361)
hgbot   
2018-03-20 09:11   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: 21be7942bc2e9c036e93f2772880d19bc6c07c42
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Mar 20 09:07:07 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/21be7942bc2e9c036e93f2772880d19bc6c07c42 [^]

Fixed bug 38145 use bind-parameters in Warehouses query

---
M src/org/openbravo/mobile/procurement/term/Warehouses.java
---
(0103362)
hgbot   
2018-03-20 09:22   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: 58f4ef4d7b1493787afca648dc58cc57ad1a072a
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Mar 20 09:22:24 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/58f4ef4d7b1493787afca648dc58cc57ad1a072a [^]

related to issue 38145 delete unnecessary variables

---
M src/org/openbravo/mobile/procurement/term/Warehouses.java
---
(0103370)
hgbot   
2018-03-20 11:55   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: 7ee0cd30231c617fa243d52fd89ea8e2d5c2b78d
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Mar 20 11:55:10 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/7ee0cd30231c617fa243d52fd89ea8e2d5c2b78d [^]

related to issue 38145 delete unnecessary import and update Copyright

---
M src/org/openbravo/mobile/procurement/term/Warehouses.java
---
(0103378)
hgbot   
2018-03-20 17:59   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: b80a5721b391eae64fddbfd9de564708af683e76
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Mar 20 17:59:48 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/b80a5721b391eae64fddbfd9de564708af683e76 [^]

related to issue 38145 applied correct formater

---
M src/org/openbravo/mobile/procurement/term/Warehouses.java
---