0038141: FIN_Utility.getDocumentType is not using bind-variables

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038141

Openbravo ERP

07. Sales management

public

2018-03-14 15:09

2018-03-19 16:19

Reporter

shuehner

Assigned To

Sandrahuguet

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR18Q2

Merge Request Status

Review Assigned To

aferraz

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0038141: FIN_Utility.getDocumentType is not using bind-variables

Description

The following code is not using bind-variables:
see tracking issue for list of reasons why that is bad.

      whereOrderByClause.append(" as dt where dt.organization.id in (");
      whereOrderByClause.append(Utility.getInStrSet(new OrganizationStructureProvider()
          .getParentTree(org.getId(), true)));
      whereOrderByClause.append(") and dt.client.id = '" + client.getId()
          + "' and dt.documentCategory = '" + docCategory + "' order by ad_isorgincluded('"
          + org.getId() + "', dt.organization.id, '" + client.getId()
          + "') , dt.default desc, dt.id desc");
      OBQuery<DocumentType> dt = OBDal.getInstance().createQuery(DocumentType.class,
          whereOrderByClause.toString());

Steps To Reproduce

Proposed Solution

Additional Information