Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038127Retail ModulesStoreServerpublic2018-03-13 19:552018-03-27 15:32
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038127: Storeserver allow going online even if there are pending data to sync from CS to SS
DescriptionThe current logic [1] prevents the store from going online if CS has pending data to sync to the store.

This is too restrictive with the new approach (see related issue) we can go online eventhough there is data to sync.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/SyncStatusOnlineTransitionHandler.java#l83 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/RetrieveSyncStatus.java [^]
Steps To ReproduceRun multi-server
Stop SS
Change data in CS
Stop CS
Start SS
Start CS

Check if/how SS goes online if there is data to sync.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0038036 closed mtaal SS in online mode always forward all requests to the CS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-13 19:55mtaalNew Issue
2018-03-13 19:55mtaalAssigned To => mtaal
2018-03-13 19:55mtaalTriggers an Emergency Pack => No
2018-03-13 19:55mtaalRelationship addedrelated to 0038036
2018-03-14 10:06rafademiguelIssue Monitored: rafademiguel
2018-03-14 23:56mtaalReview Assigned To => AugustoMauch
2018-03-14 23:56hgbotCheckin
2018-03-14 23:56hgbotNote Added: 0103260
2018-03-14 23:56hgbotStatusnew => resolved
2018-03-14 23:56hgbotResolutionopen => fixed
2018-03-14 23:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/ae17eaae44bd67b8f98d6eb622e07e86eedb8ee4 [^]
2018-03-27 15:32AugustoMauchNote Added: 0103566
2018-03-27 15:32AugustoMauchStatusresolved => closed

Notes
(0103260)
hgbot   
2018-03-14 23:56   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: ae17eaae44bd67b8f98d6eb622e07e86eedb8ee4
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Mar 14 23:56:32 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/ae17eaae44bd67b8f98d6eb622e07e86eedb8ee4 [^]

Fixes issue 38127: Storeserver allow going online even if there are pending data to sync from CS to SS
Only use import entry count on CS to determine online decision

---
M src/org/openbravo/retail/storeserver/synchronization/RetrieveSyncStatus.java
M src/org/openbravo/retail/storeserver/synchronization/SyncStatusOnlineTransitionHandler.java
---
(0103566)
AugustoMauch   
2018-03-27 15:32   
Code reviewed and verified