Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038102Openbravo ERP04. Warehouse managementpublic2018-03-12 14:492018-03-29 13:07
Reporterngarcia 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket629
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038102: Different behavior in automatic creation of negative goods shipment depending on the product having stock or not
DescriptionDifferent behavior in automatic creation of negative goods shipment depending on the product having stock or not.

Automatic Goods Shipments are created in:

- Create Shipments From Orders
- Sales Order (Warehouse Order and POS Order document types)
Steps To ReproduceAs group admin role:
   Create a new product
   Add a sales price to it
   Create a sales order
   Add a product with stock
   Set a negative quantity
   Book it
   Go to Create Shipments From Orders and select previously created order
   Check the Goods Shipment can be created correctly

   Create a sales order
   Select Warehouse Order document Type
   Add a product with stock
   Set a negative quantity
   Check you can book it

   Create a sales order
   Select POS Order document Type
   Add a product with stock
   Set a negative quantity
   Check you can book it

   Create a sales order
   Select Warehouse Order document Type
   Add the previously created product (without stock)
   Set a negative quantity
   Try to book it and check the following error message is shown:
      "In line10 has no storage bin defined"
   
   Change the document type to "POS Order" and check the problem is the same
   Change the document type to Standard Order and book it

   Go to Create Shipments From Orders and select previously created order
   Check the following error message is shown:
      Order No. <>: No shipment could be created.
      Order line: 10 Insufficient stock: for product <>.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-12 14:49ngarciaNew Issue
2018-03-12 14:49ngarciaAssigned To => Triage Finance
2018-03-12 14:49ngarciaOBNetwork customer => Yes
2018-03-12 14:49ngarciaModules => Core
2018-03-12 14:49ngarciaSupport ticket => 629
2018-03-12 14:49ngarciaResolution time => 1522620000
2018-03-12 14:49ngarciaTriggers an Emergency Pack => No
2018-03-12 14:50ngarciaIssue Monitored: networkb
2018-03-12 14:54PracticsIssue Monitored: Practics
2018-03-12 16:25aferrazAssigned ToTriage Finance => collazoandy4
2018-03-12 16:56collazoandy4Statusnew => scheduled
2018-03-14 15:27collazoandy4Note Added: 0103242
2018-03-14 16:53collazoandy4Note Edited: 0103242bug_revision_view_page.php?bugnote_id=0103242#r16844
2018-03-22 09:44ngarciaSummaryDifferent behavior in automatic creation of negative goods shipment if the product depending on the product having stock or not => Different behavior in automatic creation of negative goods shipment depending on the product having stock or not
2018-03-22 09:44ngarciaDescription Updatedbug_revision_view_page.php?rev_id=16910#r16910
2018-03-22 09:50ngarciaDescription Updatedbug_revision_view_page.php?rev_id=16911#r16911
2018-03-23 20:42collazoandy4Note Edited: 0103242bug_revision_view_page.php?bugnote_id=0103242#r16928
2018-03-26 18:41hgbotCheckin
2018-03-26 18:41hgbotNote Added: 0103546
2018-03-26 18:41hgbotStatusscheduled => resolved
2018-03-26 18:41hgbotResolutionopen => fixed
2018-03-26 18:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2807ccffa5464dbf8ba634861f813953aa606fd6 [^]
2018-03-26 18:41dmiguelezReview Assigned To => dmiguelez
2018-03-26 18:41dmiguelezNote Added: 0103547
2018-03-26 18:41dmiguelezStatusresolved => closed
2018-03-26 18:41dmiguelezFixed in Version => 3.0PR18Q2
2018-03-29 13:07hudsonbotCheckin
2018-03-29 13:07hudsonbotNote Added: 0103635

Notes
(0103242)
collazoandy4   
2018-03-14 15:27   
(edited on: 2018-03-23 20:42)
Test Plan
  Go to Sales Order window and create a new record:
    Business Partner: Hoteles Buenas Noches, S.A.
    Document Type: Warehouse Order document
    Add a product with stock
    Book the order and check the process ends successfully and the order delivery status is 100%

Test Plan II
  Repeat the previous test plan using POS Order Document Type

Test Plan III
  Go to Sales Order window and create a new record:
    Business Partner: Hoteles Buenas Noches, S.A.
    Document Type: Standard Order
    Add a product with stock
    Book the order and check the process ends successfully
  Go to Create Shipments from Orders window and select the previous order created process it and check the process ends successfully

Test Plan IV
  Go to Product window and create a new record:
    Search Key/Name: 38102Product
    Add a sales price list
  Go to Sales Order window and create a new record:
    Business Partner: Hoteles Buenas Noches, S.A.
    Document Type: Standard Order
    Add the previous product created to Lines tab
    Book the order and check the process ends successfully
  Go to Create Shipments from Orders window and select the previous order created process it and check the process shows the error message: Order line: 10 Insufficient stock: for product 38102Product.

Test Plan V
  Go to Sales Order window and create a new record:
    Business Partner: Hoteles Buenas Noches, S.A.
    Document Type: Warehouse Order document
    Add the previous product created to Lines tab
    Book the order and check the process shows an error message: Order line: 10 Insufficient stock: for product 38102Product.

Test Plan VI
  Repeat the previous test plan using POS Order Document Type

Test Plan VII
  Repeat all previous tests plans with a negative qty and check the process ends successfull and the product stock is increased

Test Plan VIII
  As System Admin Role
    Set Displayed: Y to Generate Receipt from Invoice field in Purchase Invoice Header tab
  Rebuild the application

  As F&B International Group Admin Role
    Go to Purchase Invoice window and create a new record:
      Business Partner: Bebidas Alegres, S.L.
      Add a product to it and Book it
      Click on Generate Receipt from Invoice button and check the process ends successfully and a new receipt was created for the invoice
(0103546)
hgbot   
2018-03-26 18:41   
Repository: erp/devel/pi
Changeset: 2807ccffa5464dbf8ba634861f813953aa606fd6
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Mar 23 09:29:15 2018 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/2807ccffa5464dbf8ba634861f813953aa606fd6 [^]

Fixes issue 38102: Different behavior in automatic creation of negative goods
shipment if the product depending on the product having stock or not

When completing a Warehouse or POS order and at least one line have Insufficient
stock for a product the proper error message doesn't shown in the order window,
also if the product have a negative qty the process fail

Now the correct error message is shown when there is Insufficient stock for a product
and a negative Warehouse or Pos order can be completed as a negative shipment increase
the product stock

---
M src-db/database/model/functions/M_INOUT_CREATE.xml
---
(0103547)
dmiguelez   
2018-03-26 18:41   
Code Review + Testing Ok
(0103635)
hudsonbot   
2018-03-29 13:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ead4656f507e [^]
Maturity status: Test