Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038099Openbravo ERPA. Platformpublic2018-03-12 08:342018-06-22 12:50
Reporteralostale 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q3Fixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038099: upgrade from <3.0PR15Q4 preserves old pool config
DescriptionWhen updating an instance from <3.0PR15Q4, if it used old Apache Commons DBCP pool, the upgrader keeps that configuration.

This configuration should be automatically replaced to use newer Tomcat pool.
Steps To ReproduceUpgrade an instance and check it continues using old pool
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00295643.0PR15Q4 closed inigosanchez Include Connection Pool module into distribution 
related to defect 0037532 acknowledged Triage Platform Base SessionHandler creates session without setting a connection when not using the Tomcat pool 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-12 08:34alostaleNew Issue
2018-03-12 08:34alostaleAssigned To => platform
2018-03-12 08:34alostaleModules => Core
2018-03-12 08:34alostaleTriggers an Emergency Pack => No
2018-03-12 09:05alostaleRelationship addedrelated to 0029564
2018-05-21 09:04alostaleTarget Version => 3.0PR18Q3
2018-05-25 14:07caristuRelationship addedrelated to 0037532
2018-06-11 09:05jarmendarizAssigned Toplatform => jarmendariz
2018-06-12 13:05jarmendarizStatusnew => scheduled
2018-06-12 13:06jarmendarizReview Assigned To => caristu
2018-06-14 18:16hgbotCheckin
2018-06-14 18:16hgbotNote Added: 0105150
2018-06-14 18:16hgbotStatusscheduled => resolved
2018-06-14 18:16hgbotResolutionopen => fixed
2018-06-14 18:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9ef9e20d439e7ea5c450306873f5955100ea193d [^]
2018-06-15 12:13hudsonbotCheckin
2018-06-15 12:13hudsonbotNote Added: 0105179
2018-06-22 12:50caristuNote Added: 0105340
2018-06-22 12:50caristuStatusresolved => closed
2018-06-22 12:50caristuFixed in Version => 3.0PR18Q3

Notes
(0105150)
hgbot   
2018-06-14 18:16   
Repository: erp/devel/pi
Changeset: 9ef9e20d439e7ea5c450306873f5955100ea193d
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Mon Jun 11 14:26:36 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9ef9e20d439e7ea5c450306873f5955100ea193d [^]

Fixed issue 38099: Upgrade from <3.0PR15.4 preserves old pool configuration.

3.0PR15.4 includes the Apache JDBC connection pool module as part of Openbravo
distribution and is set as the default DB pool. This changeset enforces upgrading
to the new pool instead of preserving the old Apache commons pool.
This implementation has been tested in the following scenarios:
- From an 3.0PR15Q3 instance with the parameter db.externalPoolClassName not set
or empty: After the upgrade the parameter should refer to the bundled Apache JDBC
pool module.
- From an 3.0PR15Q3 instance with the parameter db.externalPoolClassName set:
Property db.externalPoolClassName should be left as-is.
- Upgrading from a newer version (e.g. 3.0PR16Q1): This validation should not be
executed.

---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/CheckUpdateConnectionPoolMerge.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/CheckUpdateConnectionPoolMerge.java
R src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/CheckUpdateConnectionPoolMergeData.class
R src-util/buildvalidation/src/org/openbravo/buildvalidation/CheckUpdateConnectionPoolMerge_data.xsql
---
(0105179)
hudsonbot   
2018-06-15 12:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dd9c57666e17 [^]
Maturity status: Test
(0105340)
caristu   
2018-06-22 12:50   
Code reviewed + tested OK.