Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038098Openbravo ERPA. Platformpublic2018-03-11 13:012018-03-16 17:29
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038098: Fix new javadoc warnings of -Xdoclint:html active by default as errors since Java 8
DescriptionSince Java8 javadoc has -Xdoclint:html active by default raising issues of level error not just warning.
That essentially enforces proper use of html tags in javadoc comments.

Ubuntu has that locally patched to hide those but they show up when testing with normal upstream Openjdk)

This fixes up all those in pi where most are just basic syntax fixes
- use

and not the xhtml verions


- use
and not the xhtml verions

- use html escape for <, >, &
- proper use of <code> and >ul>

In ReferencedInventoryUtil qualify @value use of 2 constants instead of referencing as local constant as otherwise javadoc from java9+10 doesn't find them.

Steps To ReproduceAdd <arg value="-Xdoclint:-missing" to generate.java.doc.(jdk7,jdk9) and run ant generate.java.doc

That activates all warnings except those enforcing javadoc being present everywhere.
Proposed SolutionFix javadoc comments
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037825 closed shuehner Fix new javadoc warnings active by default in JDK 9 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-11 13:01shuehnerNew Issue
2018-03-11 13:01shuehnerAssigned To => shuehner
2018-03-11 13:01shuehnerModules => Core
2018-03-11 13:01shuehnerTriggers an Emergency Pack => No
2018-03-11 13:03shuehnerIssue generated from0037825
2018-03-11 13:03shuehnerRelationship addedrelated to 0037825
2018-03-11 13:03shuehnerReview Assigned To => alostale
2018-03-15 16:41hgbotCheckin
2018-03-15 16:41hgbotNote Added: 0103282
2018-03-15 16:41hgbotStatusnew => resolved
2018-03-15 16:41hgbotResolutionopen => fixed
2018-03-15 16:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/678132f0a29a4b593e2c8d19afb58ffd3337b36e [^]
2018-03-15 16:44caristuReview Assigned Toalostale => caristu
2018-03-15 16:44caristuNote Added: 0103283
2018-03-15 16:44caristuStatusresolved => closed
2018-03-15 16:44caristuFixed in Version => 3.0PR18Q2
2018-03-15 16:52caristuNote Deleted: 0103283
2018-03-15 16:53hgbotCheckin
2018-03-15 16:53hgbotNote Added: 0103285
2018-03-15 16:53caristuNote Added: 0103286
2018-03-16 17:29hudsonbotCheckin
2018-03-16 17:29hudsonbotNote Added: 0103327

Notes
(0103282)
hgbot   
2018-03-15 16:41   
Repository: erp/devel/pi
Changeset: 678132f0a29a4b593e2c8d19afb58ffd3337b36e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Mar 11 13:10:30 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/678132f0a29a4b593e2c8d19afb58ffd3337b36e [^]

Fixed 38098. Fix all javadoc -Xdoclint:html warnings

Javadoc since java8 enforces stricter correct html use inside javadoc.
That was hidden by a local change done in Ubuntu openjdk packages.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ExtraWindowSettingsInjector.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/TemplateResolver.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/CheckTreeOperationManager.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonToDataConverter.java
M src-core/src/org/openbravo/base/AntExecutor.java
M src-core/src/org/openbravo/base/ConfigParameters.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_18.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_06.java
M src/org/openbravo/base/provider/OBProvider.java
M src/org/openbravo/base/util/OBClassLoader.java
M src/org/openbravo/base/validation/AccessLevelChecker.java
M src/org/openbravo/costing/CostingAlgorithm.java
M src/org/openbravo/dal/core/DalRequestFilter.java
M src/org/openbravo/dal/security/EntityAccessChecker.java
M src/org/openbravo/dal/security/OrganizationStructureProvider.java
M src/org/openbravo/dal/security/SecurityChecker.java
M src/org/openbravo/dal/service/OBCriteria.java
M src/org/openbravo/dal/service/OBDal.java
M src/org/openbravo/dal/xml/EntityResolver.java
M src/org/openbravo/dal/xml/StaxXMLEntityConverter.java
M src/org/openbravo/dal/xml/XMLEntityConverter.java
M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
M src/org/openbravo/erpCommon/ad_forms/DocOrder.java
M src/org/openbravo/erpCommon/ad_forms/DocOrderTemplate.java
M src/org/openbravo/erpCommon/ad_forms/Translation.java
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
M src/org/openbravo/erpCommon/modules/ApplyModule.java
M src/org/openbravo/erpCommon/modules/ModuleUtiltiy.java
M src/org/openbravo/erpCommon/utility/AntExecutor.java
M src/org/openbravo/erpCommon/utility/BasicUtility.java
M src/org/openbravo/erpCommon/utility/CashVATUtil.java
M src/org/openbravo/erpCommon/utility/GenericTree.java
M src/org/openbravo/erpCommon/utility/Utility.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
M src/org/openbravo/service/db/ClientImportEntityResolver.java
M src/org/openbravo/service/db/ImportResult.java
M src/org/openbravo/service/web/BaseWebServiceServlet.java
M src/org/openbravo/service/web/UserContextCache.java
M src/org/openbravo/service/web/WebServiceUtil.java
---
(0103285)
hgbot   
2018-03-15 16:53   
Repository: erp/devel/pi
Changeset: 636948c66791648438db0bc1f27af5b2f331e388
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Mar 11 13:10:30 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/636948c66791648438db0bc1f27af5b2f331e388 [^]

Related to issue 38098. Fix all javadoc -Xdoclint:html warnings

Javadoc since java8 enforces stricter correct html use inside javadoc.
That was hidden by a local change done in Ubuntu openjdk packages.

---
M src-test/src/org/openbravo/test/materialMgmt/iscompletelyinvoicedshipment/ICIUtility.java
M src/org/openbravo/erpCommon/utility/OBMessageUtils.java
---
(0103286)
caristu   
2018-03-15 16:53   
Reviewed + tested OK.
(0103327)
hudsonbot   
2018-03-16 17:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5323533018b6 [^]
Maturity status: Test