Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038097Openbravo ERPA. Platformpublic2018-03-09 15:172018-03-14 18:24
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038097: DalConnectionProvider.getTransactionConnection with dbcp pool does not set db config query
DescriptionConnections obtained using old commons dbcp pool with DalConnectionProvider.getTransactionConnection method, do not set db config query configured in Openbravo.properties.
Steps To Reproduce0. In an Oracle instance configured to use old pool (db.externalPoolClassName=)
1. Run RecordID2Test
  -> They fail with:
14303 [main] ERROR org.openbravo.erpCommon.ad_forms.AcctServerData - SQL error in query: SELECT C_Currency_Convert(TO_NUMBER(?), ?, ?,TO_DATE(?),TO_CHAR(?), ?, ?) AS CONVERTED FROM DUAL :java.sql.SQLDataException: ORA-01843: not a valid month

14314 [main] WARN org.openbravo.erpCommon.ad_forms.AcctServer - javax.servlet.ServletException: @CODE=1843@ORA-01843: not a valid month

javax.servlet.ServletException: @CODE=1843@ORA-01843: not a valid month

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0010330 closed mtaal Unable to Generate and Post Invoices in mass invoicing 
related to defect 0033438 closed alostale DalConnectionProvider.getTransactionConnection does not obtain connection from common pool 
related to defect 0038014 closed alostale DB connection leak using old pool in test cases 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-09 15:17alostaleNew Issue
2018-03-09 15:17alostaleAssigned To => platform
2018-03-09 15:17alostaleModules => Core
2018-03-09 15:17alostaleTriggers an Emergency Pack => No
2018-03-09 15:19alostaleRelationship addedrelated to 0010330
2018-03-09 15:20alostaleRelationship addedrelated to 0033438
2018-03-09 15:24alostaleSummaryDalConnectionProvider. => DalConnectionProvider.getTransactionConnection with dbcp pool does not set db config query
2018-03-09 15:29alostaleRelationship addedrelated to 0038014
2018-03-12 14:50alostaleAssigned Toplatform => alostale
2018-03-12 14:50alostaleReview Assigned To => caristu
2018-03-13 07:40hgbotCheckin
2018-03-13 07:40hgbotNote Added: 0103173
2018-03-13 07:40hgbotStatusnew => resolved
2018-03-13 07:40hgbotResolutionopen => fixed
2018-03-13 07:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/226c41af46d2050c23e717ed197612fbfd3b5300 [^]
2018-03-13 17:24hudsonbotCheckin
2018-03-13 17:24hudsonbotNote Added: 0103215
2018-03-14 18:24caristuNote Added: 0103249
2018-03-14 18:24caristuStatusresolved => closed
2018-03-14 18:24caristuFixed in Version => 3.0PR18Q2

Notes
(0103173)
hgbot   
2018-03-13 07:40   
Repository: erp/devel/pi
Changeset: 226c41af46d2050c23e717ed197612fbfd3b5300
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 09 15:28:54 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/226c41af46d2050c23e717ed197612fbfd3b5300 [^]

fixed bug 38097: DCP.getTransactionConnection in old pool doesn't set db config

  Connections obtained with DalConnectionProvider.getTransactionConnection in old
  pool didn't have executed the db config query.

---
M src/org/openbravo/dal/core/DalSessionFactory.java
M src/org/openbravo/dal/core/SessionHandler.java
---
(0103215)
hudsonbot   
2018-03-13 17:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1d3ccc92fab6 [^]
Maturity status: Test
(0103249)
caristu   
2018-03-14 18:24   
Code reviewed + tested OK.