Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038091Retail ModulesWeb POSpublic2018-03-09 12:202018-03-14 19:47
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038091: JDK 9: Remove [dep-ann] warnings removing deprecated elements
DescriptionThere are some methods/interfaces marked as deprecated in Javadoc but not annotated with @Deprecated. This is a warning from JDK 9. As those methods are not used anywhere, they can be removed to make the warnings dissappear.

The warning appears for the following methods:

MobileCoreLoginHandler.java
  checkConcurrentUsers()

MobileServerUtils.java
  isMobileServerControllerEnabled()

OBMOBCUtils.java
  setCORSHeader(HttpServletRequest, HttpServletResponse)

ExternalOrderLoader.java
  resolve(String,String,String)

POSAppCacheResourceProvider.java <- This interface is not used anywhere. Can be removed

For more details see:
https://docs.google.com/spreadsheets/d/1OsTLaQIb8HUUL7vXiP9O9HMz4N0BLTWEKq4Qoyt_gEI/edit?usp=sharing [^]
Steps To ReproduceSee above
Proposed SolutionJust remove the deprecated methods/interfaces shown.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037942 closed jarmendariz Openbravo ERP JDK 9: remove [dep-ann] warnings by removing deprecated elements 
related to feature request 0037083 closed alostale Openbravo ERP support JDK 9 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-09 12:20jarmendarizNew Issue
2018-03-09 12:20jarmendarizAssigned To => Retail
2018-03-09 12:20jarmendarizOBNetwork customer => No
2018-03-09 12:20jarmendarizTriggers an Emergency Pack => No
2018-03-09 12:25jarmendarizRelationship addedrelated to 0038055
2018-03-13 16:24hgbotCheckin
2018-03-13 16:24hgbotNote Added: 0103200
2018-03-13 16:24hgbotStatusnew => resolved
2018-03-13 16:24hgbotResolutionopen => fixed
2018-03-13 16:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f240eaebf6f654610ad0d6ecb6d12e462daf8feb [^]
2018-03-13 16:25hgbotCheckin
2018-03-13 16:25hgbotNote Added: 0103202
2018-03-13 16:25hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f240eaebf6f654610ad0d6ecb6d12e462daf8feb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bce373858d2956593de99e574f280eeb3b522a1a [^]
2018-03-13 16:28jarmendarizAssigned ToRetail => jarmendariz
2018-03-13 16:28jarmendarizReview Assigned To => caristu
2018-03-13 16:30caristuRelationship deletedrelated to 0038055
2018-03-13 16:30caristuRelationship addedrelated to 0037942
2018-03-13 16:31caristuRelationship addedrelated to 0037083
2018-03-14 09:21hgbotCheckin
2018-03-14 09:21hgbotNote Added: 0103230
2018-03-14 19:45hgbotCheckin
2018-03-14 19:45hgbotNote Added: 0103255
2018-03-14 19:47caristuNote Added: 0103256
2018-03-14 19:47caristuStatusresolved => closed
2018-03-14 19:47caristuFixed in Version => RR18Q2

Notes
(0103200)
hgbot   
2018-03-13 16:24   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f240eaebf6f654610ad0d6ecb6d12e462daf8feb
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Mar 13 16:14:41 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f240eaebf6f654610ad0d6ecb6d12e462daf8feb [^]

Fixed bug 38091: Removed unused and deprecated methods/classes

This fix removes [dep-ann] warnings starting from JDK9.

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginHandler.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java
M src/org/openbravo/mobile/core/utils/OBMOBCUtils.java
---
(0103202)
hgbot   
2018-03-13 16:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bce373858d2956593de99e574f280eeb3b522a1a
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Mar 13 16:18:01 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bce373858d2956593de99e574f280eeb3b522a1a [^]

Fixed bug 38091: Removed unused and deprecated methods/classes

This fix removes [dep-ann] warnings starting from JDK9.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/POSAppCacheResourceProvider.java
---
(0103230)
hgbot   
2018-03-14 09:21   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2dd526e947bdb20be41a157f858c669e9ddef259
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Mar 14 09:20:50 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2dd526e947bdb20be41a157f858c669e9ddef259 [^]

Related to bug 38091: Remove [dep-ann] warnings in JDK9

Marking some methods/constants as deprecated both in Javadoc and with annotation.

---
M src/org/openbravo/mobile/core/process/JSONProcessSimple.java
M src/org/openbravo/mobile/core/process/MobileService.java
M src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java
---
(0103255)
hgbot   
2018-03-14 19:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fa86be35660857dc79129448eadabe7b1480c2d5
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Mar 14 19:44:52 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fa86be35660857dc79129448eadabe7b1480c2d5 [^]

related to bug 38091: add missing deprecated tag in javadoc text

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0103256)
caristu   
2018-03-14 19:47   
Verified