Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038066Openbravo ERPA. Platformpublic2018-03-07 13:522018-03-13 17:23
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-11-08
Regression introduced in release3.0PR17Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/7acec5407733 [^]
Triggers an Emergency PackNo
Summary0038066: incorrect view cache in browser for windows with server display logic
DescriptionView definition for windows that have at least a field with server side display logic are not correctly cached in browser if there is no preference configuring that field.

The affected windows are:

select distinct w.name from ad_field f, ad_tab t, ad_window w where displaylogic_server is not null and f.ad_Tab_id = t.ad_tab_id and w.ad_window_id = t.ad_window_id order by 1;
            name
-----------------------------
 Create Purchase Order Lines
 Goods Movements
 Goods Receipt
 Goods Shipment
 Manage Requisitions
 Purchase Invoice
 Purchase Order
 Referenced Inventory
 Requisition
 Return from Customer
 Return Material Receipt
 Return to Vendor
 Return to Vendor Shipment
 Sales Invoice
 Sales Order
 Sales Quotation
(16 rows)
Steps To Reproduce1. Log in as Openbravo
2. Open dev tools to check requests
3. Open Sales Order window
   -> OK: a request to View?viewId=_143 is triggered with response code 200 (success)
4. Close Sales Order window and reopen it in the same session
   -> OK: no request is perfomed
5. Close session and log in again with Openbravo user in the same browser
6. Open Sales Order window
   -> GOT: a request to View?viewId=_143 is triggered with response code 200
      EXPECTED: a request to View?viewId=_143 with response code 304 (not modified)

Proposed Solution
Additional Information
TagsPerformance
Relationships
related to design defect 0037999 closed platform Performance issue opening a window with hundreds of fields distributed on different tabs. 
depends on backport 00380683.0PR18Q1.1 closed alostale incorrect view cache in browse for windows with server display logic 
depends on backport 00380693.0PR17Q4.2 closed alostale incorrect view cache in browse for windows with server display logic 
caused by feature request 0034406 closed dmiguelez Add ability to evaluate Display Logic at Server Level 
related to design defect 0039670 closed alostale view generation scalability issues 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-07 13:52alostaleNew Issue
2018-03-07 13:52alostaleAssigned To => platform
2018-03-07 13:52alostaleModules => Core
2018-03-07 13:52alostaleTriggers an Emergency Pack => No
2018-03-07 13:54alostaleTag Attached: Performance
2018-03-07 13:55alostaleReview Assigned To => caristu
2018-03-07 13:55alostaleRegression level => Production - Confirmed Stable
2018-03-07 13:55alostaleRegression date => 2016-11-08
2018-03-07 13:55alostaleRegression introduced in release => 3.0PR17Q1
2018-03-07 13:55alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/7acec5407733 [^]
2018-03-07 13:55alostalePrioritynormal => immediate
2018-03-07 13:55alostaleRelationship addedcaused by 0034406
2018-03-07 14:13alostaleAssigned Toplatform => alostale
2018-03-07 14:18alostaleStatusnew => scheduled
2018-03-07 14:22alostaleSummaryincorrect view cache in browse for windows with server display logic => incorrect view cache in browser for windows with server display logic
2018-03-07 18:09egoitzRelationship addedrelated to 0037999
2018-03-07 18:10egoitzIssue Monitored: egoitz
2018-03-08 10:11hgbotCheckin
2018-03-08 10:11hgbotNote Added: 0103075
2018-03-08 10:11hgbotStatusscheduled => resolved
2018-03-08 10:11hgbotResolutionopen => fixed
2018-03-08 10:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/253508d68cbfc9cf0bf3c1a493ac101e27f5a4dd [^]
2018-03-08 10:11hgbotCheckin
2018-03-08 10:11hgbotNote Added: 0103076
2018-03-08 10:18hgbotCheckin
2018-03-08 10:18hgbotNote Added: 0103077
2018-03-08 16:51hudsonbotCheckin
2018-03-08 16:51hudsonbotNote Added: 0103096
2018-03-08 16:51hudsonbotCheckin
2018-03-08 16:51hudsonbotNote Added: 0103097
2018-03-09 04:28hudsonbotCheckin
2018-03-09 04:28hudsonbotNote Added: 0103105
2018-03-12 12:42hgbotCheckin
2018-03-12 12:42hgbotNote Added: 0103151
2018-03-12 12:55hgbotCheckin
2018-03-12 12:55hgbotNote Added: 0103153
2018-03-12 13:03caristuNote Added: 0103154
2018-03-12 13:03caristuStatusresolved => closed
2018-03-12 13:03caristuFixed in Version => 3.0PR18Q2
2018-03-13 17:23hudsonbotCheckin
2018-03-13 17:23hudsonbotNote Added: 0103210
2018-03-13 17:23hudsonbotCheckin
2018-03-13 17:23hudsonbotNote Added: 0103211
2018-11-22 09:13alostaleRelationship addedrelated to 0039670

Notes
(0103075)
hgbot   
2018-03-08 10:11   
Repository: erp/devel/pi
Changeset: 253508d68cbfc9cf0bf3c1a493ac101e27f5a4dd
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 07 14:26:09 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/253508d68cbfc9cf0bf3c1a493ac101e27f5a4dd [^]

fixed bug 38066: no view cache in browser for windows with server display logic

  Window having at least a field with server side display logic were not cached
  in browser if there was no preference configuring that display logic.

  The problem was cuased by an incorrect eTag calculation that if not preference
  was set a date in future was set including current hour.

  The fix:
   * Simplifies eTag calculation for this case: if no preference defined, no need
     to add any date.
   * Uses for StringBuilder for String concatenation to slightly improve performance

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
---
(0103076)
hgbot   
2018-03-08 10:11   
Repository: erp/devel/pi
Changeset: 92b12ce052c6dffbf6c6a573ae32757b08babd6d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 08 10:10:30 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/92b12ce052c6dffbf6c6a573ae32757b08babd6d [^]

related to bug 38066: added test case

---
M src-test/src/org/openbravo/test/AllWebserviceTests.java
M src-test/src/org/openbravo/test/datasource/BaseDataSourceTestDal.java
M src-test/src/org/openbravo/test/datasource/DatasourceTestUtil.java
A src-test/src/org/openbravo/test/views/ETagGeneration.java
---
(0103077)
hgbot   
2018-03-08 10:18   
Repository: erp/devel/pi
Changeset: 0c460868d807e1d7ad12b5c1ed5893d0a5cc894a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 08 10:17:46 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0c460868d807e1d7ad12b5c1ed5893d0a5cc894a [^]

related to bug 38066: updated copyright

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
---
(0103096)
hudsonbot   
2018-03-08 16:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bce7d98857dd [^]
Maturity status: Test
(0103097)
hudsonbot   
2018-03-08 16:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bce7d98857dd [^]
Maturity status: Test
(0103105)
hudsonbot   
2018-03-09 04:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0d8dac9d2802 [^]
Maturity status: Test
(0103151)
hgbot   
2018-03-12 12:42   
Repository: erp/devel/pi
Changeset: aa980425cd68a277618322131c6c8301075a1eb1
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Mar 12 12:42:12 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aa980425cd68a277618322131c6c8301075a1eb1 [^]

related to issue 38066: fix typo

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
---
(0103153)
hgbot   
2018-03-12 12:55   
Repository: erp/devel/pi
Changeset: b87b8a66ba6b528bd6c2c8b4091fbf778cf9184b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Mar 12 12:55:00 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b87b8a66ba6b528bd6c2c8b4091fbf778cf9184b [^]

related to issue 38066: javadoc improvements

---
M src-test/src/org/openbravo/test/datasource/BaseDataSourceTestDal.java
---
(0103154)
caristu   
2018-03-12 13:03   
Code reviewed + tested OK.
(0103210)
hudsonbot   
2018-03-13 17:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1d3ccc92fab6 [^]
Maturity status: Test
(0103211)
hudsonbot   
2018-03-13 17:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1d3ccc92fab6 [^]
Maturity status: Test