Openbravo Issue Tracking System - Modules
View Issue Details
0038064ModulesAdvanced Warehouse Operationspublic2018-03-07 09:372018-03-09 11:14
maarten1962 
dmiguelez 
urgentmajoralways
closedfixed 
5
 
 
dmiguelez
0038064: Meesage "Product does not have SBG-List for warehouse ..." in untrue moments
This message comes in an irrelevant moment:

When picking-sales order, the PA-algorithm tries to resolve the To-Bin. This is typically shipping and in a functional IRA.
If there is no bin in the destiny routing (missing setup), the system gives the message "Product has no SBG-List".

1. This is irrelevant because the SBG-List is only relevant when doing a PUT-TR (put-away) not for picking and only when to the-IRA is Non-Functional.
2. This is untrue because the product has an SBG-List AND there is a SBG for the relevant warehouse.

It is clear that the system can not resolve the To-Bin. The message should indicate this, f.i. "Can not resolve To-Bin". This can only be concluded after executing the PA-Algorithm, and when the PA-Algorithm <> Null (because -eventhough empty- the system succesfully resolved the To-Bin NULL.
Make sure that the routing points to an IRA without any bins. Then pick a sales order and the message will appear.
No tags attached.
Issue History
2018-03-07 09:37maarten1962New Issue
2018-03-07 09:37maarten1962Assigned To => dmiguelez
2018-03-08 16:08dmiguelezNote Added: 0103088
2018-03-08 16:08dmiguelezNote Added: 0103089
2018-03-08 16:25hgbotCheckin
2018-03-08 16:25hgbotNote Added: 0103090
2018-03-08 16:25hgbotStatusnew => resolved
2018-03-08 16:25hgbotResolutionopen => fixed
2018-03-08 16:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/b2dc866a3e47109f1de62b0e34f890788abb9fa7 [^]
2018-03-08 16:26dmiguelezReview Assigned To => dmiguelez
2018-03-08 16:26dmiguelezNote Added: 0103091
2018-03-08 16:26dmiguelezStatusresolved => closed
2018-03-09 11:14maarten1962Note Added: 0103121
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0103088)
dmiguelez   
2018-03-08 16:08   
The fix is to improve the message.

The error itself is correct. There must be always at least one Bin defined for each Internal Routing Area. If not, it would be impossible to confirm the Task
(0103089)
dmiguelez   
2018-03-08 16:08   
Test Plan:

With AWO and AWO Sampledata installed.

Go to Warehouse Definition Window.
Select US West Coast Warehosue.
Move to Storage Bin Tab.
Select Storage Bin with search Key SHP301 and change it's Storage Bin Group to Inspection

Create a new Sales Order for Organization US and Business Partner Healthy Food
Create a new Line with Product Apple 10 Units.
Complete the Sales Order.

Click on Pick.

Check that this message is shown:
"Error: Internal Routing Area To must have at least one Storage Bin defined and Product Apple must have SBG List with this Internal Routing Area if it is defined as non-functional"
(0103090)
hgbot   
2018-03-08 16:25   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: b2dc866a3e47109f1de62b0e34f890788abb9fa7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Mar 08 16:10:27 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/b2dc866a3e47109f1de62b0e34f890788abb9fa7 [^]

Fixes Issue 38064. Improves error message

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/TaskProposalsGenerator.java
---
(0103091)
dmiguelez   
2018-03-08 16:26   
Code Review + Testing Ok
(0103121)
maarten1962   
2018-03-09 11:14   
Replying to "The error itself is correct. There must be always at least one Bin defined for each Internal Routing Area. If not, it would be impossible to confirm the Task":

The error is not correct.
1. If the algorithm "NULL" is assigned, then the task can be created without a To-Bin.
2. The SBG-List is only relevant for put-away and when to to-IRA is non-functional.
So a different check should be done: Not on the SBG-List but if the To-Bin can not be resolved. This check is due AFTER the algorithms and should result in error only when the algorithm is not NULL.