Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038055Openbravo ERPA. Platformpublic2018-03-06 13:162018-03-14 18:03
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038055: API Change: Remove deprecated constants/methods
DescriptionSome public constants/methods are marked as deprecated in the Javadocs but not with the annotation (which leads to the dep-ann warning mentioned in 0037942). The following can be safely removed as they're not used neither in the ERP nor in the modules published in the forge.

Deprecated constants:
KernelConstants.SKIN_VERSION_300
KernelConstants.SKIN_VERSION_CLASSIC
Reference.TABLE_VALIDATION
Reference.SEARCH_VALIDATION
Reference.LIST_VALIDATION

Deprecated methods:
- Reference.java
  getAllowedValues()
  getValidationType()
  isDate()
  isDatetime()
  setValidationType(char)
  setAllowedValue(String)
  getPrimitiveType(String)

- ActivationKey.java
  constructor

- ModelXMLConverter.java
  addReferenceAttributes(Element)

- ImportModule.java
  checkDependenciesFileName(String)
  checkDependenciesId(String[], String[])
  getInstalledModules(ConnectionProvider)

- VersionUtility.java
  checkLocal(VariableSecureApp, Module[], OBError)
  checkLocal(VariableSecureApp, Module[], Module[], OBError)
  checkRemote(VariableSecureApp, String[], String[], OBError)

- HttpsUtils.java
  encode(String,String)
  isInternetAvailable(String, int)
  sendHttpsRequest(URL, String, String, String)
  sendSecure(URL, String, String, String)
  getHttpsConn(URL, String, String)
  
- ModelProvider.java
  getColumnByReference(String,String,char,String)

- ApplicationDictionaryCachedStructure.java
  getComboTableData(VariableSecureApp, String, String, String, String, String, String)

- SequenceIdData.java
  getSequence(ConnectionProvider, String, String)
  getSequenceConnection(Connection, ConnectionProvider, String, String)

- HttpSecureAppServlet.java
  readProperties(VariablesSecureApp, String)

- SystemService.java
  removeAllClientData(String)

- SessionLogin.java
  save(ConnectionProvider)

- RefList.java
  setAllowedValue()

- MenuManager.java
  setMenu(Menu)

- HeartbeatProcess.java
  showHeartBeatOrRegistration(VariableSecureApp, ConnectionProvider)

For more details see:

https://docs.google.com/spreadsheets/d/1OsTLaQIb8HUUL7vXiP9O9HMz4N0BLTWEKq4Qoyt_gEI/edit?usp=sharing [^]
Steps To ReproduceSee description
Proposed Solution
Additional Information
TagsApproved
Relationships
related to defect 0037942 closed jarmendariz JDK 9: remove [dep-ann] warnings by removing deprecated elements 
Attached Filespatch dep-ann-warning.patch (52,945) 2018-03-07 16:00
https://issues.openbravo.com/file_download.php?file_id=11622&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-03-06 13:16jarmendarizNew Issue
2018-03-06 13:16jarmendarizAssigned To => platform
2018-03-06 13:16jarmendarizModules => Core
2018-03-06 13:16jarmendarizTriggers an Emergency Pack => No
2018-03-06 13:16jarmendarizRelationship addedrelated to 0037942
2018-03-07 12:17alostaleTag Attached: Approved
2018-03-07 12:17alostaleAssigned Toplatform => jarmendariz
2018-03-07 16:00jarmendarizFile Added: dep-ann-warning.patch
2018-03-07 16:00jarmendarizReview Assigned To => caristu
2018-03-07 16:00jarmendarizStatusnew => scheduled
2018-03-09 11:19hgbotCheckin
2018-03-09 11:19hgbotNote Added: 0103123
2018-03-09 11:19hgbotStatusscheduled => resolved
2018-03-09 11:19hgbotResolutionopen => fixed
2018-03-09 11:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/02185c797531d5bf3f8f28ac89683f4daba88075 [^]
2018-03-09 12:25jarmendarizRelationship addedrelated to 0038091
2018-03-12 09:05hgbotCheckin
2018-03-12 09:05hgbotNote Added: 0103145
2018-03-12 09:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/02185c797531d5bf3f8f28ac89683f4daba88075 [^] => http://code.openbravo.com/retail/api-checks-retail/rev/18cc989d1797d74bf4ba30561139d5d9398cd1db [^]
2018-03-12 19:19caristuNote Added: 0103167
2018-03-12 19:19caristuStatusresolved => closed
2018-03-12 19:19caristuFixed in Version => 3.0PR18Q2
2018-03-13 09:00hgbotCheckin
2018-03-13 09:01hgbotNote Added: 0103176
2018-03-13 09:03hgbotStatusclosed => resolved
2018-03-13 09:03hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/api-checks-retail/rev/18cc989d1797d74bf4ba30561139d5d9398cd1db [^] => http://code.openbravo.com/retail/api-checks-retail/rev/c7569fd17f5fb8ffb2151273f1b75709c6ebc4f2 [^]
2018-03-13 09:38caristuNote Added: 0103177
2018-03-13 09:38caristuStatusresolved => closed
2018-03-13 09:38caristuNote Deleted: 0103167
2018-03-13 12:54hgbotCheckin
2018-03-13 12:54hgbotNote Added: 0103188
2018-03-13 12:54hgbotStatusclosed => resolved
2018-03-13 12:54hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/api-checks-retail/rev/c7569fd17f5fb8ffb2151273f1b75709c6ebc4f2 [^] => http://code.openbravo.com/retail/api-checks-retail/rev/ba5fa4b99a234b8718c5e50e6b601d7a9457588f [^]
2018-03-13 12:55hgbotCheckin
2018-03-13 12:55hgbotNote Added: 0103189
2018-03-13 12:55hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/api-checks-retail/rev/ba5fa4b99a234b8718c5e50e6b601d7a9457588f [^] => http://code.openbravo.com/retail/api-checks-retail/rev/73587286ee5807b9cbe8d2e018bb45435af96881 [^]
2018-03-13 16:30caristuRelationship deletedrelated to 0038091
2018-03-14 18:03caristuNote Deleted: 0103177
2018-03-14 18:03caristuNote Added: 0103248
2018-03-14 18:03caristuStatusresolved => closed

Notes
(0103123)
hgbot   
2018-03-09 11:19   
Repository: erp/devel/api-checks
Changeset: 02185c797531d5bf3f8f28ac89683f4daba88075
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Mar 09 11:19:01 2018 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/02185c797531d5bf3f8f28ac89683f4daba88075 [^]

Fixes bug 38055: Removed deprecated constants and methods

---
M java/reference/java.japi.gz
---
(0103145)
hgbot   
2018-03-12 09:05   
Repository: retail/api-checks-retail
Changeset: 18cc989d1797d74bf4ba30561139d5d9398cd1db
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Mar 12 09:05:41 2018 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/18cc989d1797d74bf4ba30561139d5d9398cd1db [^]

Fixes bug 38055: Removed deprecated constants and methods. Changed retail part

---
M java/reference/java.japi.gz
---
(0103176)
hgbot   
2018-03-13 09:00   
Repository: retail/api-checks-retail
Changeset: c7569fd17f5fb8ffb2151273f1b75709c6ebc4f2
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Mar 13 08:59:04 2018 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/c7569fd17f5fb8ffb2151273f1b75709c6ebc4f2 [^]

Fixes bug 38055: Removed deprecated constants and methods. Changed retail part

---
M java/reference/java.japi.gz
---
(0103188)
hgbot   
2018-03-13 12:54   
Repository: retail/api-checks-retail
Changeset: ba5fa4b99a234b8718c5e50e6b601d7a9457588f
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Mar 13 12:54:42 2018 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/ba5fa4b99a234b8718c5e50e6b601d7a9457588f [^]

Fixes bug 38055: Removed deprecated constants and methods. Changed retail part

---
M java/reference/java.japi.gz
---
(0103189)
hgbot   
2018-03-13 12:55   
Repository: retail/api-checks-retail
Changeset: 73587286ee5807b9cbe8d2e018bb45435af96881
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Mar 13 12:55:42 2018 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/73587286ee5807b9cbe8d2e018bb45435af96881 [^]

Fixes bug 38055: Removed deprecated constants and methods. Changed retail part

---
M java/reference/java.japi.gz
---
(0103248)
caristu   
2018-03-14 18:03   
Verified