Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038039Openbravo ERPA. Platformpublic2018-03-05 12:572018-03-27 09:12
Reportervmromanos 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q2Fixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038039: Organization filtering issues in Process Definition selectors
DescriptionI have the same selector two times in a Process Definition (see screenshot):
1. At "header" level
2. At "grid" (window reference) level

The Process Definition is executed from a window, selecting any record.
The organization filtering in the selector is different depending on where the selector is placed:
1. At header lever it properly filters by records in the natural tree of the record's organization
2. At grid level it doesn't apply any filter and shows any record regardless of the organization natural tree.

This inconsistency is wrong and the selector at grid level should have the same filtering as the header's level one.
Steps To ReproduceThis can be reproduced using the Referenced Inventory feature.

As System Admin:
Go to Process Definition and select "ReferencedInventoryUnBoxHandler"
Add a new parameter:
 M_Locator_ID
 OBUISEL_Selector Reference
 On Hand Locator


As F&B Admin:
Go to Referenced Inventory Type and create a new record for F&B US
Go to Referenced Inventory and create a new record for organization West. Link it to previous Referenced Inventory Type.
Press Box button and select any line with any quantity. Press OK
Now press Unbox button.
Open selector at header level and clean any filter. Verify it only shows bin for West warehouse (OK)
Open selector on any line in grid, clean any filter. Verify it shows all the bins regardless the organization. (WRONG) it should show the same bins as in the header.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036151 closed caristu organization selector in process definition don't filter by role's org access 
related to feature request 00378273.0PR18Q2 closed vmromanos Referenced Inventory 
related to defect 00380613.0PR18Q2 closed alostale Selector filter expression with OB.isSalesTransaction() doesn't work when called from a Process Definition 
related to defect 0038159 closed jarmendariz Possible memory leak in Referenced Inventory Unbox process 
causes defect 0040763 closed AugustoMauch In Payment Out window, Add Details process, the Business Partner is showing customers when it should show vendors 
Attached Filespng processDefinition.png (21,714) 2018-03-05 13:03
https://issues.openbravo.com/file_download.php?file_id=11612&type=bug
png

png header_OK.png (18,668) 2018-03-05 13:03
https://issues.openbravo.com/file_download.php?file_id=11613&type=bug
png

png line_WRONG.png (45,280) 2018-03-05 13:03
https://issues.openbravo.com/file_download.php?file_id=11614&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-03-05 12:57vmromanosNew Issue
2018-03-05 12:57vmromanosAssigned To => platform
2018-03-05 12:57vmromanosModules => Core
2018-03-05 12:57vmromanosTriggers an Emergency Pack => No
2018-03-05 12:57vmromanosRelationship addedrelated to 0036151
2018-03-05 13:03vmromanosFile Added: processDefinition.png
2018-03-05 13:03vmromanosFile Added: header_OK.png
2018-03-05 13:03vmromanosFile Added: line_WRONG.png
2018-03-05 13:25vmromanosRelationship addedrelated to 0037827
2018-03-07 12:36alostaleRelationship addedrelated to 0038061
2018-03-13 16:45jarmendarizAssigned Toplatform => jarmendariz
2018-03-13 16:45jarmendarizStatusnew => scheduled
2018-03-16 10:32hgbotCheckin
2018-03-16 10:32hgbotNote Added: 0103309
2018-03-16 10:32hgbotStatusscheduled => resolved
2018-03-16 10:32hgbotResolutionopen => fixed
2018-03-16 10:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1ed089db27e7036cf53026ca873dbcf104d79bb9 [^]
2018-03-16 10:33jarmendarizReview Assigned To => AugustoMauch
2018-03-16 12:51jarmendarizRelationship addedrelated to 0038159
2018-03-16 17:29hudsonbotCheckin
2018-03-16 17:29hudsonbotNote Added: 0103332
2018-03-27 09:12AugustoMauchNote Added: 0103552
2018-03-27 09:12AugustoMauchStatusresolved => closed
2018-03-27 09:12AugustoMauchFixed in Version => 3.0PR18Q2
2019-05-06 16:09AugustoMauchRelationship addedcauses 0040763

Notes
(0103309)
hgbot   
2018-03-16 10:32   
Repository: erp/devel/pi
Changeset: 1ed089db27e7036cf53026ca873dbcf104d79bb9
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Mar 16 09:22:05 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1ed089db27e7036cf53026ca873dbcf104d79bb9 [^]

Fixed bug 38039: Inconsistent organization filtering in process selectors.

Pick-and-execute grids does not add their standardProperties in the context
info, causing a wrong behavior in selectors not filtering by organization.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0103332)
hudsonbot   
2018-03-16 17:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5323533018b6 [^]
Maturity status: Test
(0103552)
AugustoMauch   
2018-03-27 09:12   
Code reviewed and verified