Openbravo Issue Tracking System - Retail Modules
View Issue Details
0038038Retail ModulesWeb POSpublic2018-03-05 12:352018-06-02 08:47
maite 
ranjith_qualiantech_com 
immediatemajoralways
closedfixed 
5
 
RR18Q2 
marvintm
No
0038038: Wrong payment documents registered in backoffice when giving change in another currency from WebPOS
In case the cashier gives the change in different currency that receipt's currency, credit is generated to the customer (which is wrong)
1. Access POS terminal and create receipt for "Avalanche transceiver" and pay it using "USA cash". Purpose of this step is to have cash in USD
2. Create new receipt setting "Invoice this receipt" for "Insect repellent" pay it using 20 EUR and select "USA Cash" to give the change in USD
3. Access to backoffice to review registered documents and realize that they have some errors:

 a) the sales order document has erroneous Payment Plan info as "received Amount" is higher than "Expected amount" and negative amount appears as "outstanding amount" (when receipt has been fully paid)

 b) from Payment Details tab you can see that 2 payment documents have been created. One is generating credit to anonymous customer, which was not happening before and this credit is not being consumed. Moreover, the second payment (which is deposited in USD financial account) is associated with the sales order (which also seems to be wrong and causing problem a))

 
The payment deposited in USD financial account:
- should not be associated with the sales order
No tags attached.
depends on backport 0038048RR18Q1.1 closed ranjith_qualiantech_com Wrong payment documents registered in backoffice when giving change in another currency from WebPOS 
depends on backport 0038049RR17Q4.2 closed ranjith_qualiantech_com Wrong payment documents registered in backoffice when giving change in another currency from WebPOS 
related to defect 0037264 closed ranjith_qualiantech_com Returning change in a payment method with payment data generates a wrong payment plan 
related to defect 0038333 closed ranjith_qualiantech_com Wrong Payment Details created in backend when paying Layaway with Cash first then overpaying with Digital Coupon 
related to defect 0038544 closed ranjith_qualiantech_com Wrong payment documents registered in backoffice when giving change in another currency from WebPOS 
causes defect 0038466 closed gorka_gil getPaymentAmount() is not being rounded and causes ticket is identified as "hasReceiptChange"=true 
Issue History
2018-03-05 12:35maiteNew Issue
2018-03-05 12:35maiteAssigned To => Retail
2018-03-05 12:35maiteResolution time => 1522015200
2018-03-05 12:35maiteTriggers an Emergency Pack => No
2018-03-05 12:35maiteIssue Monitored: networkb
2018-03-05 13:21maitePriorityurgent => immediate
2018-03-05 13:21maiteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16801#r16801
2018-03-05 13:21maiteProposed Solution updated
2018-03-05 18:35marvintmAssigned ToRetail => gorka_gil
2018-03-05 18:36marvintmStatusnew => scheduled
2018-03-06 14:08ranjith_qualiantech_comAssigned Togorka_gil => ranjith_qualiantech_com
2018-03-09 07:00hgbotCheckin
2018-03-09 07:00hgbotNote Added: 0103108
2018-03-09 07:00hgbotStatusscheduled => resolved
2018-03-09 07:00hgbotResolutionopen => fixed
2018-03-09 07:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4fb9c07eb350e512bafe7547473d226da3b7efa [^]
2018-03-09 07:00hgbotCheckin
2018-03-09 07:00hgbotNote Added: 0103109
2018-03-09 09:30marvintmReview Assigned To => marvintm
2018-03-09 09:30marvintmStatusresolved => closed
2018-03-09 09:30marvintmFixed in Version => RR18Q2
2018-03-14 08:00hgbotCheckin
2018-03-14 08:01hgbotNote Added: 0103226
2018-03-14 09:48hgbotCheckin
2018-03-14 09:48hgbotNote Added: 0103234
2018-03-15 10:30hgbotCheckin
2018-03-15 10:30hgbotNote Added: 0103274
2018-03-22 08:24ranjith_qualiantech_comRelationship addedrelated to 0037264
2018-04-24 08:55ranjith_qualiantech_comRelationship addedrelated to 0038333
2018-04-27 13:54maiteRelationship addedcauses 0038466
2018-05-14 14:01maiteRelationship addedrelated to 0038544
2018-05-17 09:08hgbotCheckin
2018-05-17 09:08hgbotNote Added: 0104552
2018-06-02 08:47hgbotCheckin
2018-06-02 08:47hgbotNote Added: 0104888

Notes
(0103108)
hgbot   
2018-03-09 07:00   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f4fb9c07eb350e512bafe7547473d226da3b7efa
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Mar 09 11:30:22 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4fb9c07eb350e512bafe7547473d226da3b7efa [^]

Fixed issue 38038 : Change Amount should be in negative to create payment schedue and details correclty

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---
(0103109)
hgbot   
2018-03-09 07:00   
Repository: tools/automation/pi-mobile
Changeset: 31300f4bbd89300a4f266d30746902affb5f212f
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Mar 09 11:30:34 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/31300f4bbd89300a4f266d30746902affb5f212f [^]

Verifies issue 38038 : Added automated test 'I38038_VerifyReceiptChangeWithDiffCurrency'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I37343_VerifyPymtScheDetailWithCredit.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I38038_VerifyReceiptChangeWithDiffCurrency.java
---
(0103226)
hgbot   
2018-03-14 08:00   
Repository: tools/automation/pi-mobile
Changeset: 1cf5711387ae044e69560405b0a4cd97db67ab6f
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 14 12:30:17 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1cf5711387ae044e69560405b0a4cd97db67ab6f [^]

Verifies issue 38038 : Modified automated test 'I38038_VerifyReceiptChangeWithDiffCurrency'

* Test failing in quaratine

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I38038_VerifyReceiptChangeWithDiffCurrency.java
---
(0103234)
hgbot   
2018-03-14 09:48   
Repository: tools/automation/pi-mobile
Changeset: 50c0f08c67be694c023843d33329dfb516a547d8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 14 14:18:19 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/50c0f08c67be694c023843d33329dfb516a547d8 [^]

Verifies issue 38038 : Modified automated test 'I38038_VerifyReceiptChangeWithDiffCurrency'

* Test failing in quaratine

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34168_verifyCustomerNameLength.java
---
(0103274)
hgbot   
2018-03-15 10:30   
Repository: tools/automation/pi-mobile
Changeset: 60508b785afcecf28525a471a3255366336a6d40
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 15 15:00:18 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/60508b785afcecf28525a471a3255366336a6d40 [^]

Verifies issue 38038 : Modified automated test 'I38038_VerifyReceiptChangeWithDiffCurrency'

* Test failing in quaratine

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I38038_VerifyReceiptChangeWithDiffCurrency.java
---
(0104552)
hgbot   
2018-05-17 09:08   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4ceef5b8072239a70e813d561ee37ba8751f66e1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 17 12:33:08 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4ceef5b8072239a70e813d561ee37ba8751f66e1 [^]

Related to issue 38544 : Change payment in different currency should be associated with payment details

* Credit should not be generated for Change amount
* Reverted changes for the issue 38038

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---
(0104888)
hgbot   
2018-06-02 08:47   
Repository: retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal
Changeset: a95012cd5ffa57b3cd32533f7076570829c40fcd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Jun 02 12:16:28 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal/rev/a95012cd5ffa57b3cd32533f7076570829c40fcd [^]

Fixed issue 38683 : Change payment in different currency should be associated with payment details

* Credit should not be generated for Change amount
* Reverted changes for the issue 38038

Backed out changeset: f4fb9c07eb35

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---