Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038031Retail ModulesWeb POSpublic2018-03-02 12:302018-03-19 09:22
ReporterSandrahuguet 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038031: OrderLoader load all payment types in handlePayments and is not necessary
DescriptionOrderLoader load all payment types in handlePayments and is not necessary.
Only is necessary load the payment types used in the receipt.
Steps To ReproduceCheck this lines in OrderLoader.handlePayments

      String paymentTypeName = payment.getString("kind");
      for (OBPOSAppPayment type : posTerminal.getOBPOSAppPaymentList()) {
        if (type.getSearchKey().equals(paymentTypeName)) {
          paymentType = type;
          break;
        }
      }
Proposed Solution
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-02 12:30SandrahuguetNew Issue
2018-03-02 12:30SandrahuguetAssigned To => Retail
2018-03-02 12:30SandrahuguetTriggers an Emergency Pack => No
2018-03-02 12:30SandrahuguetTag Attached: Performance
2018-03-02 15:41shuehnerIssue Monitored: shuehner
2018-03-14 09:24SandrahuguetAssigned ToRetail => Sandrahuguet
2018-03-14 09:25SandrahuguetReview Assigned To => marvintm
2018-03-14 09:25hgbotCheckin
2018-03-14 09:25hgbotNote Added: 0103232
2018-03-14 09:25hgbotStatusnew => resolved
2018-03-14 09:25hgbotResolutionopen => fixed
2018-03-14 09:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/24604c9bae32e9c5280f566b45feb8538084a010 [^]
2018-03-15 08:33hgbotCheckin
2018-03-15 08:33hgbotNote Added: 0103266
2018-03-19 09:22marvintmStatusresolved => closed
2018-03-19 09:22marvintmFixed in Version => RR18Q2

Notes
(0103232)
hgbot   
2018-03-14 09:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 24604c9bae32e9c5280f566b45feb8538084a010
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Mar 08 13:47:20 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/24604c9bae32e9c5280f566b45feb8538084a010 [^]

fixed issue 38031 not load all payment types

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0103266)
hgbot   
2018-03-15 08:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c7de1fc6b979f78e3c55ebb3cadc84ee9cb806aa
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Mar 15 08:32:36 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c7de1fc6b979f78e3c55ebb3cadc84ee9cb806aa [^]

related to issue 38031 remove !type.list.empty

remove !type.list.empty in order to avoid unnecessary query

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---