Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038015Openbravo ERP04. Warehouse managementpublic2018-02-28 13:112018-03-02 21:18
Reporterdmiguelez 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038015: Referenced Inventory. Attribute Value not copied correctly when Boxing stock
DescriptionReferenced Inventory. Attribute Value not copied correctly when Boxing stock.

The original Attribute Value is lost
Steps To ReproduceAs F&B Admin

Create a new Referenced Inventory Type without sequence
Create a new Attribute Set With the flags Require At Leas One Value and SerialNo. checked
Create one Product that uses the created Attribute Set
Create another Product without any Attribute Set

Create a Goods Receipt with two lines, one for each Product, with 10 as quantity and an Attribute value for the Product with Attribute Set

Create a Reference Inventory and click on Box
Select the Product without Attribute and set 5 units
Select the Product with Attribute and set 5 units
Set any Storage Bin and click on done

Check in the Contents Tab that the Product with an Attribute has lost the original Attribute Set Value, it only has the value of the box
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00378273.0PR18Q2 closed vmromanos Referenced Inventory 
Attached Filesdiff 38015.diff (7,128) 2018-02-28 13:49
https://issues.openbravo.com/file_download.php?file_id=11606&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-02-28 13:11dmiguelezNew Issue
2018-02-28 13:11dmiguelezAssigned To => Triage Finance
2018-02-28 13:11dmiguelezModules => Core
2018-02-28 13:11dmiguelezTriggers an Emergency Pack => No
2018-02-28 13:12dmiguelezAssigned ToTriage Finance => vmromanos
2018-02-28 13:42vmromanosReproducibilityalways => sometimes
2018-02-28 13:42vmromanosStatusnew => scheduled
2018-02-28 13:49vmromanosFile Added: 38015.diff
2018-02-28 13:49vmromanosRelationship addedrelated to 0037827
2018-03-01 10:30hgbotCheckin
2018-03-01 10:30hgbotNote Added: 0102898
2018-03-01 10:30hgbotStatusscheduled => resolved
2018-03-01 10:30hgbotResolutionopen => fixed
2018-03-01 10:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6340f0b9d91026172740f9bc72b78c833156b836 [^]
2018-03-01 10:40hgbotCheckin
2018-03-01 10:40hgbotNote Added: 0102899
2018-03-01 10:43dmiguelezNote Added: 0102900
2018-03-01 10:43dmiguelezReview Assigned To => dmiguelez
2018-03-01 10:43dmiguelezNote Added: 0102901
2018-03-01 10:43dmiguelezStatusresolved => closed
2018-03-01 10:43dmiguelezFixed in Version => 3.0PR18Q2
2018-03-02 21:18hudsonbotCheckin
2018-03-02 21:18hudsonbotNote Added: 0102959
2018-03-02 21:18hudsonbotCheckin
2018-03-02 21:18hudsonbotNote Added: 0102960

Notes
(0102898)
hgbot   
2018-03-01 10:30   
Repository: erp/devel/pi
Changeset: 6340f0b9d91026172740f9bc72b78c833156b836
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Feb 28 13:48:35 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6340f0b9d91026172740f9bc72b78c833156b836 [^]

Fixed bug 38015: [ri] Attribute Set sometimes is not copied when multiboxing

When calculating the new attribute set instance per storage detail for boxing, the system first tries to recover any previously cloned attribute set instance for this referenced inventory.
It can find it either in the cache created in this boxing execution, or by searching in the database for an existing attribute from a previous boxing activity for the same attribute.
If a previously cloned attribute set instance is not found, it creates a new one.

The existing index has been extended to perform properly in the query to search for an existing cloned attribute set instance.

---
M src-db/database/model/tables/M_ATTRIBUTESETINSTANCE.xml
M src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
---
(0102899)
hgbot   
2018-03-01 10:40   
Repository: erp/devel/pi
Changeset: cfce67ebea69df936e0c2fc88be86c49d97f7340
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Mar 01 10:39:18 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cfce67ebea69df936e0c2fc88be86c49d97f7340 [^]

Related to Issue 38015. Ensure that the new Attribute is always active.

This can happen when cloning the Attribute set instance with id 0,
that can be not active.

---
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
---
(0102900)
dmiguelez   
2018-03-01 10:43   
Test Plan:

As F&B Admin

Create a new Referenced Inventory Type without sequence
Create a new Attribute Set With the flags Require At Leas One Value and SerialNo. checked
Create one Product that uses the created Attribute Set
Create another Product without any Attribute Set

Create a Goods Receipt with two lines, one for each Product, with 10 as quantity and an Attribute value for the Product with Attribute Set

Create a Reference Inventory and click on Box
Select the Product without Attribute and set 5 units
Select the Product with Attribute and set 5 units
Set any Storage Bin and click on done

Check in the Contents Tab that the Product with an Attribute has kept the original Attribute Set Value, it has both the values of the original attribute and the box
(0102901)
dmiguelez   
2018-03-01 10:43   
Code Review + Testing Ok
(0102959)
hudsonbot   
2018-03-02 21:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05dece3dc80b [^]
Maturity status: Test
(0102960)
hudsonbot   
2018-03-02 21:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05dece3dc80b [^]
Maturity status: Test