Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038014Openbravo ERPA. Platformpublic2018-02-28 12:142018-03-08 16:38
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038014: DB connection leak using old pool in test cases
DescriptionUsing old Apache commons jdbc pool, connections are leaked in test cases when using OBBaseTest.getConnectionProvider.
Steps To Reproduce1. Set Openbravo.properties to use old pool (db.externalPoolClassName=)
2. Run ErrorTextParserTest and stop in the last test executed
3. Check DB connections
   -> GOT: 11 idle connections
      EXPECTED: a couple of them
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038097 closed alostale DalConnectionProvider.getTransactionConnection with dbcp pool does not set db config query 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-28 12:14alostaleNew Issue
2018-02-28 12:14alostaleAssigned To => platform
2018-02-28 12:14alostaleModules => Core
2018-02-28 12:14alostaleTriggers an Emergency Pack => No
2018-02-28 13:04alostaleAssigned Toplatform => alostale
2018-02-28 13:04alostaleReview Assigned To => caristu
2018-02-28 13:05hgbotCheckin
2018-02-28 13:05hgbotNote Added: 0102869
2018-02-28 13:05hgbotStatusnew => resolved
2018-02-28 13:05hgbotResolutionopen => fixed
2018-02-28 13:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ed2612a8ff2920a948cfe6d428187968fe5d5706 [^]
2018-03-02 21:18hudsonbotCheckin
2018-03-02 21:18hudsonbotNote Added: 0102958
2018-03-08 16:38caristuNote Added: 0103093
2018-03-08 16:38caristuStatusresolved => closed
2018-03-08 16:38caristuFixed in Version => 3.0PR18Q2
2018-03-09 15:29alostaleRelationship addedrelated to 0038097

Notes
(0102869)
hgbot   
2018-02-28 13:05   
Repository: erp/devel/pi
Changeset: ed2612a8ff2920a948cfe6d428187968fe5d5706
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Feb 28 13:04:42 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ed2612a8ff2920a948cfe6d428187968fe5d5706 [^]

fixed bug 38014: DB connection leak using old pool in test cases

  Reuse DalConnectionProvider instead of creating a new ConnectionProviderImpl
  (new pool) each time OBBaseTest.getConnectionProvider is invoked.

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
---
(0102958)
hudsonbot   
2018-03-02 21:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05dece3dc80b [^]
Maturity status: Test
(0103093)
caristu   
2018-03-08 16:38   
Code reviewed + tested OK.