Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0038004Openbravo ERP07. Sales managementpublic2018-02-21 15:452018-02-27 09:13
maite 
markmm82 
immediatemajoralways
closedfixed 
5
 
3.0PR18Q1.13.0PR18Q1.1 
dmiguelez
Core
https://code.openbravo.com/erp/devel/pi/rev/86dcf5d294d9 [^]
No
0038004: Tax tab info is not correctly recalculated when tax defined as "Line Net Amount + Tax Amount" is modified
When changing the tax in an already created sales invoice line Tax tab is not correctly recalculated (while Line Tax tab is)
1. Access "Tax rate" window and create:
  * one record defined as "Summary level"
  * another record with any rate, Base Amount =Line Net Amount and Parent tax rate= previous summary tax
  * another record with any rate, Base Amount =Line Net Amount + Tax Amount, Base ax= previous one and Parent tax rate= previous summary tax
2. Create Sales Invoice record. Add line, set any product and Tax= summary tax
3. Realize that both "Tax line" tab and "Tax" tab has both children taxes
4. Access Sales Invoice line and change tax to set any other value
5. Access "Line tax" tab and realize that correct tax appears
6. However access "Tax" tab and realize that still one rate belonging to previous tax is there, which is wrong
No tags attached.
blocks defect 0037989 closed markmm82 Tax tab info is not correctly recalculated when tax defined as "Line Net Amount + Tax Amount" is modified 
Issue History
2018-02-27 09:04dmiguelezTypedefect => backport
2018-02-27 09:04dmiguelezTarget Version => 3.0PR18Q1.1
2018-02-27 09:10hgbotCheckin
2018-02-27 09:10hgbotNote Added: 0102839
2018-02-27 09:10hgbotStatusscheduled => resolved
2018-02-27 09:10hgbotResolutionopen => fixed
2018-02-27 09:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/a8771b1c520d0f7b5d0d8063f2971369de5ea6e7 [^]
2018-02-27 09:12dmiguelezReview Assigned To => dmiguelez
2018-02-27 09:12dmiguelezNote Added: 0102841
2018-02-27 09:12dmiguelezStatusresolved => closed
2018-02-27 09:12dmiguelezFixed in Version => 3.0PR18Q2
2018-02-27 09:13dmiguelezFixed in Version3.0PR18Q2 => 3.0PR18Q1.1

Notes
(0102839)
hgbot   
2018-02-27 09:10   
Repository: erp/backports/3.0PR18Q1.1
Changeset: a8771b1c520d0f7b5d0d8063f2971369de5ea6e7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 23 14:32:01 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/a8771b1c520d0f7b5d0d8063f2971369de5ea6e7 [^]

Fixes issue 38004. Order Invoice Tax Lines before deleting.

The order in which the Invoice Tax Lines are deleted can affect
calculations done by the triggers. They must be deleted
in the correct order.

---
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
---
(0102841)
dmiguelez   
2018-02-27 09:12   
Code Review + Testing Ok