Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037990Retail ModulesWeb POSpublic2018-02-21 16:322018-03-08 17:18
Reporterjorgewederago 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037990: Under certain circumstances it is possible to execute runSyncProcess twice.
DescriptionUnder certain circumstances it is possible to execute runSyncProcess twice. In this particular case, if a order was ready to be sync it will be sent twice with different message Id. This will end in one of them en errors while importing with the message "duplicated c_order_id".

There is a log client attached to the issue showing an example of this behavior.
Steps To ReproduceN/A
Proposed SolutionIt should be possible to make runSyncProcess behave in the same way as calculateReceipt. Instead of execute the process again wait until the first one is finished and then execute it again.
Additional Information
TagsNo tags attached.
Relationships
Attached Filescsv DuplicatedCOrderLog.csv (152,742) 2018-02-21 16:32
https://issues.openbravo.com/file_download.php?file_id=11602&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-02-21 16:32jorgewederagoNew Issue
2018-02-21 16:32jorgewederagoAssigned To => Retail
2018-02-21 16:32jorgewederagoFile Added: DuplicatedCOrderLog.csv
2018-02-21 16:32jorgewederagoResolution time => 1520982000
2018-02-21 16:32jorgewederagoTriggers an Emergency Pack => No
2018-02-28 10:19ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-02-28 10:19ranjith_qualiantech_comStatusnew => scheduled
2018-03-01 06:58hgbotCheckin
2018-03-01 06:58hgbotNote Added: 0102888
2018-03-01 06:58hgbotStatusscheduled => resolved
2018-03-01 06:58hgbotResolutionopen => fixed
2018-03-01 06:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/13d42a8cc0ea4d9ef98408468793e7604b12f037 [^]
2018-03-08 17:18jorge-garciaReview Assigned To => jorge-garcia
2018-03-08 17:18jorge-garciaNote Added: 0103102
2018-03-08 17:18jorge-garciaStatusresolved => closed
2018-03-08 17:18jorge-garciaFixed in Version => RR18Q2

Notes
(0102888)
hgbot   
2018-03-01 06:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 13d42a8cc0ea4d9ef98408468793e7604b12f037
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 01 11:28:04 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/13d42a8cc0ea4d9ef98408468793e7604b12f037 [^]

Fixed issue 37990 : Refactored runSyncProcess to avoid multiple execution

* If runSyncProcess is called continuously, callbacks will be added list and runSyncProcess will be called once.
  If syncProcess is completes, it will call all the callbacks from list

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0103102)
jorge-garcia   
2018-03-08 17:18   
Code reviewed and tested