Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0037989Openbravo ERP07. Sales managementpublic2018-02-21 15:452018-03-02 21:18
maite 
markmm82 
immediatemajoralways
closedfixed 
5
 
3.0PR18Q2 
dmiguelez
Core
https://code.openbravo.com/erp/devel/pi/rev/86dcf5d294d9 [^]
No
0037989: Tax tab info is not correctly recalculated when tax defined as "Line Net Amount + Tax Amount" is modified
When changing the tax in an already created sales invoice line Tax tab is not correctly recalculated (while Line Tax tab is)
1. Access "Tax rate" window and create:
  * one record defined as "Summary level"
  * another record with any rate, Base Amount =Line Net Amount and Parent tax rate= previous summary tax
  * another record with any rate, Base Amount =Line Net Amount + Tax Amount, Base ax= previous one and Parent tax rate= previous summary tax
2. Create Sales Invoice record. Add line, set any product and Tax= summary tax
3. Realize that both "Tax line" tab and "Tax" tab has both children taxes
4. Access Sales Invoice line and change tax to set any other value
5. Access "Line tax" tab and realize that correct tax appears
6. However access "Tax" tab and realize that still one rate belonging to previous tax is there, which is wrong
No tags attached.
depends on backport 00380043.0PR18Q1.1 closed markmm82 Tax tab info is not correctly recalculated when tax defined as "Line Net Amount + Tax Amount" is modified 
depends on backport 00380053.0PR17Q4.2 closed markmm82 Tax tab info is not correctly recalculated when tax defined as "Line Net Amount + Tax Amount" is modified 
caused by design defect 0032265 closed aferraz [SER QA 1434] Taxes at document level are not properly calculated in some cases 
related to defect 0038302 closed collazoandy4 Tax tab info is not correctly recalculated when negative child tax defined as "cascade" is modified 
Issue History
2018-02-21 15:45maiteNew Issue
2018-02-21 15:45maiteAssigned To => Triage Finance
2018-02-21 15:45maiteModules => Core
2018-02-21 15:45maiteTriggers an Emergency Pack => No
2018-02-21 15:45maiteIssue Monitored: networkb
2018-02-21 16:30achavesIssue Monitored: achaves
2018-02-21 17:56jfrancesIssue Monitored: jfrances
2018-02-22 11:19maitePriorityurgent => immediate
2018-02-22 12:39dmiguelezAssigned ToTriage Finance => markmm82
2018-02-22 15:26markmm82Statusnew => acknowledged
2018-02-22 19:52markmm82Relationship addedcaused by 0032265
2018-02-22 19:53markmm82Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/86dcf5d294d9 [^]
2018-02-23 17:36markmm82Note Added: 0102828
2018-02-23 17:39markmm82Note Added: 0102829
2018-02-27 09:04dmiguelezStatusacknowledged => scheduled
2018-02-27 09:10hgbotCheckin
2018-02-27 09:10hgbotNote Added: 0102840
2018-02-27 09:10hgbotStatusscheduled => resolved
2018-02-27 09:10hgbotResolutionopen => fixed
2018-02-27 09:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c4a55a7aa3c4800a3c7cf074be7d189c8eee4fbf [^]
2018-02-27 09:13dmiguelezReview Assigned To => dmiguelez
2018-02-27 09:13dmiguelezNote Added: 0102843
2018-02-27 09:13dmiguelezStatusresolved => closed
2018-02-27 09:13dmiguelezFixed in Version => 3.0PR18Q2
2018-03-02 21:18hudsonbotCheckin
2018-03-02 21:18hudsonbotNote Added: 0102952
2018-04-09 18:21aferrazRelationship addedrelated to 0038302

Notes
(0102828)
markmm82   
2018-02-23 17:36   
1. Access "Tax rate" window and create:
  * one record defined as "Summary level"
  * another record with any rate, Base Amount =Line Net Amount and Parent tax rate= previous summary tax
  * another record with any rate, Base Amount =Line Net Amount + Tax Amount, Base ax= previous one and Parent tax rate= previous summary tax
2. Create Sales Invoice record. Add line, set any product and Tax= summary tax
3. Realize that both "Tax line" tab and "Tax" tab has both children taxes
4. Access Sales Invoice line and change tax to set any other value.
5. Access "Line tax" tab and realize that correct tax appears
6. Access "Tax" tab and realize that all rates belonging to previous tax has been deleted and new one has been created related to the line tax.
(0102829)
markmm82   
2018-02-23 17:39   
Executed the TaxesTest test suite and the 800 test cases ran without failures.
(0102840)
hgbot   
2018-02-27 09:10   
Repository: erp/devel/pi
Changeset: c4a55a7aa3c4800a3c7cf074be7d189c8eee4fbf
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 23 14:32:01 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c4a55a7aa3c4800a3c7cf074be7d189c8eee4fbf [^]

Fixes issue 37989. Order Invoice Tax Lines before deleting.

The order in which the Invoice Tax Lines are deleted can affect
calculations done by the triggers. They must be deleted
in the correct order.

---
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
---
(0102843)
dmiguelez   
2018-02-27 09:13   
Code Review + Testing Ok
(0102952)
hudsonbot   
2018-03-02 21:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05dece3dc80b [^]
Maturity status: Test