Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0037963 | Openbravo ERP | 07. Sales management | public | 2018-02-16 15:02 | 2018-03-07 01:04 |
|
Reporter | ngarcia | |
Assigned To | markmm82 | |
Priority | urgent | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | 3.0PR18Q2 | |
Merge Request Status | |
Review Assigned To | dmiguelez |
OBNetwork customer | |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0037963: Payment in Awaiting payment status is created when an invoice cannot be voided because document cancelled is a return |
Description | Payment in Awaiting payment status is created when an invoice cannot be voided because document cancelled is a return and original invoice has a line with negative quantity |
Steps To Reproduce | As group admin role:
Go to Document Type window and check the 'Reversed Sales Invoice' document type is set as Return (do not allow positive lines) and it is set as Document Cancelled for 'AR Invoice' document type
Create a Sales Invoice
Add two lines to it, one with positive quantity and one with negative quantity and lower amount
Complete it
Try to void it and check the following error message is shown:
"Return Invoices do not allow lines with positive quantities."
Check in Payment Plan - Payment Details tab that a new payment has been created for the invoice
Go to Document Type window and remove the Return option to 'Reversed Sales Invoice' document type
Try to void the invoice and check the following error message is shown now:
"Invoice can not be voided as there is an awaiting execution payment related. Please either execute that payment or cancel it" |
Proposed Solution | |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | defect | 0034589 | | closed | rqueralta | Error message needed in case of voiding an invoice having an "Awaiting Execution" or "Awaiting Payment" payment related. | has duplicate | defect | 0036420 | | closed | Triage Omni OMS | Void process create a new payment for not paid invoice if c_invoice_post process fail |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2018-02-16 15:02 | ngarcia | New Issue | |
2018-02-16 15:02 | ngarcia | Assigned To | => Triage Finance |
2018-02-16 15:02 | ngarcia | Modules | => Core |
2018-02-16 15:02 | ngarcia | Triggers an Emergency Pack | => No |
2018-02-16 15:02 | ngarcia | Issue Monitored: networkb | |
2018-02-16 15:02 | ngarcia | Relationship added | related to 0034589 |
2018-02-19 11:37 | ngarcia | Resolution time | => 1520550000 |
2018-03-02 14:07 | dmiguelez | Assigned To | Triage Finance => markmm82 |
2018-03-02 17:54 | markmm82 | Status | new => scheduled |
2018-03-05 18:33 | markmm82 | Note Added: 0102996 | |
2018-03-05 20:59 | markmm82 | Note Edited: 0102996 | bug_revision_view_page.php?bugnote_id=0102996#r16809 |
2018-03-06 11:30 | hgbot | Checkin | |
2018-03-06 11:30 | hgbot | Note Added: 0103020 | |
2018-03-06 11:30 | hgbot | Status | scheduled => resolved |
2018-03-06 11:30 | hgbot | Resolution | open => fixed |
2018-03-06 11:30 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/6fa4003bddbe8e121d349a60439a28599d22fc91 [^] |
2018-03-06 11:32 | dmiguelez | Review Assigned To | => dmiguelez |
2018-03-06 11:32 | dmiguelez | Note Added: 0103021 | |
2018-03-06 11:32 | dmiguelez | Status | resolved => closed |
2018-03-06 11:32 | dmiguelez | Fixed in Version | => 3.0PR18Q2 |
2018-03-07 01:04 | hudsonbot | Checkin | |
2018-03-07 01:04 | hudsonbot | Note Added: 0103049 | |
2018-04-18 10:00 | ngarcia | Relationship added | has duplicate 0036420 |
Notes |
|
(0102996)
|
markmm82
|
2018-03-05 18:33
(edited on: 2018-03-05 20:59) |
|
Test Plan 1:
As group admin role:
Go to Document Type window and check the 'Reversed Sales Invoice' document type is set as Return (do not allow positive lines)
Set it as Document Cancelled for 'AR Invoice' document type
Create a Sales Invoice
Add two lines to it, one with positive quantity and one with negative and lower quantity
1st Line: Product = Cerveza Ale 0,5L, Quantity = 10
2nd Line: Product = Cerveza LAger 0,5L, Quantity = -5
Complete it
Notice there is a Payment Plan created for the invoice.
Go to Payment Details tab and notice there aren't any record.
Try to void it and check the following error message is shown:
"Return Invoices do not allow lines with positive quantities."
Check in Payment Plan - Payment Details tab that still without any record created for the invoice
Go to Document Type window and remove the Return option to 'Reversed Sales Invoice' document type
Try to void the invoice and check the process is completed successfully and a new reversed document has been created reversing the original one.
Test cases related to issue 34589
Test Plan 2 - voice partially paid by an automatic payment method (Remittance) and void. First Payment not executed.
Go to Sales Invoice and create a new invoice for F&B España, Alimentos business partner. Select Remittance payment method. Complete the invoice.
Partially paid the invoice.
Verify that a payment in is created with status "Awaiting Execution".
Do not execute the payment created.
Void the invoice.
Notice an error message is shown:
Error:
Invoice can not be voided as there is an awaiting execution payment related. Please either execute that payment or cancel it
Repeat same test case for a purchase invoice.
Test Plan 3 - Invoice partially paid by an automatic payment method (Check) and void. First Payment executed.
Create a Sales Invoice for F&B España, Alimentos business partner.
Change payment method to an automatic payment method such as "Print Check Simple process" or "Remittance", set up as "Deferred" = Yes.
Add any line to the invoice. Complete and Post the invoice.
Partially pay the invoice and do NOT execute that payment, therefore payment created is in status "Awaiting Execution".
Go to the payment and press the button Reactivate. Choose "Reactivate" action, therefore payment status is "Awaiting Payment".
Try to void the invoice.
Notice an error message is shown:
Invoice can not be voided as there is an awaiting execution payment related. Please either execute that payment or cancel it
|
|
|
(0103020)
|
hgbot
|
2018-03-06 11:30
|
|
Repository: erp/devel/pi
Changeset: 6fa4003bddbe8e121d349a60439a28599d22fc91
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Mar 05 12:10:20 2018 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/6fa4003bddbe8e121d349a60439a28599d22fc91 [^]
Fixes issue 37963: Payment in Awaiting payment status is created when an invoice
cannot be voided because document cancelled is a return
A commit and close was performed at the end of the invoice processing to get the
error message from the database, but it left all previously created data into the
database just like the dummy payment when it is needed is to rollback the changes.
If at the end of processing there is some error then a rollback is performed.
Also the message is created from the pinstance object instead of retrieve the Instance
data from the database.
---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
|
|
|
|
|
|
|
|