Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037942Openbravo ERPA. Platformpublic2018-02-15 18:452018-06-12 11:32
Reportercaristu 
Assigned Tojarmendariz 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037942: JDK 9: remove [dep-ann] warnings by removing deprecated elements
DescriptionWhen building Openbravo with JDK 9, several [dep-ann] warnings appears:

warning: [dep-ann] deprecated item is not annotated with @Deprecated

Some of this warnings can be removed by deleting the deprecated elements because it does not make sense to keep them as part of the API. It must be reviewed in deep which elements can be deleted.

See complete list: https://docs.google.com/spreadsheets/d/1OsTLaQIb8HUUL7vXiP9O9HMz4N0BLTWEKq4Qoyt_gEI/edit#gid=0 [^]
Steps To Reproduce1. Build Openbravo with Java 9
  -> Check warnings
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0037083 closed alostale Openbravo ERP support JDK 9 
related to defect 0038055 closed jarmendariz Openbravo ERP API Change: Remove deprecated constants/methods 
related to defect 0038091 closed jarmendariz Retail Modules JDK 9: Remove [dep-ann] warnings removing deprecated elements 
related to defect 0038265 closed AugustoMauch Retail Modules JDK 9: remove [dep-ann] warnings by removing deprecated elements in store server modules 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-15 18:45caristuNew Issue
2018-02-15 18:45caristuAssigned To => platform
2018-02-15 18:45caristuModules => Core
2018-02-15 18:45caristuTriggers an Emergency Pack => No
2018-02-15 18:45caristuIssue generated from0037941
2018-02-15 18:45caristuRelationship addedrelated to 0037083
2018-02-15 18:46caristuSummaryJDK: remove [dep-ann] warnings by deleting the deprecated elements => JDK: remove [dep-ann] warnings by removing deprecated elements
2018-02-15 18:55caristuIssue cloned0037943
2018-02-15 19:10caristuAssigned Toplatform => jarmendariz
2018-02-16 09:19caristuSummaryJDK: remove [dep-ann] warnings by removing deprecated elements => JDK 9: remove [dep-ann] warnings by removing deprecated elements
2018-02-21 12:32jarmendarizStatusnew => scheduled
2018-03-06 13:16jarmendarizRelationship addedrelated to 0038055
2018-03-09 11:19hgbotCheckin
2018-03-09 11:19hgbotNote Added: 0103124
2018-03-09 11:19hgbotStatusscheduled => resolved
2018-03-09 11:19hgbotResolutionopen => fixed
2018-03-09 11:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/60a2a309d225e87c9a56d7e897a407c0a83d6980 [^]
2018-03-09 11:20hgbotCheckin
2018-03-09 11:20hgbotNote Added: 0103125
2018-03-12 16:26caristuReview Assigned To => caristu
2018-03-12 19:17hgbotCheckin
2018-03-12 19:17hgbotNote Added: 0103166
2018-03-12 19:26caristuDescription Updatedbug_revision_view_page.php?rev_id=16830#r16830
2018-03-12 19:27caristuNote Added: 0103168
2018-03-12 19:27caristuStatusresolved => closed
2018-03-12 19:27caristuFixed in Version => 3.0PR18Q2
2018-03-13 16:30caristuRelationship addedrelated to 0038091
2018-03-13 17:22hudsonbotCheckin
2018-03-13 17:22hudsonbotNote Added: 0103206
2018-03-13 17:22hudsonbotCheckin
2018-03-13 17:23hudsonbotNote Added: 0103207
2018-03-13 17:24hudsonbotCheckin
2018-03-13 17:24hudsonbotNote Added: 0103214
2018-04-04 10:34AugustoMauchRelationship addedrelated to 0038265
2018-06-12 11:32caristuIssue cloned0038737

Notes
(0103124)
hgbot   
2018-03-09 11:19   
Repository: erp/devel/pi
Changeset: 60a2a309d225e87c9a56d7e897a407c0a83d6980
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Mar 09 08:56:45 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/60a2a309d225e87c9a56d7e897a407c0a83d6980 [^]

Fixed issue 37942: Removed deprecated code and removing all dep-ann warnings

Instead of adding the @Deprecated annotation, removed since its deprecated
for a long time and not used anywhere in the project.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/MenuManager.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelConstants.java
M src-test/src/org/openbravo/test/xml/ClientExportImportTest.java
M src/org/openbravo/base/model/ModelProvider.java
M src/org/openbravo/base/model/RefList.java
M src/org/openbravo/base/model/Reference.java
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/dal/xml/ModelXMLConverter.java
M src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java
M src/org/openbravo/erpCommon/modules/ImportModule.java
M src/org/openbravo/erpCommon/modules/ImportModule_data.xsql
M src/org/openbravo/erpCommon/modules/VersionUtility.java
M src/org/openbravo/erpCommon/obps/ActivationKey.java
M src/org/openbravo/erpCommon/security/SessionLogin.java
M src/org/openbravo/erpCommon/utility/HttpsUtils.java
M src/org/openbravo/erpCommon/utility/SequenceIdData.java
M src/org/openbravo/service/system/SystemService.java
---
(0103125)
hgbot   
2018-03-09 11:20   
Repository: erp/devel/pi
Changeset: d3c8c0cf8e16b9a9b31cfa312afc7ef244719455
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Mar 09 08:57:30 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d3c8c0cf8e16b9a9b31cfa312afc7ef244719455 [^]

Related to issue 37942: Removed deprecated code and removing dep-ann warnings

Marking code that cannot be removed with the @Deprecated annotation. These
methods are being used in modules in the Forge.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelConstants.java
M src/org/openbravo/scheduling/ProcessBundle.java
---
(0103166)
hgbot   
2018-03-12 19:17   
Repository: erp/devel/pi
Changeset: ee9c18c5933d147ad27c2ea0d6859da3c66579d9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Mar 12 19:16:54 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ee9c18c5933d147ad27c2ea0d6859da3c66579d9 [^]

related to issue 37942: additional cleanup

---
M src/org/openbravo/erpCommon/utility/HttpsUtils.java
---
(0103168)
caristu   
2018-03-12 19:27   
Reviewed + tested OK.
(0103206)
hudsonbot   
2018-03-13 17:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1d3ccc92fab6 [^]
Maturity status: Test
(0103207)
hudsonbot   
2018-03-13 17:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1d3ccc92fab6 [^]
Maturity status: Test
(0103214)
hudsonbot   
2018-03-13 17:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1d3ccc92fab6 [^]
Maturity status: Test