Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0037941Openbravo ERPA. Platformpublic2018-02-15 18:432018-02-22 18:19
caristu 
shuehner 
highminorhave not tried
closedfixed 
5
 
 
caristu
Core
No
0037941: JDK 9: remove [dep-ann] warnings by adding the missing @Deprecated annotation (platform code)
When building Openbravo with JDK 9, several [dep-ann] warnings appears:

warning: [dep-ann] deprecated item is not annotated with @Deprecated

Some of this warnings can be removed just by using the missing @Deprecated because it still makes sense to keep them as part of the API.
1. Build Openbravo with Java 9
  -> Check warnings
No tags attached.
related to feature request 0037083 closed alostale support JDK 9 
Issue History
2018-02-15 18:43caristuNew Issue
2018-02-15 18:43caristuAssigned To => platform
2018-02-15 18:43caristuModules => Core
2018-02-15 18:43caristuTriggers an Emergency Pack => No
2018-02-15 18:43caristuRelationship addedrelated to 0037083
2018-02-15 18:45caristuIssue cloned0037942
2018-02-15 18:46caristuSummaryJDK: remove [dep-ann] warnings => JDK: remove [dep-ann] warnings y adding the missing @Deprecated annotation
2018-02-15 18:56caristuSummaryJDK: remove [dep-ann] warnings y adding the missing @Deprecated annotation => JDK: remove [dep-ann] warnings by adding the missing @Deprecated annotation
2018-02-16 09:14caristuAssigned Toplatform => shuehner
2018-02-16 09:15hgbotCheckin
2018-02-16 09:15hgbotNote Added: 0102455
2018-02-16 09:15hgbotStatusnew => resolved
2018-02-16 09:15hgbotResolutionopen => fixed
2018-02-16 09:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e175a39a03a5d7afaae951cfbeaaa182bb20a81f [^]
2018-02-16 09:15caristuNote Edited: 0102455bug_revision_view_page.php?bugnote_id=0102455#r16723
2018-02-16 09:18caristuSummaryJDK: remove [dep-ann] warnings by adding the missing @Deprecated annotation => JDK 9: remove [dep-ann] warnings by adding the missing @Deprecated annotation
2018-02-16 09:18caristuReview Assigned To => caristu
2018-02-16 09:18caristuNote Added: 0102456
2018-02-16 09:18caristuStatusresolved => closed
2018-02-16 12:14shuehnerSummaryJDK 9: remove [dep-ann] warnings by adding the missing @Deprecated annotation => JDK 9: remove [dep-ann] warnings by adding the missing @Deprecated annotation (platform code)
2018-02-16 12:15shuehnerIssue cloned0037959
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102772

Notes
(0102455)
hgbot   
2018-02-16 09:15   
Repository: erp/devel/pi
Changeset: e175a39a03a5d7afaae951cfbeaaa182bb20a81f
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Feb 16 09:03:06 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e175a39a03a5d7afaae951cfbeaaa182bb20a81f [^]

fixes bug 37941: remove [dep-ann] warnings by adding the @Deprecated annotation

  Added missing @Deprecated annotation in:

  - BaseProcessActionHandler.fixRequestMap: as method is still referenced in other modules.
  - HttpSessionWrapper: implementing HttpSession interface, so need to keep the deprecated methods. Removed autogenerated TODO comments also.
  - BaseTest: the whole class is deprecated but still used in other modules (src-test).
  - DalUtil.getId: recently deprecated, for the moment it is safer to add the annotation and keep it.
  - Utility.getTabURL + getTransplatedJasperReport: both used in several modules still.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
M src-core/src/org/openbravo/base/HttpSessionWrapper.java
M src-core/src/org/openbravo/database/SessionInfo.java
M src-test/src/org/openbravo/test/base/BaseTest.java
M src/org/openbravo/dal/core/DalUtil.java
M src/org/openbravo/erpCommon/utility/Utility.java
---

(0102456)
caristu   
2018-02-16 09:18   
Code reviewed
(0102772)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test