Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037940Openbravo ERPA. Platformpublic2018-02-15 18:072019-03-28 14:55
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037940: Clean up unused shortcuts in the Login page
DescriptionAs part of the login page clean up[1], the JS code required for the Login page was moved to a separate file (login.js).

It currently contains the definition of several shortcut actions which does not make sense in the context of the login page. They should be cleaned up.
Steps To ReproduceIn description
Proposed SolutionAttached the list of shortcuts being added. Most of them are related with the 2.50 menu, windows and tabs.

Remove all shortcuts except those related with TAB and ENTER keys.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0035386 closed caristu Login page needs some clean up 
Attached Filestxt listOfShortcuts.txt (5,249) 2019-01-16 12:15
https://issues.openbravo.com/file_download.php?file_id=12510&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-02-15 18:07caristuNew Issue
2018-02-15 18:07caristuAssigned To => caristu
2018-02-15 18:07caristuOBNetwork customer => No
2018-02-15 18:07caristuModules => Core
2018-02-15 18:07caristuTriggers an Emergency Pack => No
2018-02-15 18:07caristuRelationship addedrelated to 0035386
2018-06-15 11:28alostaleStatusnew => acknowledged
2019-01-16 11:09hgbotCheckin
2019-01-16 11:09hgbotNote Added: 0108976
2019-01-16 12:15caristuProposed Solution updated
2019-01-16 12:15caristuFile Added: listOfShortcuts.txt
2019-01-16 13:24caristuProposed Solution updated
2019-01-16 13:38hgbotCheckin
2019-01-16 13:38hgbotNote Added: 0108980
2019-01-16 13:38hgbotStatusacknowledged => resolved
2019-01-16 13:38hgbotResolutionopen => fixed
2019-01-16 13:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7f68f19b9b80df16a3cd04282c1efb4bf66da4ab [^]
2019-01-16 13:38caristuReview Assigned To => alostale
2019-01-18 09:57hgbotCheckin
2019-01-18 09:57hgbotNote Added: 0109009
2019-01-18 09:58alostaleNote Added: 0109010
2019-01-18 09:58alostaleStatusresolved => closed
2019-01-18 09:58alostaleFixed in Version => 3.0PR19Q2
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110731
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110733
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110736

Notes
(0108976)
hgbot   
2019-01-16 11:09   
Repository: erp/devel/pi
Changeset: 88d362c8aba045a766388c940dd460444d759272
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Jan 16 11:06:26 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/88d362c8aba045a766388c940dd460444d759272 [^]

related to issue 37940: minor code cleanup

  - Removed unused variables
  - Declared "obj" variables on top of the function
  - Remove unreachable "return false"

---
M web/js/login.js
---
(0108980)
hgbot   
2019-01-16 13:38   
Repository: erp/devel/pi
Changeset: 7f68f19b9b80df16a3cd04282c1efb4bf66da4ab
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Jan 16 13:32:57 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7f68f19b9b80df16a3cd04282c1efb4bf66da4ab [^]

fixes issue 37940: Clean up unused shortcuts in the Login page

---
M src/org/openbravo/erpCommon/security/Login.html
M web/js/login.js
M web/js/utils.js
---
(0109009)
hgbot   
2019-01-18 09:57   
Repository: erp/devel/pi
Changeset: 123e2c24a1b1170c10520e44622b6127eef1a1bf
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jan 18 09:56:54 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/123e2c24a1b1170c10520e44622b6127eef1a1bf [^]

related to issue 37940: remove some clutter on array creation

---
M web/js/login.js
---
(0109010)
alostale   
2019-01-18 09:58   
reviewed + tested
(0110731)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110733)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110736)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test