Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037918Openbravo ERPA. Platformpublic2018-02-13 17:192018-02-15 09:35
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q4.1Fixed in Version3.0PR17Q4.1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037918: Internal CSS are included in AD_TextInterface as translatable content
DescriptionHtml pages can embed some CSS in <style> tags, though it will be included in AD_TextInterfaces after running ant export.database, which is not desiderable.
Steps To Reproduce1) Apply the attached patch (cssCreatesTextInterface.diff)
2) Run "ant compile.complete"

At the end of the output of this command you can see the following line, indicating that the styles are recognized as translatable content:

[java] 1917 [main] INFO org.openbravo.translate.Translate - New label found [body {background-color: green;} h1 {color: red;} p {color: blue;}] in /org/openbravo/erpCommon/security/Login.html
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037907 closed jarmendariz Internal CSS are included in AD_TextInterface as translatable content 
Attached Filesdiff cssCreatesTextInterface.diff (574) 2018-02-15 09:20
https://issues.openbravo.com/file_download.php?file_id=11580&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-02-14 18:10jarmendarizTypedefect => backport
2018-02-14 18:10jarmendarizTarget Version => 3.0PR17Q4.1
2018-02-14 18:36hgbotCheckin
2018-02-14 18:36hgbotNote Added: 0102415
2018-02-14 18:36hgbotStatusscheduled => resolved
2018-02-14 18:36hgbotResolutionopen => fixed
2018-02-14 18:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/6f6bd229fc5efea73f95901c45beb8d8a29dd299 [^]
2018-02-14 18:37jarmendarizAssigned Toplatform => jarmendariz
2018-02-14 18:37jarmendarizReview Assigned To => caristu
2018-02-15 09:20caristuFile Added: cssCreatesTextInterface.diff
2018-02-15 09:35hgbotCheckin
2018-02-15 09:35hgbotNote Added: 0102426
2018-02-15 09:35caristuNote Added: 0102427
2018-02-15 09:35caristuStatusresolved => closed
2018-02-15 09:35caristuFixed in Version => 3.0PR17Q4.1

Notes
(0102415)
hgbot   
2018-02-14 18:36   
Repository: erp/backports/3.0PR17Q4.1
Changeset: 6f6bd229fc5efea73f95901c45beb8d8a29dd299
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Feb 14 18:34:52 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/6f6bd229fc5efea73f95901c45beb8d8a29dd299 [^]

Fixed bug 37918: Internal CSS are included in AD_TextInterfaces

Adding <style> tags along <script> as tags excluded from being parsed for the Translate class.

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0102426)
hgbot   
2018-02-15 09:35   
Repository: erp/backports/3.0PR17Q4.1
Changeset: 3420f8221073ce09654c86f48f322b04dfa5fa57
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Feb 15 09:34:49 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/3420f8221073ce09654c86f48f322b04dfa5fa57 [^]

related to issue 37918: updated copyright year

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0102427)
caristu   
2018-02-15 09:35   
Code reviewed + tested OK.