Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037917Openbravo ERPA. Platformpublic2018-02-13 17:192018-03-12 13:15
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q1.1Fixed in Version3.0PR18Q1.1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037917: Internal CSS are included in AD_TextInterface as translatable content
DescriptionHtml pages can embed some CSS in <style> tags, though it will be included in AD_TextInterfaces after running ant export.database, which is not desiderable.
Steps To Reproduce1) Apply the attached patch (cssCreatesTextInterface.diff)
2) Run "ant compile.complete"

At the end of the output of this command you can see the following line, indicating that the styles are recognized as translatable content:

[java] 1917 [main] INFO org.openbravo.translate.Translate - New label found [body {background-color: green;} h1 {color: red;} p {color: blue;}] in /org/openbravo/erpCommon/security/Login.html
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037907 closed jarmendariz Internal CSS are included in AD_TextInterface as translatable content 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-14 18:10jarmendarizTypedefect => backport
2018-02-14 18:10jarmendarizTarget Version => 3.0PR18Q1
2018-02-20 12:42alostaleTarget Version3.0PR18Q1 => 3.0PR18Q1.1
2018-03-06 11:07hgbotCheckin
2018-03-06 11:07hgbotNote Added: 0103018
2018-03-06 11:07hgbotStatusscheduled => resolved
2018-03-06 11:07hgbotResolutionopen => fixed
2018-03-06 11:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/d9ca99578b537508768a60f42667bf34fc4a6f48 [^]
2018-03-09 16:27caristuReview Assigned To => caristu
2018-03-12 13:15caristuNote Added: 0103156
2018-03-12 13:15caristuStatusresolved => closed
2018-03-12 13:15caristuFixed in Version => 3.0PR18Q1.1
2018-03-12 13:15caristuAssigned Toplatform => jarmendariz

Notes
(0103018)
hgbot   
2018-03-06 11:07   
Repository: erp/backports/3.0PR18Q1.1
Changeset: d9ca99578b537508768a60f42667bf34fc4a6f48
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Mar 02 12:39:36 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/d9ca99578b537508768a60f42667bf34fc4a6f48 [^]

Fixed issue 37917: Internal CSS are included in AD_TextInterfaces

Adding <style> tags along <script> as tags excluded from being parsed for the Translate class.

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0103156)
caristu   
2018-03-12 13:15   
Code reviewed + tested OK.