Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037909Retail ModulesStoreServerpublic2018-02-13 22:052018-03-14 15:38
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037909: In store server: ServerStateBackGround process should not trigger to go offline
DescriptionThe ServerStateBackground process [1] is run both in central as well in the store server. In the store server when it detects that no timestamp update was received from the central server for a certain time the process will trigger a transition to offline.

The idea is to not let the process do this. This because transition to offline is only needed during business/opening hours and in that case it should only be triggered by user actions not behind the scenes.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java#l99 [^]
Steps To ReproduceInstall multi-server with server state background process enabled on store and central
Stop central
After 15 mins the store will transition to offline
Proposed SolutionRemove the code that does the transition to offline. Keep the transition to online code.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 37909.diff (1,848) 2018-02-14 10:52
https://issues.openbravo.com/file_download.php?file_id=11575&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-02-13 22:05mtaalNew Issue
2018-02-13 22:05mtaalAssigned To => mtaal
2018-02-13 22:05mtaalOBNetwork customer => No
2018-02-13 22:05mtaalTriggers an Emergency Pack => No
2018-02-14 10:52mtaalFile Added: 37909.diff
2018-02-14 21:05hgbotCheckin
2018-02-14 21:05hgbotNote Added: 0102419
2018-02-14 21:05hgbotStatusnew => resolved
2018-02-14 21:05hgbotResolutionopen => fixed
2018-02-14 21:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a6d5be7a45b55c008bcb7b1f00bc8a31cc1493c8 [^]
2018-03-13 23:14mtaalAssigned Tomtaal =>
2018-03-13 23:15mtaalReview Assigned To => AugustoMauch
2018-03-13 23:35mtaalAssigned To => mtaal
2018-03-14 12:25hgbotCheckin
2018-03-14 12:25hgbotNote Added: 0103239
2018-03-14 15:38AugustoMauchNote Added: 0103243
2018-03-14 15:38AugustoMauchStatusresolved => closed
2018-03-14 15:38AugustoMauchFixed in Version => RR18Q2

Notes
(0102419)
hgbot   
2018-02-14 21:05   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a6d5be7a45b55c008bcb7b1f00bc8a31cc1493c8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Feb 14 21:05:07 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a6d5be7a45b55c008bcb7b1f00bc8a31cc1493c8 [^]

Fixes issue 37909: In store server: ServerStateBackGround process should not trigger to go offline
Prevent going offline, still log it

---
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
(0103239)
hgbot   
2018-03-14 12:25   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7623d25c0a3db38e3730363b7d53be2c32ea0714
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Mar 14 12:24:34 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7623d25c0a3db38e3730363b7d53be2c32ea0714 [^]

Related with issue 37909: Enables going offline if no pings are received

By default if the store server stops receiving pings from the centarl server, it will not go offline until there is a
user action that results in a request to the central server.

This changeset adds the OBMOBC_Offline_Triggered_Only_By_User_Actions preference. If set to N, the store server will go
offline when it stops receiving pings from the central server. This preference will be used in the store server automated
testing jobs, where it is expected that the store server will go automatically offline some time after the central server
has been stopped.

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
(0103243)
AugustoMauch   
2018-03-14 15:38   
Code reviewed and verified