Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037907Openbravo ERPA. Platformpublic2018-02-13 17:192018-03-05 18:25
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037907: Internal CSS are included in AD_TextInterface as translatable content
DescriptionHtml pages can embed some CSS in <style> tags, though it will be included in AD_TextInterfaces after running ant export.database, which is not desiderable.
Steps To Reproduce1) Apply the attached patch (cssCreatesTextInterface.diff)
2) Run "ant compile.complete"

At the end of the output of this command you can see the following line, indicating that the styles are recognized as translatable content:

[java] 1917 [main] INFO org.openbravo.translate.Translate - New label found [body {background-color: green;} h1 {color: red;} p {color: blue;}] in /org/openbravo/erpCommon/security/Login.html
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00379173.0PR18Q1.1 closed jarmendariz Openbravo ERP Internal CSS are included in AD_TextInterface as translatable content 
depends on backport 00379183.0PR17Q4.1 closed jarmendariz Openbravo ERP Internal CSS are included in AD_TextInterface as translatable content 
related to defect 0037916 closed jarmendariz Modules Remove wrong AD_TextInterface entry 
blocks design defect 0037740 closed jarmendariz Openbravo ERP support custom error pages 
Attached Filesdiff cssCreatesTextInterface.diff (574) 2018-02-13 17:19
https://issues.openbravo.com/file_download.php?file_id=11573&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-02-13 17:19jarmendarizNew Issue
2018-02-13 17:19jarmendarizAssigned To => platform
2018-02-13 17:19jarmendarizFile Added: cssCreatesTextInterface.diff
2018-02-13 17:19jarmendarizModules => Core
2018-02-13 17:19jarmendarizTriggers an Emergency Pack => No
2018-02-14 09:25caristuRelationship addedblocks 0037740
2018-02-14 10:17caristuRelationship deletedblocks 0037740
2018-02-14 10:17caristuRelationship addedrelated to 0037740
2018-02-14 13:49jarmendarizRelationship replacedblocks 0037740
2018-02-14 17:51jarmendarizRelationship addedrelated to 0037916
2018-02-14 18:10jarmendarizStatusnew => scheduled
2018-02-14 18:30hgbotCheckin
2018-02-14 18:30hgbotNote Added: 0102413
2018-02-14 18:30hgbotStatusscheduled => resolved
2018-02-14 18:30hgbotResolutionopen => fixed
2018-02-14 18:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0f39f1cd72c172607771dcefe7f3d4d6a6ca699a [^]
2018-02-14 18:37jarmendarizAssigned Toplatform => jarmendariz
2018-02-14 18:37jarmendarizReview Assigned To => caristu
2018-02-15 08:50hgbotCheckin
2018-02-15 08:50hgbotNote Added: 0102422
2018-02-15 08:51caristuNote Added: 0102423
2018-02-15 08:51caristuStatusresolved => closed
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102760
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102763
2018-03-05 18:25caristuFixed in Version => 3.0PR18Q2

Notes
(0102413)
hgbot   
2018-02-14 18:30   
Repository: erp/devel/pi
Changeset: 0f39f1cd72c172607771dcefe7f3d4d6a6ca699a
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Feb 14 18:29:26 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0f39f1cd72c172607771dcefe7f3d4d6a6ca699a [^]

Fixed bug 37907: Internal CSS are included in AD_TextInterfaces

Adding <style> tags along <script> as tags excluded from being parsed for the Translate class.

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0102422)
hgbot   
2018-02-15 08:50   
Repository: erp/devel/pi
Changeset: 2c6c3bf5a19ed7137d7e51ad97b1a4eafa6b8959
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Feb 15 08:50:37 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2c6c3bf5a19ed7137d7e51ad97b1a4eafa6b8959 [^]

related to issue 37907: updated copyright year

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0102423)
caristu   
2018-02-15 08:51   
Code reviewed + tested OK.
(0102760)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102763)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test