Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037881Openbravo ERP09. Financial managementpublic2018-02-11 13:232018-04-11 17:05
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037881: Remove report "Promissory Note" based on old fop technology and only use for old pre-aprm flow in deactivated window.
DescriptionThe report "Promissory Note" is used for print button in 3 tabs:
- Sales Invoice, tab "Payment"
- Purchase Invoice, tab "Payment"
Both above are deactivated tabs.
- Settlement, tab "Created Payments"
For this one the whole window is not active by default.

The report uses the old fop rendering technology planned to be removed eventually.

Apart is prints data from old pre-aprm system using table c_debt_payment.
APRM is mandatory since start of 3.0
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038320 closed shuehner Openbravo ERP API-Change for removal of 4 obsolete fop-related reports (RptM_Inout, RptM_Movement, RptC_Settlement, PromissoryNote) 
related to defect 0038321 closed shuehner Retail Modules Retail issue to update all 3 retail sampledata's in relation to 4 ad_process deletions in pi. 
blocks feature request 0037874 closed alostale Openbravo ERP Remove support for fop rendering from core product as very nearly not used 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-11 13:23shuehnerNew Issue
2018-02-11 13:23shuehnerAssigned To => shuehner
2018-02-11 13:23shuehnerModules => Core
2018-02-11 13:23shuehnerTriggers an Emergency Pack => No
2018-02-11 13:25shuehnerNote Added: 0102310
2018-02-11 13:28shuehnerNote Added: 0102311
2018-02-11 14:16shuehnerRelationship addedblocks 0037874
2018-04-10 21:00shuehnerRelationship addedrelated to 0038320
2018-04-10 21:04shuehnerRelationship addedrelated to 0038321
2018-04-10 21:13hgbotCheckin
2018-04-10 21:13hgbotNote Added: 0103794
2018-04-10 21:13hgbotStatusnew => resolved
2018-04-10 21:13hgbotResolutionopen => fixed
2018-04-10 21:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ef587ec4fac7a7f972d366e049d48ee2c58b92b6 [^]
2018-04-10 21:18shuehnerReview Assigned To => vmromanos
2018-04-11 17:05vmromanosNote Added: 0103825
2018-04-11 17:05vmromanosStatusresolved => closed
2018-04-11 17:05vmromanosFixed in Version => 3.0PR18Q3
2018-12-24 13:42alostaleRelationship addedblocks 0039848

Notes
(0102310)
shuehner   
2018-02-11 13:25   
Note use of the ad_process_id 800101 could be found in pi or getAllModules except the 3 tabs mentioned above.
(0102311)
shuehner   
2018-02-11 13:28   
Apart parts of that report (function debtPaymentTree) has hard-coded Spanish language text in it shown in the report. Making it useless in other languages.
(0103794)
hgbot   
2018-04-10 21:13   
Repository: erp/devel/pi
Changeset: ef587ec4fac7a7f972d366e049d48ee2c58b92b6
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Feb 11 13:47:02 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ef587ec4fac7a7f972d366e049d48ee2c58b92b6 [^]

Fixed 37881. Remove obsolete (pre-aprm) old flow report Promissory Note.

That report uses old fop rendering technology and is related to the old
payment flow from before aprm which is mandatory since start of 3.0
It is only referenced in 3 deactivated tabs related to that old flow.

---
M referencedata/sampledata/F_B_International_Group/AD_PROCESS_ACCESS.xml
M referencedata/sampledata/QA_Testing/AD_PROCESS_ACCESS.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_PROCESS.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
R src/org/openbravo/erpReports/RptPromissoryNote.fo
R src/org/openbravo/erpReports/RptPromissoryNote.java
R src/org/openbravo/erpReports/RptPromissoryNote.xml
R src/org/openbravo/erpReports/RptPromissoryNoteAfter.fo
R src/org/openbravo/erpReports/RptPromissoryNoteAfter.xml
R src/org/openbravo/erpReports/RptPromissoryNoteAfter_data.xsql
R src/org/openbravo/erpReports/RptPromissoryNoteError.fo
R src/org/openbravo/erpReports/RptPromissoryNoteError.xml
R src/org/openbravo/erpReports/RptPromissoryNoteError_data.xsql
R src/org/openbravo/erpReports/RptPromissoryNoteHeader.fo
R src/org/openbravo/erpReports/RptPromissoryNoteHeader.xml
R src/org/openbravo/erpReports/RptPromissoryNoteHeader_data.xsql
R src/org/openbravo/erpReports/RptPromissoryNoteTree_data.xsql
R src/org/openbravo/erpReports/RptPromissoryNote_data.xsql
---
(0103825)
vmromanos   
2018-04-11 17:05   
Code review OK.

Stuff belonging to old payment flow