Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037867Openbravo ERPA. Platformpublic2018-02-09 10:542018-02-22 18:19
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037867: Missing admin mode in HQLDataSourceService
DescriptionThere is a missing admin mode in HQLDataSourceService.getTableFromParameters. Usually this issue is not reproducible because the user's role has readable access to the AD_TABLE table, but if the user has limited access an exception will be thrown.
Steps To ReproduceCreate a role with very limited access:
- User Level: Client + Organization
- Manual: True
- Org Access: All
- User Assignment: Openbravo
- Window Access: Return From Customer, Editable Field = true

Log in with Openbravo, switch to the new role.
- Open the Return from Customer window
- Create a record in the header tab
- Click on the Pick/Edit Lines button. The following error will be shown in the console:

425945 [http-bio-8080-exec-9] ERROR org.openbravo.base.exception.OBSecurityException - Entity ADTable is not readable by the user 100
org.openbravo.base.exception.OBSecurityException: Entity ADTable is not readable by the user 100
    at org.openbravo.dal.security.EntityAccessChecker.checkReadable(EntityAccessChecker.java:343)
    at org.openbravo.dal.service.OBDal.checkReadAccess(OBDal.java:596)
    at org.openbravo.dal.service.OBDal.checkReadAccess(OBDal.java:583)
    at org.openbravo.dal.service.OBDal.get(OBDal.java:297)
    at org.openbravo.service.datasource.HQLDataSourceService.getTableFromParameters(HQLDataSourceService.java:223)
    at org.openbravo.service.datasource.HQLDataSourceService.getData(HQLDataSourceService.java:161)
    at org.openbravo.service.datasource.ReadOnlyDataSourceService.fetchJSONObject(ReadOnlyDataSourceService.java:135)
    at org.openbravo.service.datasource.ReadOnlyDataSourceService.fetch(ReadOnlyDataSourceService.java:68)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-09 10:54AugustoMauchNew Issue
2018-02-09 10:54AugustoMauchAssigned To => AugustoMauch
2018-02-09 10:54AugustoMauchModules => Core
2018-02-09 10:54AugustoMauchTriggers an Emergency Pack => No
2018-02-09 10:56AugustoMauchReview Assigned To => caristu
2018-02-09 10:56hgbotCheckin
2018-02-09 10:56hgbotNote Added: 0102298
2018-02-09 10:56hgbotStatusnew => resolved
2018-02-09 10:56hgbotResolutionopen => fixed
2018-02-09 10:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3d95f9654e988bdddbfe214ccfdd12a396fa9af7 [^]
2018-02-09 11:37hgbotCheckin
2018-02-09 11:37hgbotNote Added: 0102301
2018-02-12 12:24caristuNote Added: 0102329
2018-02-12 12:24caristuStatusresolved => closed
2018-02-12 12:24caristuFixed in Version => 3.0PR18Q2
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102740
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102742

Notes
(0102298)
hgbot   
2018-02-09 10:56   
Repository: erp/devel/pi
Changeset: 3d95f9654e988bdddbfe214ccfdd12a396fa9af7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Feb 09 10:56:05 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3d95f9654e988bdddbfe214ccfdd12a396fa9af7 [^]

Fixes issue 37867: Adds missing admin mode

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
---
(0102301)
hgbot   
2018-02-09 11:37   
Repository: erp/devel/pi
Changeset: 05d03896eb4a7a415509660f15eada0ed1d7a27b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Feb 09 11:36:42 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/05d03896eb4a7a415509660f15eada0ed1d7a27b [^]

Related with issue 37867: Commented out code meant for debug has been restored

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
---
(0102329)
caristu   
2018-02-12 12:24   
Code reviewed + tested OK.
(0102740)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102742)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test