Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0037866Openbravo ERP04. Warehouse managementpublic2018-02-09 10:522018-02-22 18:19
lorenzofidalgo 
markmm82 
immediatemajoralways
closedfixed 
5
main 
3.0PR18Q2 
dmiguelez
Core
Production - Confirmed Stable
2016-11-18
3.0PR17Q1
https://code.openbravo.com/erp/devel/pi/rev/7232cc0b37a9 [^]
No
0037866: [RR18Q1][Cancel & Replace] Sales Order is not selectable in Create Lines From process under certain circumstances
It is not possible to use the resulting Sales Order from a "Cancel & Replace" process in the "Create Lines From" process from "Goods Shipment" window under certain circumstances.
It seems it is related with adding in the "Cancel & Replace" order new units of an already created product in the order before using the "Cancel & Replace" process. It is happening when the user is adding a new line of the already created product or even adding more products in the already created line.
It can be checked here, following this testlink test case:
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10244 [^]

DEFECT: In the test case, when it is said "Check only new discount line added, as well as line for product A - 3 units, and line for Product B - 4 units are shown there for selection." it can not be checked due to the order is not shown.
No tags attached.
depends on backport 00379693.0PR18Q1 closed markmm82 [RR18Q1][Cancel & Replace] Sales Order is not selectable in Create Lines From process under certain circumstances 
depends on backport 00379703.0PR17Q4.2 closed markmm82 [RR18Q1][Cancel & Replace] Sales Order is not selectable in Create Lines From process under certain circumstances 
caused by design defect 00346123.0PR17Q1 closed vmromanos Performance problem in Return To Vendor Shipment 
Issue History
2018-02-09 10:52lorenzofidalgoNew Issue
2018-02-09 10:52lorenzofidalgoAssigned To => Triage Finance
2018-02-09 10:52lorenzofidalgoModules => Core
2018-02-09 10:52lorenzofidalgoRegression level => Production - Confirmed Stable
2018-02-09 10:52lorenzofidalgoTriggers an Emergency Pack => No
2018-02-09 10:54lorenzofidalgoSummary[RR18Q1][Cancel & Replace] => [RR18Q1][Cancel & Replace] Sales Order is not selectable in Create Lines From process under certain circumstances
2018-02-09 10:56lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16656#r16656
2018-02-12 15:42markmm82Assigned ToTriage Finance => markmm82
2018-02-13 15:24markmm82Note Added: 0102366
2018-02-13 15:25markmm82Statusnew => scheduled
2018-02-16 11:17dmiguelezRegression date => 2016-11-18
2018-02-16 11:17dmiguelezRegression introduced in release => 3.0PR17Q1
2018-02-16 11:17dmiguelezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/7232cc0b37a9 [^]
2018-02-16 11:17dmiguelezRelationship addedcaused by 0034612
2018-02-19 17:27dmiguelezStatusscheduled => acknowledged
2018-02-19 17:29dmiguelezStatusacknowledged => scheduled
2018-02-19 17:53hgbotCheckin
2018-02-19 17:53hgbotNote Added: 0102496
2018-02-19 17:53hgbotStatusscheduled => resolved
2018-02-19 17:53hgbotResolutionopen => fixed
2018-02-19 17:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/da668ab518be3cf3e1dd3fb09ded504cccd80550 [^]
2018-02-19 17:56dmiguelezReview Assigned To => dmiguelez
2018-02-19 17:56dmiguelezNote Added: 0102499
2018-02-19 17:56dmiguelezStatusresolved => closed
2018-02-19 17:56dmiguelezFixed in Version => 3.0PR18Q2
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102776

Notes
(0102366)
markmm82   
2018-02-13 15:24   
Test Plan 1: Cancel a delivered order and modify lines of the replacement order

As F&B International Group Admin
  Enable Enable and Cancel Order preference.
  Log out an login
Create a new sales order for F&B España SA and Alimentos y Supermercados business partner
Add a line with Cerveza Ale product and 10 units.
Add a line with Cerveza Lager product and 10 units.
Book the order.
  Take a note of the order no, for instance 1000255.
  Notice Delivery Status: 0% and Delivered: No
Create a new goods shipment for F&B España SA and Alimentos y Supermercados business partner.
Press Create Lines From button
  Select the order previously created, for instance 1000255.
  Warehouse position = Rn-0-0-0
  Select all the lines of the order.
Complete the shipment.
Go to the previously created order 1000255.
  Notice it is marked as delivered:
    Delivery status = 100%
    Delivered = Yes
Press Cancel and Replace to the order.
  Notice a new order (1000255-1) in temporary status was created with delivery status = 0%.
  There are two lines with the same information than the original one, except they have 0 as Delivered Quantity.
  Add another line with Cerveza Ale product and 3 units.
  Add another line with Cerveza Lager product and 4 units.
Execute the Confirm Cancel and Replace process
  Notice that Delivery Status was updated to 74% and Delivered marked as No as the 3 units of Cerveza Ale and the 4 Units of Cerveza Lager still without be delivered.
  Verify that the original order number 1000255 is showed as closed, same as the reversed order 1000254*R*, this last one in negative. Verify that both have a Delivery Status = 0%.
Go to Goods Shipment window and create a new one for F&B España SA and Alimentos y Supermercados business partner.
Press Create Lines From button
  Notice the previously replacement order is there as it has products pending to be delivered.
  Select the replacement order 1000255-1.
  Notice there are two lines with the 3 units of Cerveza Ale and another for the 4 units of Cerveza Lager.
Select all the order lines, Rn-0-0-0 warehouse and press done button.
Complete the shipment.
Go back to the Sales Order window and select the replacement order 1000255-1.
  Notice it is marked as delivered:
    Delivery status = 100%
    Delivered = Yes


Test Plan 2: Cancel a delivered order and don't modify any lines of the replacement order
As F&B International Group Admin
  Enable Enable and Cancel Order preference.
  Log out an login
Create a new sales order for F&B España SA and Alimentos y Supermercados business partner
Add a line with Cerveza Ale product and 10 units.
Add a line with Cerveza Lager product and 10 units.
Book the order.
  Take a note of the order no, for instance 1000254.
  Notice Delivery Status: 0% and Delivered: No
Create a new goods shipment for F&B España SA and Alimentos y Supermercados business partner.
Press Create Lines From button
  Select the order previously created, for instance 1000254.
  Warehouse position = Rn-0-0-0
  Select all the lines of the order.
Complete the shipment.
Go to the previously created order 1000254.
  Notice it is marked as delivered:
    Delivery status = 100%
    Delivered = Yes
Press Cancel and Replace to the order.
  Notice a new order (1000254-1) in temporary status was created with delivery status = 0%.
  There are two lines with the same information than the original one, except they have 0 as Delivered Quantity.
Execute the Confirm Cancel and Replace process
  Notice that Delivery Status was updated to 100% and Delivered marked as Yes.
  Verify that the original order number 1000254 is showed as closed, same as the reversed order 1000254*R*, this last one in negative. Verify that both have a Delivery Status = 0%.
Go to Goods Shipment window and create a new one for F&B España SA and Alimentos y Supermercados business partner.
Press Create Lines From button
   Notice the previously orders doesn't appears in the organization combobox. It is correct because the original one was cancelled and the replacement is completely delivered.


Test Plan 3: Cancel a not delivered order (don't create shipments for it) and modify any lines of the replacement order
As F&B International Group Admin
  Enable Enable and Cancel Order preference.
  Log out an login
Create a new sales order for F&B España SA and Alimentos y Supermercados business partner
Add a line with Cerveza Ale product and 10 units.
Add a line with Cerveza Lager product and 10 units.
Book the order.
  Take a note of the order no, for instance 1000256.
  Notice Delivery Status: 0% and Delivered: No
Press Cancel and Replace to the order.
  Notice a new order (1000256-1) in temporary status was created with delivery status = 0%.
  There are two lines with the same information than the original one, they have 0 as Delivered Quantity.
Execute the Confirm Cancel and Replace process
  Notice that Delivery Status wremains as 0% and Delivered marked as No.
  Verify that the original order number 1000256 is showed as closed, same as the reversed order 1000256*R*, this last one in negative. Verify that both have a Delivery Status = 0%.
Go to Goods Shipment window and create a new one for F&B España SA and Alimentos y Supermercados business partner.
Press Create Lines From button
  Notice the previously replacement order is there as it has products pending to be delivered.
  Select the replacement order 1000255-1.
  Notice there are two lines with the 3 units of Cerveza Ale and another for the 4 units of Cerveza Lager.
Select all the order lines, Rn-0-0-0 warehouse and press done button.
Complete the shipment.
Go back to the Sales Order window and select the replacement order 1000256-1.
  Notice it is marked as delivered:
    Delivery status = 100%
    Delivered = Yes
(0102496)
hgbot   
2018-02-19 17:53   
Repository: erp/devel/pi
Changeset: da668ab518be3cf3e1dd3fb09ded504cccd80550
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Feb 16 09:45:26 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/da668ab518be3cf3e1dd3fb09ded504cccd80550 [^]

Fixes Issue 37866. When completing an Order, if the Quantity ordered
is not the same as the Quantity delivered for any line, the flag
isDelivered is set as N.

---
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0102499)
dmiguelez   
2018-02-19 17:56   
Code Review + Testing Ok
(0102776)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test