Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037857Openbravo ERPA. Platformpublic2018-02-08 09:112018-02-22 18:19
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037857: Wrong FIC Request after selecting all records in a grid with hundreds of lines
DescriptionWrong FIC Requests are being generated after selecting all records in a grid that has lots of lines. The Request-URI exceeds the supported length (see attached image).
Steps To Reproduce1) As F&B group admin, go to the [Sales Order] window.
2) Remove the implicit filter by clicking on the funnel icon.
3) In the header, scroll down until all records are retrieved.
4) Using the "select all" checkbox, select all the records.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029746 closed caristu unneded FIC request on record selection in some windows 
related to defect 00275333.0PR14Q4 closed alostale context information is sent as a query string parameter when calculating defaults in process definition windows 
related to defect 00205223.0MP12 closed guilleaer Attachment icon does not work fine in grid view 
Attached Filespng request-uri-too-long.png (387,911) 2018-02-08 09:11
https://issues.openbravo.com/file_download.php?file_id=11558&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-02-08 09:11caristuNew Issue
2018-02-08 09:11caristuAssigned To => platform
2018-02-08 09:11caristuFile Added: request-uri-too-long.png
2018-02-08 09:11caristuModules => Core
2018-02-08 09:11caristuTriggers an Emergency Pack => No
2018-02-08 09:11caristuPrioritynormal => high
2018-02-08 09:26caristuRelationship addedrelated to 0029746
2018-02-08 10:05caristuRelationship addedrelated to 0027533
2018-02-08 10:41caristuAssigned Toplatform => caristu
2018-02-08 10:41caristuStatusnew => scheduled
2018-02-08 10:59caristuRelationship addedrelated to 0020522
2018-02-08 18:12hgbotCheckin
2018-02-08 18:12hgbotNote Added: 0102277
2018-02-08 18:12hgbotStatusscheduled => resolved
2018-02-08 18:12hgbotResolutionopen => fixed
2018-02-08 18:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/81994596bc5163f08b8841209eb6a8cdbd6f9bf0 [^]
2018-02-08 18:47caristuReview Assigned To => alostale
2018-02-09 09:16hgbotCheckin
2018-02-09 09:16hgbotNote Added: 0102289
2018-02-09 09:17alostaleNote Added: 0102290
2018-02-09 09:17alostaleStatusresolved => closed
2018-02-09 09:17alostaleFixed in Version => 3.0PR18Q2
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102736
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102737

Notes
(0102277)
hgbot   
2018-02-08 18:12   
Repository: erp/devel/pi
Changeset: 81994596bc5163f08b8841209eb6a8cdbd6f9bf0
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Feb 08 18:10:27 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/81994596bc5163f08b8841209eb6a8cdbd6f9bf0 [^]

fixes bug 37857: Wrong FIC request after selecting hundreds of records

  The MULTIPLE_ROW_IDS parameter contains the ids of the selected records that are sent to the FIC. They are used to check if there exists attachments within the selection and in that case enable the attachment button of the toolbar or display the number of attachments of the current record in case we are in form view.

  This information was being sent as part of the request URL in the HTTP header which in case of having hundreds of records, the maximum size allowed for the request URL was being exceeded.

  To fix this problem, now the MULTIPLE_ROW_IDS parameter is sent within the body of the FIC request.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0102289)
hgbot   
2018-02-09 09:16   
Repository: erp/devel/pi
Changeset: 7a23607a0b6cce98d0c68bea9a301fdf99e542d7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 09 09:15:50 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7a23607a0b6cce98d0c68bea9a301fdf99e542d7 [^]

related to bug 37857: minor optimizations

  * FIC uses multiple ids only for attachemnts, we can initialize it only in that case
  * In convertJSONArray use more generic variable name
  * In convertJSONArray we know which will be the array size, so it can be initialized
    using it

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0102290)
alostale   
2018-02-09 09:17   
tested

reviewed and applied some minor improvements
(0102736)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102737)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test