Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037856Retail ModulesDiscounts by Payment Methodpublic2018-02-08 06:442018-02-15 14:02
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037856: Issues in Payment Method discount calculation
DescriptionPayment Method Discount is not properly calculated which leads to 0.01 pending payment for cash exact payment
Steps To ReproduceIn the backend:
-> Change 'Avalanche transceiver' product's price to 52 in 'The White Valley Group Sale Price List Version' price list (Price Includes Tax)
-> Add a Payment method Discount for Cash in Discounts and Promotions window: Discount %: 2.3
IN POS
-> Add 2 qty of Avalanche transceiver (Total Amount: 104.00)
-> Pay with exact cash (Verify Info: Pay 101.61€ after 2.3% discount for Cash payment)
-> Verify Discount 2.38 is added for line (But it should be 2.39, So it leads to 0.01 remailing to pay)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039224 scheduled umartirena Discount calculation amount issue in Discount by Payment Method 
Attached Filespng issue 37856.png (146,357) 2018-02-08 06:52
https://issues.openbravo.com/file_download.php?file_id=11557&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-02-08 06:44ranjith_qualiantech_comNew Issue
2018-02-08 06:44ranjith_qualiantech_comAssigned To => Retail
2018-02-08 06:44ranjith_qualiantech_comTriggers an Emergency Pack => No
2018-02-08 06:44ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-02-08 06:52ranjith_qualiantech_comSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16650#r16650
2018-02-08 06:52ranjith_qualiantech_comFile Added: issue 37856.png
2018-02-08 07:56hgbotCheckin
2018-02-08 07:56hgbotNote Added: 0102267
2018-02-08 08:15ranjith_qualiantech_comStatusnew => scheduled
2018-02-09 10:04hgbotCheckin
2018-02-09 10:04hgbotNote Added: 0102293
2018-02-09 10:04ranjith_qualiantech_comStatusscheduled => resolved
2018-02-09 10:04ranjith_qualiantech_comResolutionopen => fixed
2018-02-15 14:02marvintmReview Assigned To => marvintm
2018-02-15 14:02marvintmStatusresolved => closed
2018-02-15 14:02marvintmFixed in Version => RR18Q2
2018-09-04 14:18umartirenaRelationship addedrelated to 0039224

Notes
(0102267)
hgbot   
2018-02-08 07:56   
Repository: erp/pmods/org.openbravo.retail.discounts.bypaymentmethod
Changeset: f10e23042215c87ecf889a16f12ce1e0e77f3516
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Feb 08 12:26:17 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/f10e23042215c87ecf889a16f12ce1e0e77f3516 [^]

Related to issue 37856 : Fixed discount calculation roundoff problems

* Added incrementalUpdateCriteria for Discount in discountByPaymentMethod query

---
M src/org/openbravo/retail/discounts/bypaymentmethod/PaymentMethodDiscount.java
M web/org.openbravo.retail.discounts.bypaymentmethod/js/paymentmethod-discount.js
---
(0102293)
hgbot   
2018-02-09 10:04   
Repository: tools/automation/pi-mobile
Changeset: 88a52f830ac48421e0e86a41c7407aa728d6e838
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Feb 09 14:34:19 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/88a52f830ac48421e0e86a41c7407aa728d6e838 [^]

Verifies issue 37856 : Added automated test 'I37856_VerifyDiscountCalculation'

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bypaymentmethod/I37856_VerifyDiscountCalculation.java
---