Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037853Openbravo ERPA. Platformpublic2018-02-07 14:472019-05-17 09:07
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037853: ImportEntryManager.reportsStatus only does long time avg, useless to see any short term changes
DescriptionImportEntryManager tracks some performance statistics (runtime) per 'typeofdata' and prints those every 100 records processed.

Example lines:
2018-02-06 21:01:01,493 INFO org.openbravo.service.importprocess.ImportEntryManager - Timings for Order cnt: 61900 avg millis: 901
2018-02-07 09:42:31,044 INFO org.openbravo.service.importprocess.ImportEntryManager - Timings for Order cnt: 100 avg millis: 3741

However the avg is calculated as 'sum of all time of all records' / total-count

Problem is that this is then long-term average since tomcat start which is useless and can be misleading.

Example:
Spike in processing time for a while.
System recovers back to normal time.

As avg is over both it will return very very slow only to the 'current' speed.

More useful could be:
- avg of 'last 100 records'

Maybe useful to keep the long-term avg also by tracking both internally.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0036162 acknowledged Triage Platform Base clean up openbravo.log 
related to defect 0040747 closed alostale Unnecessary wait in Import Entry Manager is causing lag in the processing of import entries even if resources are available 
related to feature request 0040765 acknowledged Triage Platform Base expose ImportEntryManager statistics via jmx 
related to feature request 0042001 new Triage Platform Base add statistical information to c_import_entry 
related to feature request 0047152 closed alostale add the capability to log import entry status 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-07 14:47shuehnerNew Issue
2018-02-07 14:47shuehnerAssigned To => platform
2018-02-07 14:47shuehnerModules => Core
2018-02-07 14:47shuehnerTriggers an Emergency Pack => No
2018-02-07 14:48shuehnerNote Added: 0102252
2018-02-07 18:09shuehnerTypedefect => feature request
2018-02-08 08:16alostaleStatusnew => acknowledged
2018-02-08 08:16alostaleRelationship addedrelated to 0036162
2019-05-03 13:33alostaleAssigned Toplatform => alostale
2019-05-03 13:44alostaleRelationship addedrelated to 0040747
2019-05-03 13:45alostaleReview Assigned To => caristu
2019-05-03 13:47alostaleRelationship addedrelated to 0040765
2019-05-07 08:02hgbotCheckin
2019-05-07 08:02hgbotNote Added: 0111519
2019-05-07 08:02hgbotStatusacknowledged => resolved
2019-05-07 08:02hgbotResolutionopen => fixed
2019-05-07 08:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3ad31745f63eb1fab22f5a6d4da526bbde7b9f94 [^]
2019-05-17 09:07caristuNote Added: 0111760
2019-05-17 09:07caristuStatusresolved => closed
2019-05-17 09:07caristuFixed in Version => 3.0PR19Q3
2019-10-11 16:19alostaleRelationship addedrelated to 0042001
2021-06-25 09:16alostaleRelationship addedrelated to 0047152

Notes
(0102252)
shuehner   
2018-02-07 14:48   
Apart maybe useful to expose those numbers via jmx.
Also could be useful to add a resetStats jmx-callable operation.
(0111519)
hgbot   
2019-05-07 08:02   
Repository: erp/devel/pi
Changeset: 3ad31745f63eb1fab22f5a6d4da526bbde7b9f94
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri May 03 14:06:11 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3ad31745f63eb1fab22f5a6d4da526bbde7b9f94 [^]

fixes 37853: improved ImportEntryManager logs

  - Log partial timing statistics for the last 100 entries processed keeping also
    total statisitcs since last restart
  - Include process time for each processed entry
  - ImportEntryProcessor.addEntry
     * Set key to runnable before adding entry so it gets properly logged
     * In all logs include type of data and key to know if problems occur in a
       single processor
     * Increase from debug to warn log level message when processor's quee is
       completelly full. This should really exceptional and worth to make it
       visible in log as it might indicate sever problems

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
M src/org/openbravo/service/importprocess/ImportEntryProcessor.java
---
(0111760)
caristu   
2019-05-17 09:07   
Reviewed