Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037839Retail ModulesStoreServerpublic2018-02-06 11:052018-03-14 11:13
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037839: When transition to offline ping central server
DescriptionThe current code uses the timestamp method to wait/check when the CS has last contacted the SS. It should instead do a ping. The links below for related code.

https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java#l167 [^]

https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java#l200 [^]
Steps To ReproduceSee above
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 37839.diff (6,679) 2018-02-14 10:53
https://issues.openbravo.com/file_download.php?file_id=11576&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-02-06 11:05mtaalNew Issue
2018-02-06 11:05mtaalAssigned To => mtaal
2018-02-06 11:05mtaalTriggers an Emergency Pack => No
2018-02-14 10:53mtaalFile Added: 37839.diff
2018-02-14 21:06hgbotCheckin
2018-02-14 21:06hgbotNote Added: 0102420
2018-02-14 21:06hgbotStatusnew => resolved
2018-02-14 21:06hgbotResolutionopen => fixed
2018-02-14 21:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6ef2cc3bcfd4027ffbf2dea674d6bee3adc80c3d [^]
2018-03-02 11:15SandrahuguetNote Added: 0102912
2018-03-11 23:44mtaalReview Assigned To => AugustoMauch
2018-03-14 11:08AugustoMauchNote Added: 0103235
2018-03-14 11:13AugustoMauchNote Added: 0103236
2018-03-14 11:13AugustoMauchStatusresolved => closed
2018-03-14 11:13AugustoMauchFixed in Version => RR18Q2

Notes
(0102420)
hgbot   
2018-02-14 21:06   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6ef2cc3bcfd4027ffbf2dea674d6bee3adc80c3d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Feb 14 21:06:00 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6ef2cc3bcfd4027ffbf2dea674d6bee3adc80c3d [^]

Fixes issue 37839: When transition to offline ping central server
Do an explicit ping to the central server when transitioning to offline

---
M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0102912)
Sandrahuguet   
2018-03-02 11:15   
I think that storeserver job[1] start failing since this commit

[1]http://ci.openbravo.com/view/storeserver/job/ret-ms-store1-pgsql/1137/testReport/junit/org.openbravo.test.mobile.retail.multiserver.selenium.tests.offline/OfflineMSCentral001_SalesFlow/test_2/ [^]
(0103235)
AugustoMauch   
2018-03-14 11:08   
This [1] is the change that broke the store server job, it was pushed the same day as [2]

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a6d5be7a45b55c008bcb7b1f00bc8a31cc1493c8 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6ef2cc3bcfd4027ffbf2dea674d6bee3adc80c3d [^]
(0103236)
AugustoMauch   
2018-03-14 11:13   
Code reviewed and verified