Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037837Openbravo ERP07. Sales managementpublic2018-02-05 16:202020-01-20 18:59
Reportercollazoandy4 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037837: Tax selected is based on the invoicing address instead of the partner address
DescriptionThe product tax selected is based on the invoicing address instead of the business partner address
Steps To Reproduce   Go to Business Partner window and create a new record:
    Search Key/Name: IssueBP
    Set as customer
    Create two new records in Location/Address tab
      1. Spain, Shipment Address: Y, Invoicing Address: N
      2. Hong kong, Shipment Address: N, Invoicing Address: Y
    Go to Preferences and create a new record:
      Property: RM Allow Orphan Line
      Value: Y
    Log out and Log in
    Go to Goods Shipment window and create a new record:
     Business Partner: IssueBP
     Create a new record in Lines tab:
       Product: Zumo de Piña 0,5L
       Movement Quantity: 10
     Complete the shipment
    Go to Return from Customer window and create a new record:
      Business Partner: IssueBP
      Clic on Insert Orphan Line Button
        Product: Agua sin Gas 1L
        Returned: 2
      Check that the created Tax is wrong Exportaciones (%N=>0%) should be Entregas IVA 21%
      Clic on Pick Edit Lines and select the previous shipment created and set returned qty 4
      Check that the created Tax is wrong Exportaciones (%N=>0%) should be Entregas IVA 21%
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037780 closed collazoandy4 Modules Tax selected for freight product is based on the invoicing address instead of on the partner address 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-05 16:20collazoandy4New Issue
2018-02-05 16:20collazoandy4Assigned To => collazoandy4
2018-02-05 16:20collazoandy4OBNetwork customer => No
2018-02-05 16:20collazoandy4Modules => Core
2018-02-05 16:20collazoandy4Triggers an Emergency Pack => No
2018-02-05 16:22collazoandy4Relationship addedrelated to 0037780
2018-02-05 16:24collazoandy4Statusnew => scheduled
2018-02-05 21:31collazoandy4Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=16632#r16632
2018-02-06 17:14collazoandy4Note Added: 0102224
2018-02-07 18:11hgbotCheckin
2018-02-07 18:11hgbotNote Added: 0102263
2018-02-07 18:11hgbotStatusscheduled => resolved
2018-02-07 18:11hgbotResolutionopen => fixed
2018-02-07 18:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/edd3344593b909642938d0b2eac338a6780ff37d [^]
2018-02-07 18:12dmiguelezReview Assigned To => dmiguelez
2018-02-07 18:12dmiguelezNote Added: 0102264
2018-02-07 18:12dmiguelezStatusresolved => closed
2018-02-07 18:12dmiguelezFixed in Version => 3.0PR18Q2
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102730
2020-01-20 18:59eugeniIssue Monitored: eugeni

Notes
(0102224)
collazoandy4   
2018-02-06 17:14   
Test Plan
   Go to Business Partner window and create a new record:
    Search Key/Name: IssueBP
    Set as customer
    Create two new records in Location/Address tab
      1. Spain, Shipment Address: Y, Invoicing Address: N
      2. Hong kong, Shipment Address: N, Invoicing Address: Y
    Go to Preferences and create a new record:
      Property: RM Allow Orphan Line
      Value: Y
    Log out and Log in
    Go to Goods Shipment window and create a new record:
     Business Partner: IssueBP
     Create a new record in Lines tab:
       Product: Zumo de Piña 0,5L
       Movement Quantity: 10
     Complete the shipment
    Go to Return from Customer window and create a new record:
      Business Partner: IssueBP
      Clic on Insert Orphan Line Button
        Product: Agua sin Gas 1L
        Returned: 2
      Check that the created Tax is now selected correctly Entregas IVA 21%
      Clic on Pick Edit Lines and select the previous shipment created and set returned qty 4
      Check that the created Tax is now selected correctly Entregas IVA 21%
(0102263)
hgbot   
2018-02-07 18:11   
Repository: erp/devel/pi
Changeset: edd3344593b909642938d0b2eac338a6780ff37d
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Feb 05 11:14:10 2018 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/edd3344593b909642938d0b2eac338a6780ff37d [^]

Fixes issue 37837:Tax selected is based on the invoicing address instead of the
partner address

Wrong tax is selected when selecting a business partner with different invoicing
and shipping address, the invoicing address was used as shipping

Now the correct business partner address is selected to properly get the product
tax

---
M src/org/openbravo/common/actionhandler/OrderCreatePOLines.java
M src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
M src/org/openbravo/erpCommon/ad_actionButton/RMInsertOrphanLine.java
---
(0102264)
dmiguelez   
2018-02-07 18:12   
Code Review + Testing Ok
(0102730)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test