Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037828Openbravo ERPZ. Otherspublic2018-02-05 10:092018-03-06 16:57
Reportervmromanos 
Assigned Tovmromanos 
PrioritynormalSeveritytrivialReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037828: False API change due to referenced inventory
DescriptionA new not mandatory column has been added: M_ATTRIBUTESETINSTANCE.M_REFINVENTORY_ID

The new constraint forces to enter a PARENT_ATTRIBUTESETINSTANCE_ID when the M_REFINVENTORY_ID is not null, but also allows null values in M_REFINVENTORY_ID column, thus this is a false positive API change.


 [checkAPI] 11105 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 11108 ERROR - Errors in API model validation
 [checkAPI] 11111 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 11113 ERROR - Check Constraint addition: table: M_ATTRIBUTESETINSTANCE - Constraint: M_ATTRIBUTESETINST_REFINV_CH defined as: M_REFINVENTORY_ID IS NULL OR M_REFINVENTORY_ID IS NOT NULL AND PARENT_ATTRIBUTESETINSTANCE_ID IS NOT NULL
 [checkAPI] 11116 ERROR -
Steps To ReproduceNA
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 00378273.0PR18Q2 closed vmromanos Referenced Inventory 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-05 10:09vmromanosNew Issue
2018-02-05 10:09vmromanosAssigned To => vmromanos
2018-02-05 10:09vmromanosModules => Core
2018-02-05 10:09vmromanosTriggers an Emergency Pack => No
2018-02-05 10:10vmromanosRelationship addedcaused by 0037827
2018-02-05 10:10vmromanosStatusnew => scheduled
2018-02-05 10:22hgbotCheckin
2018-02-05 10:22hgbotNote Added: 0102174
2018-02-05 10:22hgbotStatusscheduled => resolved
2018-02-05 10:22hgbotResolutionopen => fixed
2018-02-05 10:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/8a07142fc297c46a2e863595d4bf01be8f8e57a9 [^]
2018-02-05 10:39vmromanosReview Assigned To => dmiguelez
2018-02-05 10:51hgbotCheckin
2018-02-05 10:51hgbotNote Added: 0102176
2018-02-05 10:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/8a07142fc297c46a2e863595d4bf01be8f8e57a9 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/968e1b6ad4b99cf2aab5403d77caf40fdd7d30b5 [^]
2018-02-21 12:08hgbotCheckin
2018-02-21 12:08hgbotNote Added: 0102551
2018-02-21 12:08hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/968e1b6ad4b99cf2aab5403d77caf40fdd7d30b5 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/d16ac4ba9b8473fc2feb4445370dc8f676d2a888 [^]
2018-02-21 19:05hgbotCheckin
2018-02-21 19:05hgbotNote Added: 0102563
2018-02-21 19:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/d16ac4ba9b8473fc2feb4445370dc8f676d2a888 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/d50b65e7a8db90d11049abf1f8bb9bbd7aeab169 [^]
2018-03-05 17:09hgbotCheckin
2018-03-05 17:09hgbotNote Added: 0102992
2018-03-05 17:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/d50b65e7a8db90d11049abf1f8bb9bbd7aeab169 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/f080e55e2f0086b382fdf1250340d27b2f701a5e [^]
2018-03-06 16:57dmiguelezNote Added: 0103033
2018-03-06 16:57dmiguelezStatusresolved => closed
2018-03-06 16:57dmiguelezFixed in Version => 3.0PR18Q2

Notes
(0102174)
hgbot   
2018-02-05 10:22   
Repository: erp/devel/api-checks
Changeset: 8a07142fc297c46a2e863595d4bf01be8f8e57a9
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 05 10:11:24 2018 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/8a07142fc297c46a2e863595d4bf01be8f8e57a9 [^]

Fixed issue 37828: [ri] False API change due to referenced inventory

---
M model/src-db/database/model/tables/M_ATTRIBUTESETINSTANCE.xml
---
(0102176)
hgbot   
2018-02-05 10:51   
Repository: erp/devel/api-checks
Changeset: 968e1b6ad4b99cf2aab5403d77caf40fdd7d30b5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 05 10:50:52 2018 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/968e1b6ad4b99cf2aab5403d77caf40fdd7d30b5 [^]

Fixed issue 37828: [ri] Added rest of changes

---
M model/src-db/database/model/tables/M_MOVEMENTLINE.xml
M model/src-db/database/model/tables/M_STORAGE_DETAIL.xml
A model/src-db/database/model/tables/M_REFINVENTORY.xml
A model/src-db/database/model/tables/M_REFINVENTORY_TYPE.xml
---
(0102551)
hgbot   
2018-02-21 12:08   
Repository: erp/devel/api-checks
Changeset: d16ac4ba9b8473fc2feb4445370dc8f676d2a888
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Feb 21 12:08:12 2018 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/d16ac4ba9b8473fc2feb4445370dc8f676d2a888 [^]

Fixed issue 37828: [ri] pushed again false API change changesets

---
M model/src-db/database/model/tables/M_ATTRIBUTESETINSTANCE.xml
M model/src-db/database/model/tables/M_MOVEMENTLINE.xml
M model/src-db/database/model/tables/M_STORAGE_DETAIL.xml
A model/src-db/database/model/tables/M_REFINVENTORY.xml
A model/src-db/database/model/tables/M_REFINVENTORY_TYPE.xml
---
(0102563)
hgbot   
2018-02-21 19:05   
Repository: erp/devel/api-checks
Changeset: d50b65e7a8db90d11049abf1f8bb9bbd7aeab169
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Feb 21 19:02:49 2018 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/d50b65e7a8db90d11049abf1f8bb9bbd7aeab169 [^]

Fixed issue 37828: [ri] redesign M_REFINVENTORY_VALUE_UN unique constraint

---
M model/src-db/database/model/tables/M_REFINVENTORY.xml
---
(0102992)
hgbot   
2018-03-05 17:09   
Repository: erp/devel/api-checks
Changeset: f080e55e2f0086b382fdf1250340d27b2f701a5e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Mar 05 16:42:54 2018 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/f080e55e2f0086b382fdf1250340d27b2f701a5e [^]

Fixed issue 37828: [ri] Add unique constraint in M_REFINVENTORY_TYPE
and removed useless BoxProcessor.createAndProcessGoodsMovement() override.

Both are false API changes because they change API not included in a released version.

---
M java/reference/java.japi.gz
M model/src-db/database/model/tables/M_REFINVENTORY_TYPE.xml
---
(0103033)
dmiguelez   
2018-03-06 16:57   
Code Review + Testing Ok