Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037817Retail ModulesCopy Retail Storepublic2018-02-02 09:312018-03-06 17:57
Reporterlmonreal 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037817: Copy Store is not working with a Store with two Pos Terminal Types (one for SCO and the other not)
DescriptionWhen trying to apply Copy store to an organization that has two pos terminal types, one configured for SCO and the other that is not SCO an error is displayed "SCO configuration is missing for this SCO Terminal Type".

However, the SCO POS Terminal Type is configured and the other one is not SCO. It seems that is asking to configure SCO in both POS Terminal Types, despite if one of them is not SCO.
Steps To Reproduce1. Have a store configured with two POS Terminal Types, one for SCO and the other one not.
2. Do copy store of this organization
3. Copy store is not done as it triggers a message saying "SCO configuration is missing for this SCO Terminal Type"

However, the SCO POS Terminal Type is configured and the other one is not SCO.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng CapturaR.PNG (125,405) 2018-02-02 09:31
https://issues.openbravo.com/file_download.php?file_id=11511&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-02-02 09:31lmonrealNew Issue
2018-02-02 09:31lmonrealAssigned To => Retail
2018-02-02 09:31lmonrealFile Added: CapturaR.PNG
2018-02-02 09:31lmonrealResolution time => 1519599600
2018-02-02 09:31lmonrealTriggers an Emergency Pack => No
2018-02-14 16:25jorgewederagoIssue Monitored: jorgewederago
2018-02-14 16:27jorgewederagoPrioritynormal => high
2018-02-15 16:06rqueraltaAssigned ToRetail => rqueralta
2018-02-21 16:11hgbotCheckin
2018-02-21 16:11hgbotNote Added: 0102560
2018-02-21 16:11hgbotStatusnew => resolved
2018-02-21 16:11hgbotResolutionopen => fixed
2018-02-21 16:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/886210714a9ea7b6c9d206d97e63489d9d3b7fdc [^]
2018-02-21 16:45marvintmNote Added: 0102561
2018-02-21 16:45marvintmStatusresolved => new
2018-02-21 16:45marvintmResolutionfixed => open
2018-02-21 16:46marvintmNote Edited: 0102561bug_revision_view_page.php?bugnote_id=0102561#r16757
2018-02-21 16:55hgbotCheckin
2018-02-21 16:55hgbotNote Added: 0102562
2018-02-22 20:00hgbotCheckin
2018-02-22 20:00hgbotNote Added: 0102805
2018-03-02 13:38marvintmNote Added: 0102923
2018-03-02 13:38marvintmStatusnew => scheduled
2018-03-02 13:38marvintmStatusscheduled => resolved
2018-03-02 13:38marvintmResolutionopen => fixed
2018-03-06 17:57marvintmReview Assigned To => marvintm
2018-03-06 17:57marvintmStatusresolved => closed
2018-03-06 17:57marvintmFixed in Version => RR18Q2

Notes
(0102560)
hgbot   
2018-02-21 16:11   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 886210714a9ea7b6c9d206d97e63489d9d3b7fdc
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Tue Feb 20 21:33:34 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/886210714a9ea7b6c9d206d97e63489d9d3b7fdc [^]

Fixed issue 37817: Copy Store is not working with a Store with two Pos Terminal
Types (one for SCO and the other not)

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0102561)
marvintm   
2018-02-21 16:45   
(edited on: 2018-02-21 16:46)
The solution is conceptually correct, but the problem is that we are creating a reference from one module to another one, without having any kind of dependency between them. This is wrong, because the SCO module doesn't exist necessarily in an instance which contains the copy store module, and if it doesn't then compilation will fail.

Unfortunately the only possible approach for this solution is to create a new module, dependant on both SCO module and Copy Store, and create the handler inside it.

Also, since obscoIsSCO is a primitive column, it doesn't need its handler. The handler for obscoConfiguration is needed however.
(0102562)
hgbot   
2018-02-21 16:55   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 9e69ec3ff9ca9ae8d440267141d03f84ebbc40e4
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Feb 21 10:54:48 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/9e69ec3ff9ca9ae8d440267141d03f84ebbc40e4 [^]

Related to issue 37817: Copy Store is not working with a Store with two Pos
Terminal Types (one for SCO and the other not)

- Backed out changeset: 886210714a9e

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0102805)
hgbot   
2018-02-22 20:00   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: b32f519ce59bcf87ead60d19175a5f171be779c6
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Feb 21 10:59:51 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/b32f519ce59bcf87ead60d19175a5f171be779c6 [^]

Related to issue 37817: Copy Store is not working with a Store with two Pos Terminal
Types (one for SCO and the other not)

- Prevent erros when the module selfcheckout is installed

---
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0102923)
marvintm   
2018-03-02 13:38   
After further discussion, we have decided to simplify and add these properties on Core for now. If more are needed for this module we will create a separate module for them.