Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037772Openbravo ERP07. Sales managementpublic2018-01-30 13:052018-02-27 13:11
Reporteregoitz 
Assigned Todmiguelez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037772: Perfomance problems deleting an invoice on an environment with thousands of invoices and invoice lines
DescriptionIt takes few minutes to delete a order with only 3 lines.
Steps To Reproduce-Create a order
-Add 3 lines
-Delete the order
*It takes 3 minutes.
Proposed SolutionAddding the following index improves the deletion but it is not enought.

+ <index name="C_INVOICELINE_BOMPARENT" unique="false">
+ <index-column name="BOM_PARENT_ID"/>
+ <whereClause><![CDATA[BOM_PARENT_ID IS NOT NULL]]></whereClause>
+ </index>
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00377733.0PR18Q1 closed dmiguelez Perfomance problems deleting an invoice on an environment with thousands of invoices and invoice lines 
depends on backport 00377743.0PR17Q4.1 closed Triage Omni OMS Perfomance problems deleting an invoice on an environment with thousands of invoices and invoice lines 
related to defect 0038008 closed dmiguelez Perfomance problems deleting a shipment on an environment with thousands of hipments and shipments lines. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-30 13:05egoitzNew Issue
2018-01-30 13:05egoitzAssigned To => Triage Finance
2018-01-30 13:05egoitzModules => Core
2018-01-30 13:05egoitzResolution time => 1518649200
2018-01-30 13:05egoitzTriggers an Emergency Pack => No
2018-01-30 13:13dmiguelezStatusnew => scheduled
2018-02-01 10:05egoitzNote Added: 0102113
2018-02-07 12:18hgbotCheckin
2018-02-07 12:18hgbotNote Added: 0102242
2018-02-07 12:18hgbotStatusscheduled => resolved
2018-02-07 12:18hgbotResolutionopen => fixed
2018-02-07 12:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ace20134bb9cbfe1e4b88416920f366d8c86c77b [^]
2018-02-07 12:20dmiguelezNote Added: 0102243
2018-02-07 12:47dmiguelezNote Edited: 0102243bug_revision_view_page.php?bugnote_id=0102243#r16645
2018-02-07 12:49vmromanosAssigned ToTriage Finance => dmiguelez
2018-02-07 13:52vmromanosReview Assigned To => vmromanos
2018-02-07 13:52vmromanosNote Added: 0102251
2018-02-07 13:52vmromanosStatusresolved => closed
2018-02-07 13:52vmromanosFixed in Version => 3.0PR18Q2
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102728
2018-02-27 13:11egoitzIssue cloned0038008
2018-02-27 13:11egoitzRelationship addedrelated to 0038008

Notes
(0102113)
egoitz   
2018-02-01 10:05   
The following index are also needed:


    CREATE INDEX m_costing_invoiceline
 ON m_costing
 USING btree
 (c_invoiceline_id);

    CREATE INDEX m_matchpo_invoiceline
 ON m_matchpo
 USING btree
 (c_invoiceline_id);


CREATE INDEX m_inout_invoice
  ON m_inout (c_invoice_id)
  WHERE m_inout is not null;
(0102242)
hgbot   
2018-02-07 12:18   
Repository: erp/devel/pi
Changeset: ace20134bb9cbfe1e4b88416920f366d8c86c77b
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Feb 06 09:58:29 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ace20134bb9cbfe1e4b88416920f366d8c86c77b [^]

Fixes Issue 37772. Adds several indexes that improve performance
in basic operations like deleting an Invoice or an Order

---
M src-db/database/model/tables/C_INVOICELINE.xml
M src-db/database/model/tables/C_ORDER.xml
M src-db/database/model/tables/M_COSTING.xml
M src-db/database/model/tables/M_INOUT.xml
M src-db/database/model/tables/M_MATCHPO.xml
---
(0102243)
dmiguelez   
2018-02-07 12:20   
(edited on: 2018-02-07 12:47)
Tested with client's data.

Deleting and Order or an Invoice with 5 lines takes around 1 second through the application.
(0102251)
vmromanos   
2018-02-07 13:52   
Code review OK
(0102728)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test