Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037745Retail ModulesWeb POS Hardware Managerpublic2018-01-26 11:542018-01-30 11:53
Reporteradrianromero 
Assigned ToRetail 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q1Fixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-09-21
Regression introduced in releaseRR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/d4f8ae4bb164 [^]
Triggers an Emergency PackNo
Summary0037745: Special characters like ' in product names is printed in the receipt as &
DescriptionIf a product name contains an special character like ' and included in an order from Web POS, when closing the receipt and printed. The receipt prints & instead of '
Steps To ReproduceIn description
Proposed Solution1.- Revert the commit in *Regression introduced by commit*.

2.-To fix properly the issue of the commit it has to be modified the template and print promotion names using function OB.UTIL.encodeXMLComponent() . This way:

          <line>
            <text align="left" length="2">--</text>
            <text align="left" length="32"><%=OB.UTIL.encodeXMLComponent(p.name)%></text>
            <text align="right" length="8"><%= OB.I18N.formatCurrency(-p.amt) %></text>
          </line>
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037737 closed jorge-garcia Special characters like ' in product names is printed in the receipt as & 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-29 10:09marvintmTypedefect => backport
2018-01-29 10:09marvintmTarget Version => RR18Q1
2018-01-29 16:34hgbotCheckin
2018-01-29 16:34hgbotNote Added: 0102032
2018-01-29 16:34hgbotStatusscheduled => resolved
2018-01-29 16:34hgbotResolutionopen => fixed
2018-01-29 16:34hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR18Q1/org.openbravo.retail.posterminal/rev/12421cdd74747bbdf5a5529ffd88054049ed79a1 [^]
2018-01-29 16:35hgbotCheckin
2018-01-29 16:35hgbotNote Added: 0102033
2018-01-29 16:35hgbotCheckin
2018-01-29 16:35hgbotNote Added: 0102034
2018-01-30 11:53marvintmReview Assigned Toadrianromero => marvintm
2018-01-30 11:53marvintmStatusresolved => closed
2018-01-30 11:53marvintmFixed in Version => RR18Q1

Notes
(0102032)
hgbot   
2018-01-29 16:34   
Repository: retail/backports/3.0RR18Q1/org.openbravo.retail.posterminal
Changeset: 12421cdd74747bbdf5a5529ffd88054049ed79a1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 29 15:57:36 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR18Q1/org.openbravo.retail.posterminal/rev/12421cdd74747bbdf5a5529ffd88054049ed79a1 [^]

Fixed issue 37745: Special characters like ' in product names is printed
in the receipt as &

Implemented xml encode in all references of promotions name in templates.

---
M web/org.openbravo.retail.posterminal/res/printcanceledreceipt.xml
M web/org.openbravo.retail.posterminal/res/printclosedinvoice.xml
M web/org.openbravo.retail.posterminal/res/printclosedreceipt.xml
M web/org.openbravo.retail.posterminal/res/printinvoice.xml
M web/org.openbravo.retail.posterminal/res/printlayaway.xml
M web/org.openbravo.retail.posterminal/res/printquotation.xml
M web/org.openbravo.retail.posterminal/res/printreceipt.xml
M web/org.openbravo.retail.posterminal/res/printreturn.xml
M web/org.openbravo.retail.posterminal/res/printreturninvoice.xml
---
(0102033)
hgbot   
2018-01-29 16:35   
Repository: retail/backports/3.0RR18Q1/org.openbravo.retail.poshwmanager.sources
Changeset: 4410e217950fc01f063041aab6e37e49c76c4550
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 29 15:58:12 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR18Q1/org.openbravo.retail.poshwmanager.sources/rev/4410e217950fc01f063041aab6e37e49c76c4550 [^]

Related to issue 37745: Special characters like ' in product names is printed
in the receipt as &

Reverted code introduced by regression.

---
M project/src/com/openbravo/pos/printer/TicketParser.java
---
(0102034)
hgbot   
2018-01-29 16:35   
Repository: retail/backports/3.0RR18Q1/org.openbravo.retail.poshwmanager
Changeset: 60b9bce77d6cbef2c1ccce689b9e9e2dbd24757e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 29 15:59:03 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR18Q1/org.openbravo.retail.poshwmanager/rev/60b9bce77d6cbef2c1ccce689b9e9e2dbd24757e [^]

Related to issue 37745: Special characters like ' in product names is printed
in the receipt as &

Compiled new version of hardware manager.

---
M bin/poshw.jar
M bin/rev.id
---