Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037742Openbravo ERP03. Procurement managementpublic2018-01-29 09:412018-02-22 18:18
Reporteregoitz 
Assigned Todmiguelez 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037742: Return Material pick and execute take more that 4 minutes to be loaed on an environment with thousands of orders.
DescriptionOpening the return material window takes too much.
After 5 minutes the popup is loaded.
Steps To ReproduceOpen the window on an environment with thousands of orders/orderlines.
Proposed SolutionChange the datable to use a hql query instead of a database view.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00377643.0PR18Q1 closed dmiguelez Return Material pick and execute take more that 4 minutes to be loaed on an environment with thousands of orders. 
depends on backport 00377653.0PR17Q4.1 closed dmiguelez Return Material pick and execute take more that 4 minutes to be loaed on an environment with thousands of orders. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-29 09:41egoitzNew Issue
2018-01-29 09:41egoitzAssigned To => Triage Finance
2018-01-29 09:41egoitzModules => Core
2018-01-29 09:41egoitzTriggers an Emergency Pack => No
2018-01-29 09:42egoitzProposed Solution updated
2018-01-29 12:39maiteResolution time => 1518994800
2018-01-29 13:09dmiguelezAssigned ToTriage Finance => dmiguelez
2018-01-29 13:09dmiguelezStatusnew => scheduled
2018-01-30 09:24dmiguelezNote Added: 0102042
2018-01-30 10:54dmiguelezStatusscheduled => acknowledged
2018-01-30 10:54dmiguelezStatusacknowledged => scheduled
2018-01-30 16:28hgbotCheckin
2018-01-30 16:28hgbotNote Added: 0102062
2018-01-30 16:28hgbotStatusscheduled => resolved
2018-01-30 16:28hgbotResolutionopen => fixed
2018-01-30 16:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c05369b231390eaf33c5207a9f2c6ac7cb233d1b [^]
2018-01-30 16:31dmiguelezReview Assigned To => vmromanos
2018-01-30 16:31dmiguelezNote Added: 0102063
2018-01-30 16:31dmiguelezStatusresolved => closed
2018-01-30 16:31dmiguelezFixed in Version => 3.0PR18Q2
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102696

Notes
(0102042)
dmiguelez   
2018-01-30 09:24   
Test that the Return From Customer is working as it was working before:

Create a new Sales Order and a Goods Shipment for that Sales Order (using Create Lines From)
Any Business Partner and any stocked Product should be ok. Quantity must be greater than zero.

Create a new Return From Customer for the previous Goods Shipment and return all the quantity.

Create a new Return Material Receipt for the same Business Partner.
Open the Pick/Edit Lines pop up and realize that the previous Return From Customer is shown in the grid.
Close the Pop Up and select a different Business Partner.
Check that the previous Return From Customer is not shown in the grid.
Close the Pop Up and select the previous Business Partner and complete the Return.

Improvement in performance has been tested with Client's data.

It has improved from 4 minutes to around 250 ms.
(0102062)
hgbot   
2018-01-30 16:28   
Repository: erp/devel/pi
Changeset: c05369b231390eaf33c5207a9f2c6ac7cb233d1b
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 29 11:38:22 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c05369b231390eaf33c5207a9f2c6ac7cb233d1b [^]

Fixes Issue 37742. Fixes performance in Return Material Receipt P&E

In view m_rm_receipt_pick_edit a new column has been added with the
Business Partner from the Order.

This new column is used in the filter of the Return Material P&E Tab.
By doing so, additional cross joins with OrderLine and Order Tables
are avoided.
Also, the planner in Postgres is able to properly use the Business
Partner index.

---
M src-db/database/model/views/M_RM_RECEIPT_PICK_EDIT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_TAB.xml
---
(0102063)
dmiguelez   
2018-01-30 16:31   
Code Review by Victor Martínez, testing by David Miguélez and the client Ok
(0102696)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test