Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037740Openbravo ERPA. Platformpublic2018-01-26 15:532018-02-22 18:19
Reporteralostale 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037740: support custom error pages
DescriptionIt is possible to define custom error pages for invalid requests at web.xml level. If this is not configured, Tomcat will serve it's own default one.

Openbravo generates web.xml, and it does not support to define a customized error page.
Steps To ReproduceTry to open an invalid page, ie.: http://localhost:8080/openbravo/dummy [^]
-> Check the error page is the standard Tomcat's one and it cannot be customized
Proposed SolutionDocumentation: http://wiki.openbravo.com/wiki/Model_Object_Mapping#Error_Pages [^]
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00378133.0PR18Q1.1 closed jarmendariz support custom error pages 
depends on backport 00378143.0PR17Q4.2 closed jarmendariz support custom error pages 
depends on defect 0037907 closed jarmendariz Internal CSS are included in AD_TextInterface as translatable content 
related to defect 0037883 closed jarmendariz Modify the clean cache page to match the generic error page style 
related to defect 0038150 closed jarmendariz Adjust default error page to mobile devices 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-26 15:53alostaleNew Issue
2018-01-26 15:53alostaleAssigned To => platform
2018-01-26 15:53alostaleModules => Core
2018-01-26 15:53alostaleTriggers an Emergency Pack => No
2018-01-29 11:28alostaleResolution time => 1518562800
2018-02-02 07:35alostaleStatusnew => acknowledged
2018-02-02 07:36alostaleStatusacknowledged => scheduled
2018-02-02 07:36alostaleAssigned Toplatform => jarmendariz
2018-02-12 11:38jarmendarizRelationship addedrelated to 0037883
2018-02-14 09:25caristuRelationship addeddepends on 0037907
2018-02-14 10:17caristuRelationship deleteddepends on 0037907
2018-02-14 10:17caristuRelationship addedrelated to 0037907
2018-02-14 13:49jarmendarizRelationship replaceddepends on 0037907
2018-02-14 18:43jarmendarizReview Assigned To => alostale
2018-02-14 18:47hgbotCheckin
2018-02-14 18:47hgbotNote Added: 0102416
2018-02-14 18:47hgbotStatusscheduled => resolved
2018-02-14 18:47hgbotResolutionopen => fixed
2018-02-14 18:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7fce01d9f43d1225cf04ccc310f590a884e44c1c [^]
2018-02-15 08:47hgbotCheckin
2018-02-15 08:47hgbotNote Added: 0102421
2018-02-16 09:01alostaleReview Assigned Toalostale => caristu
2018-02-16 09:02alostaleProposed Solution updated
2018-02-16 09:38caristuNote Added: 0102457
2018-02-16 09:38caristuStatusresolved => new
2018-02-16 09:38caristuResolutionfixed => open
2018-02-19 08:24jarmendarizStatusnew => scheduled
2018-02-20 17:30hgbotCheckin
2018-02-20 17:30hgbotNote Added: 0102534
2018-02-21 10:54hgbotCheckin
2018-02-21 10:54hgbotNote Added: 0102546
2018-02-21 11:56hgbotCheckin
2018-02-21 11:56hgbotNote Added: 0102549
2018-02-21 13:08caristuStatusscheduled => resolved
2018-02-21 13:09caristuNote Added: 0102557
2018-02-21 13:09caristuStatusresolved => closed
2018-02-21 13:09caristuFixed in Version => 3.0PR18Q2
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102761
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102762
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102782
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102783
2018-02-22 18:19hudsonbotCheckin
2018-02-22 18:19hudsonbotNote Added: 0102785
2018-03-23 13:39alostaleRelationship addedrelated to 0038150

Notes
(0102416)
hgbot   
2018-02-14 18:47   
Repository: erp/devel/pi
Changeset: 7fce01d9f43d1225cf04ccc310f590a884e44c1c
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Feb 14 18:43:34 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7fce01d9f43d1225cf04ccc310f590a884e44c1c [^]

Fixed issue 37740: Support custom error pages

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_PARA.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/Wad_data.xsql
M src-wad/src/org/openbravo/wad/web.xml
M src-wad/src/org/openbravo/wad/webConf.xml
A src/org/openbravo/erpCommon/security/Error.html
---
(0102421)
hgbot   
2018-02-15 08:47   
Repository: erp/devel/pi
Changeset: fa213c8bee5bbf587e0d626a8c36b0b68364a26a
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Thu Feb 15 08:47:13 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fa213c8bee5bbf587e0d626a8c36b0b68364a26a [^]

Related to issue 37740: Support custom error pages

Adding missing AD_TextInterface update

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
---
(0102457)
caristu   
2018-02-16 09:38   
Reopened. See: https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0102534)
hgbot   
2018-02-20 17:30   
Repository: erp/devel/pi
Changeset: 61c59ba769d5d848ba9d2d20531f343cfab5d728
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Feb 20 13:39:26 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/61c59ba769d5d848ba9d2d20531f343cfab5d728 [^]

related to issue 37740: code review improvements

  - Extracting common functionality to display error code and exception type pages using a single Sqlc method
  - Extracted getBaseDesignFolder to get the base design folder just once
  - Add log info in error page generation in web.xml
  - Other minor code improvements

---
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/Wad_data.xsql
M src-wad/src/org/openbravo/wad/web.xml
M src-wad/src/org/openbravo/wad/webConf.xml
---
(0102546)
hgbot   
2018-02-21 10:54   
Repository: erp/devel/pi
Changeset: ef34142891ad4c839a89fceab4701dc556541f71
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Feb 21 10:52:41 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ef34142891ad4c839a89fceab4701dc556541f71 [^]

Related to issue 37740: Fixed potential issues

- Inserting a null value for both error-code and exception-type could lead to a crash at startup.
- Error codes are validated
- Fixed formatting

---
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/Wad_data.xsql
M src-wad/src/org/openbravo/wad/webConf.xml
---
(0102549)
hgbot   
2018-02-21 11:56   
Repository: erp/devel/pi
Changeset: 06df5c50e82a77997992b15ff05db70cec71ab4d
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Feb 21 11:56:08 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/06df5c50e82a77997992b15ff05db70cec71ab4d [^]

Related to issue 37740: Add missing order by clauses

---
M src-wad/src/org/openbravo/wad/Wad_data.xsql
---
(0102557)
caristu   
2018-02-21 13:09   
Code reviewed + tested OK.

Documented here: http://wiki.openbravo.com/wiki/Model_Object_Mapping#Error_Pages [^]
(0102761)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102762)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102782)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102783)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102785)
hudsonbot   
2018-02-22 18:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test