Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037738Retail ModulesWeb POSpublic2018-01-26 13:532018-02-12 10:52
asiermartirena 
jorge-garcia 
urgentmajorsometimes
closedfixed 
5
 
RR18Q2 
marvintm
No
0037738: There are cases in which a ticket can be synchronized with the deleted property
There are some cases in which a ticket with the 'obposIsDeleted' property set to true can be synchronized from a flow that is not the delete ticket flow. This causes that the ticket, once synchronized has its lines delivered quantities with an amount of 0, and the payment plan haven't been generated. Also, the ticket is set as deleted when have been synchronized in a normal flow.
There's no exact step to reproduce. Stopping a delete ticket flow (with the 'Save Deleted Tickets' property activated) just in the moment in which the ticket have been modified ('obposIsDeleted' property set) and saved in the local database, causes that we can have an active ticket with the property set.
When an order is set as the active order (by any case), a test will be done to check if the 'obposIsDeleted' property is set in the order. In that case, the ticket will be automatically removed (and synchronized in the case of save deleted tickets) and the next order (or a new one) will be set as the active order.

It would be nice also to add some log when the 'obposIsDeleted' property is added to the order, adding the documentNo and id of that order in the log. There are two points in which that property is set, so is important to distinguish each one.
No tags attached.
Issue History
2018-01-26 13:53asiermartirenaNew Issue
2018-01-26 13:53asiermartirenaAssigned To => Retail
2018-01-26 13:53asiermartirenaResolution time => 1518130800
2018-01-26 13:53asiermartirenaTriggers an Emergency Pack => No
2018-01-29 09:50asiermartirenaProposed Solution updated
2018-01-30 12:58ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-01-30 12:59ranjith_qualiantech_comStatusnew => scheduled
2018-01-30 14:16ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => jorge-garcia
2018-01-31 10:18hgbotCheckin
2018-01-31 10:18hgbotNote Added: 0102085
2018-01-31 10:18hgbotStatusscheduled => resolved
2018-01-31 10:18hgbotResolutionopen => fixed
2018-01-31 10:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/23b7de0644749eda212988025152be36821342b6 [^]
2018-02-09 08:23hgbotCheckin
2018-02-09 08:23hgbotNote Added: 0102282
2018-02-12 10:52marvintmReview Assigned To => marvintm
2018-02-12 10:52marvintmStatusresolved => closed
2018-02-12 10:52marvintmFixed in Version => RR18Q2

Notes
(0102085)
hgbot   
2018-01-31 10:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 23b7de0644749eda212988025152be36821342b6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Jan 30 17:35:05 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/23b7de0644749eda212988025152be36821342b6 [^]

Fixed issue 37738: There are cases in which a ticket can be synchronized
with the deleted property

A new listener has been created to check if the ticket should be removed
from list.

Added log info to save which function is setting obposIsDeleted to the order.

---
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0102282)
hgbot   
2018-02-09 08:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1cad12415b1ded01dac19f1edabfb452ea91b760
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Feb 08 09:57:41 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1cad12415b1ded01dac19f1edabfb452ea91b760 [^]

Related to issue 37738: There are cases in which a ticket can be synchronized
with the deleted property

Reverted the documentNo on change event, If the preference of Save Remove
ticket was active, the order was not being deleted.

The logic is allocated in loadCurrent function and it’s the first thing to check
before the order is chnaged.

Added new warning message to indicate why the order has been deleted.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---