Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037737Retail ModulesWeb POS Hardware Managerpublic2018-01-26 11:542018-01-30 11:53
Reporteradrianromero 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-09-21
Regression introduced in releaseRR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/d4f8ae4bb164 [^]
Triggers an Emergency PackNo
Summary0037737: Special characters like ' in product names is printed in the receipt as &
DescriptionIf a product name contains an special character like ' and included in an order from Web POS, when closing the receipt and printed. The receipt prints & instead of '
Steps To ReproduceIn description
Proposed Solution1.- Revert the commit in *Regression introduced by commit*.

2.-To fix properly the issue of the commit it has to be modified the template and print promotion names using function OB.UTIL.encodeXMLComponent() . This way:

          <line>
            <text align="left" length="2">--</text>
            <text align="left" length="32"><%=OB.UTIL.encodeXMLComponent(p.name)%></text>
            <text align="right" length="8"><%= OB.I18N.formatCurrency(-p.amt) %></text>
          </line>
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0037745RR18Q1 closed Retail Special characters like ' in product names is printed in the receipt as & 
depends on backport 0037746RR17Q4.1 closed Retail Special characters like ' in product names is printed in the receipt as & 
depends on backport 0037747RR17Q3.3 closed Retail Special characters like ' in product names is printed in the receipt as & 
caused by defect 0035801 closed jorge-garcia error printing when special chars (for example, '&') are used in the discount name 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-26 11:54adrianromeroNew Issue
2018-01-26 11:54adrianromeroAssigned To => Retail
2018-01-26 11:54adrianromeroResolution time => 1518130800
2018-01-26 11:54adrianromeroRegression level => Production - Confirmed Stable
2018-01-26 11:54adrianromeroRegression date => 2017-09-21
2018-01-26 11:54adrianromeroRegression introduced in release => RR17Q3
2018-01-26 11:54adrianromeroRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/d4f8ae4bb164 [^]
2018-01-26 11:54adrianromeroTriggers an Emergency Pack => No
2018-01-26 11:59adrianromeroReview Assigned To => adrianromero
2018-01-26 11:59adrianromeroReproducibilityhave not tried => always
2018-01-26 11:59adrianromeroSummarySpecial characters like ' in product names is printed in the receipt as ' => Special characters like ' in product names is printed in the receipt as '
2018-01-26 11:59adrianromeroDescription Updatedbug_revision_view_page.php?rev_id=16593#r16593
2018-01-26 12:17adrianromeroRelationship addedcaused by 0035801
2018-01-26 12:38adrianromeroSummarySpecial characters like ' in product names is printed in the receipt as ' => Special characters like ' in product names is printed in the receipt as &
2018-01-26 12:39adrianromeroDescription Updatedbug_revision_view_page.php?rev_id=16594#r16594
2018-01-26 12:40adrianromeroSummarySpecial characters like ' in product names is printed in the receipt as & => Special characters like ' in product names is printed in the receipt as &
2018-01-26 12:40adrianromeroDescription Updatedbug_revision_view_page.php?rev_id=16595#r16595
2018-01-26 12:40adrianromeroProposed Solution updated
2018-01-26 12:41adrianromeroSummarySpecial characters like ' in product names is printed in the receipt as & => Special characters like ' in product names is printed in the receipt as &
2018-01-26 12:41adrianromeroDescription Updatedbug_revision_view_page.php?rev_id=16596#r16596
2018-01-29 10:09marvintmStatusnew => scheduled
2018-01-29 12:04jorge-garciaAssigned ToRetail => jorge-garcia
2018-01-29 15:44hgbotCheckin
2018-01-29 15:44hgbotNote Added: 0102022
2018-01-29 15:44hgbotStatusscheduled => resolved
2018-01-29 15:44hgbotResolutionopen => fixed
2018-01-29 15:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6fc30025d11bd68d28ec89891e9289392a237999 [^]
2018-01-29 15:44hgbotCheckin
2018-01-29 15:44hgbotNote Added: 0102023
2018-01-29 15:44hgbotCheckin
2018-01-29 15:44hgbotNote Added: 0102024
2018-01-30 11:53marvintmReview Assigned Toadrianromero => marvintm
2018-01-30 11:53marvintmStatusresolved => closed
2018-01-30 11:53marvintmFixed in Version => RR18Q2

Notes
(0102022)
hgbot   
2018-01-29 15:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6fc30025d11bd68d28ec89891e9289392a237999
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 29 10:59:17 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6fc30025d11bd68d28ec89891e9289392a237999 [^]

Fixed issue 37737: Special characters like ' in product names is printed
in the receipt as &

Implemented xml encode in all references of promotions name in templates.

---
M web/org.openbravo.retail.posterminal/res/printcanceledreceipt.xml
M web/org.openbravo.retail.posterminal/res/printclosedinvoice.xml
M web/org.openbravo.retail.posterminal/res/printclosedreceipt.xml
M web/org.openbravo.retail.posterminal/res/printinvoice.xml
M web/org.openbravo.retail.posterminal/res/printlayaway.xml
M web/org.openbravo.retail.posterminal/res/printquotation.xml
M web/org.openbravo.retail.posterminal/res/printreceipt.xml
M web/org.openbravo.retail.posterminal/res/printreturn.xml
M web/org.openbravo.retail.posterminal/res/printreturninvoice.xml
---
(0102023)
hgbot   
2018-01-29 15:44   
Repository: erp/pmods/org.openbravo.retail.poshwmanager.sources
Changeset: 51f7e8497fc1541b4b9c1139092d223ea7e34b0d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 29 11:00:59 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/51f7e8497fc1541b4b9c1139092d223ea7e34b0d [^]

Related to issue 37737: Special characters like ' in product names is printed
in the receipt as &

Reverted code introduced by regression.

---
M project/src/com/openbravo/pos/printer/TicketParser.java
---
(0102024)
hgbot   
2018-01-29 15:44   
Repository: erp/pmods/org.openbravo.retail.poshwmanager
Changeset: 6e0c901d29936a0044be8a7b6f88014a2ffabecc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 29 11:02:43 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager/rev/6e0c901d29936a0044be8a7b6f88014a2ffabecc [^]

Related to issue 37737: Special characters like ' in product names is printed
in the receipt as &

Compiled new version of hardware manager.

---
M bin/poshw.jar
M bin/rev.id
---