Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037709Retail ModulesWeb POSpublic2018-01-24 13:082018-02-27 18:09
Reporterumartirena 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037709: Offline login is not working if "Enable Remote for Customer" preference is active
DescriptionOffline login is not working if "Enable Remote for Customer" preference is active
Steps To ReproduceIn http://livebuilds.openbravo.com/retail_pi_pgsql: [^] [^]
 * Go to Preference window and create a new preference:
   - "Enable Remote for Customer"
   - Value = Y
   - Selected = Y

Logout and login in http://livebuilds.openbravo.com/retail_pi_pgsql [^] [^]
 * Disconnect network to go offline
 * Logout
 * Try to login
 * An error appears and login is not possible: "Error getting Business Partner information: ...."
 * Click on Reload.
 * Try to login again.
 * Another error appears and login is not possible: "Error: A complete login has not been done yet but the application is trying to login offline..."
Proposed SolutionThere are 2 points to research at:

1. Remote models, empty their local table when we do a logout. For Customer model we shouldn't remove default BP for this terminal.

2. In login process, we do a check to ensure that all models have done an initial data load(checking the load timestamp). This validation should not be done for remote models.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037726 closed ranjith_qualiantech_com Models need to be saved again while loading from remote 
Attached Filespng Selection_125.png (68,536) 2018-01-24 13:18
https://issues.openbravo.com/file_download.php?file_id=11479&type=bug
png

png Selection_126.png (105,467) 2018-01-24 13:18
https://issues.openbravo.com/file_download.php?file_id=11480&type=bug
png

patch issue 37709 soure test.patch (11,226) 2018-02-06 07:02
https://issues.openbravo.com/file_download.php?file_id=11543&type=bug
patch issue 37709 soure mobilecore.patch (2,151) 2018-02-06 08:11
https://issues.openbravo.com/file_download.php?file_id=11548&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-01-24 13:08umartirenaNew Issue
2018-01-24 13:08umartirenaAssigned To => Retail
2018-01-24 13:08umartirenaOBNetwork customer => No
2018-01-24 13:08umartirenaTriggers an Emergency Pack => No
2018-01-24 13:18umartirenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16581#r16581
2018-01-24 13:18umartirenaFile Added: Selection_125.png
2018-01-24 13:18umartirenaFile Added: Selection_126.png
2018-01-24 13:28migueldejuanaProposed Solution updated
2018-01-24 14:30ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-01-24 14:33ranjith_qualiantech_comStatusnew => scheduled
2018-01-25 16:41ranjith_qualiantech_comFile Added: issue 37709 soure mobilecore.patch
2018-01-25 18:43egoitzIssue Monitored: egoitz
2018-01-31 11:05ranjith_qualiantech_comRelationship addedrelated to 0037726
2018-02-02 11:43ranjith_qualiantech_comFile Deleted: issue 37709 soure mobilecore.patch
2018-02-02 11:48ranjith_qualiantech_comFile Added: issue 37709 soure mobilecore.patch
2018-02-02 11:49ranjith_qualiantech_comFile Added: issue 37709 soure test.patch
2018-02-06 06:54ranjith_qualiantech_comFile Deleted: issue 37709 soure mobilecore.patch
2018-02-06 06:54ranjith_qualiantech_comFile Deleted: issue 37709 soure test.patch
2018-02-06 07:01ranjith_qualiantech_comFile Added: issue 37709 soure mobilecore.patch
2018-02-06 07:02ranjith_qualiantech_comFile Added: issue 37709 soure test.patch
2018-02-06 08:10ranjith_qualiantech_comFile Deleted: issue 37709 soure mobilecore.patch
2018-02-06 08:11ranjith_qualiantech_comFile Added: issue 37709 soure mobilecore.patch
2018-02-06 09:38hgbotCheckin
2018-02-06 09:38hgbotNote Added: 0102202
2018-02-06 09:38hgbotCheckin
2018-02-06 09:38hgbotNote Added: 0102203
2018-02-06 15:00ranjith_qualiantech_comStatusscheduled => resolved
2018-02-06 15:00ranjith_qualiantech_comResolutionopen => fixed
2018-02-07 12:23ranjith_qualiantech_comNote Added: 0102244
2018-02-07 12:23ranjith_qualiantech_comStatusresolved => new
2018-02-07 12:23ranjith_qualiantech_comResolutionfixed => open
2018-02-12 08:06hgbotCheckin
2018-02-12 08:06hgbotNote Added: 0102315
2018-02-12 08:06hgbotStatusnew => resolved
2018-02-12 08:06hgbotResolutionopen => fixed
2018-02-12 08:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/08529ed93a2da15dd26fd9a4522114e7f19ea665 [^]
2018-02-12 09:08hgbotCheckin
2018-02-12 09:08hgbotNote Added: 0102318
2018-02-15 16:27marvintmNote Added: 0102439
2018-02-15 16:27marvintmStatusresolved => new
2018-02-15 16:27marvintmResolutionfixed => open
2018-02-16 10:44ranjith_qualiantech_comStatusnew => scheduled
2018-02-17 07:05hgbotCheckin
2018-02-17 07:05hgbotNote Added: 0102473
2018-02-17 07:05hgbotCheckin
2018-02-17 07:05hgbotNote Added: 0102474
2018-02-17 07:05hgbotStatusscheduled => resolved
2018-02-17 07:05hgbotResolutionopen => fixed
2018-02-17 07:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/08529ed93a2da15dd26fd9a4522114e7f19ea665 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0f99b7342101be0d185deffae7bf4224c4bf57a2 [^]
2018-02-27 18:09marvintmReview Assigned To => marvintm
2018-02-27 18:09marvintmStatusresolved => closed
2018-02-27 18:09marvintmFixed in Version => RR18Q2

Notes
(0102202)
hgbot   
2018-02-06 09:38   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9ebb2f029cf7b1da837ddec9bb73fc4b8b022481
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 06 14:07:42 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9ebb2f029cf7b1da837ddec9bb73fc4b8b022481 [^]

Related to issue 37709 : Remote model should not be removed while logout

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0102203)
hgbot   
2018-02-06 09:38   
Repository: tools/automation/pi-mobile
Changeset: bb6ada5d290e7793b21f708133bd3af65135642e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 06 14:07:53 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bb6ada5d290e7793b21f708133bd3af65135642e [^]

Verifies issue 37709 : Added automated test 'I37709_VerifyCustomerOnReload'

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/I37600_VerifyNewCustomerReceipt.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/I37709_VerifyCustomerOnReload.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I37709_VerfiyRemoteProductWithDiffPrice.java
---
(0102244)
ranjith_qualiantech_com   
2018-02-07 12:23   
Issue still persists with steps to reproduce
(0102315)
hgbot   
2018-02-12 08:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 08529ed93a2da15dd26fd9a4522114e7f19ea665
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 12:36:07 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/08529ed93a2da15dd26fd9a4522114e7f19ea665 [^]

Fixed issue 37709 : Model should be check in local if the remote connection fails on pos load

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0102318)
hgbot   
2018-02-12 09:08   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4ba4146caaad3b7f74bd375c0bb52e63dc1ce12a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 13:35:20 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4ba4146caaad3b7f74bd375c0bb52e63dc1ce12a [^]

Related to issue 37709 : Fixed JSlint error

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0102439)
marvintm   
2018-02-15 16:27   
After the inclusion of the checkBPInLocal function, the business partner can be found even if we are in remote mode because the default business partner exists in the terminal object.

However, now we have a similar problem in the dataBps.loadBPLocations call. This function never finishes because the remote request to find the addresses fails, and therefore the login process in offline is blocked in this configuration.

This needs to be fixed.
(0102473)
hgbot   
2018-02-17 07:05   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6f37b72bb57f8ac4a33577efb1131f4f25c61e19
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Feb 17 11:35:29 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6f37b72bb57f8ac4a33577efb1131f4f25c61e19 [^]

Related to issue 37709 : Added Local param to OB.Dal.find to force check in local db instead of remote

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0102474)
hgbot   
2018-02-17 07:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0f99b7342101be0d185deffae7bf4224c4bf57a2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Feb 17 11:35:37 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0f99b7342101be0d185deffae7bf4224c4bf57a2 [^]

Fixed issue 37709 : Location Model should be check in local if the remote connection fails on pos load

---
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
---