Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037706Retail ModulesWeb POSpublic2018-01-23 13:352018-03-07 09:21
Reporteraferraz 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037706: Extract Verified Returns logic to new API
DescriptionIt would be fine if Verified Returns logic (located in modalReturnLines.js) could be extracted to a new API.

This API will be useful whenever we want to create a negative receipt from a fully cancelled receipt (Cancel and Replace flow) or from a partially cancelled receipt (Cancel Layaway flow).
Steps To Reproduce*
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch issue 37706 soure returns.patch (21,555) 2018-02-06 07:03
https://issues.openbravo.com/file_download.php?file_id=11546&type=bug
patch issue 37706 soure test.patch (4,460) 2018-02-06 07:03
https://issues.openbravo.com/file_download.php?file_id=11547&type=bug
patch issue 37706 source returns v2.patch (5,475) 2018-02-16 09:54
https://issues.openbravo.com/file_download.php?file_id=11597&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-01-23 13:35aferrazNew Issue
2018-01-23 13:35aferrazAssigned To => Retail
2018-01-23 13:35aferrazOBNetwork customer => No
2018-01-23 13:35aferrazTriggers an Emergency Pack => No
2018-01-30 08:17ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-01-30 08:17ranjith_qualiantech_comStatusnew => scheduled
2018-02-02 11:49ranjith_qualiantech_comFile Added: issue 37706 soure returns.patch
2018-02-02 11:56ranjith_qualiantech_comFile Added: issue 37706 soure test.patch
2018-02-06 06:54ranjith_qualiantech_comFile Deleted: issue 37706 soure returns.patch
2018-02-06 06:54ranjith_qualiantech_comFile Deleted: issue 37706 soure test.patch
2018-02-06 07:03ranjith_qualiantech_comFile Added: issue 37706 soure returns.patch
2018-02-06 07:03ranjith_qualiantech_comFile Added: issue 37706 soure test.patch
2018-02-12 08:57hgbotCheckin
2018-02-12 08:57hgbotNote Added: 0102316
2018-02-12 08:57hgbotStatusscheduled => resolved
2018-02-12 08:57hgbotResolutionopen => fixed
2018-02-12 08:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/d835e1d643a59d3af554d7381336f161512b7c50 [^]
2018-02-12 08:57hgbotCheckin
2018-02-12 08:57hgbotNote Added: 0102317
2018-02-15 10:11hgbotCheckin
2018-02-15 10:11hgbotNote Added: 0102431
2018-02-15 10:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/d835e1d643a59d3af554d7381336f161512b7c50 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/b1ef44a6d077fd4dc220ab381cae5343a04ec9b7 [^]
2018-02-15 16:17ranjith_qualiantech_comNote Added: 0102438
2018-02-15 16:17ranjith_qualiantech_comStatusresolved => new
2018-02-15 16:17ranjith_qualiantech_comResolutionfixed => open
2018-02-15 16:17ranjith_qualiantech_comStatusnew => scheduled
2018-02-16 09:54ranjith_qualiantech_comFile Added: issue 37706 source returns v2.patch
2018-02-18 09:57hgbotCheckin
2018-02-18 09:57hgbotNote Added: 0102475
2018-02-18 09:57hgbotStatusscheduled => resolved
2018-02-18 09:57hgbotResolutionopen => fixed
2018-02-18 09:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/b1ef44a6d077fd4dc220ab381cae5343a04ec9b7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/313040b046bd931ef5e54c3c0e5a3c0142fd8024 [^]
2018-02-22 06:51ranjith_qualiantech_comNote Added: 0102573
2018-02-22 06:51ranjith_qualiantech_comStatusresolved => new
2018-02-22 06:51ranjith_qualiantech_comResolutionfixed => open
2018-02-22 06:51ranjith_qualiantech_comStatusnew => scheduled
2018-02-23 10:13hgbotCheckin
2018-02-23 10:13hgbotNote Added: 0102809
2018-02-23 10:13hgbotStatusscheduled => resolved
2018-02-23 10:13hgbotResolutionopen => fixed
2018-02-23 10:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/313040b046bd931ef5e54c3c0e5a3c0142fd8024 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/4d736419e1979841515e9d42ea9d789cefd1fa7b [^]
2018-02-23 10:14hgbotCheckin
2018-02-23 10:14hgbotNote Added: 0102810
2018-03-07 09:21marvintmReview Assigned To => marvintm
2018-03-07 09:21marvintmStatusresolved => closed
2018-03-07 09:21marvintmFixed in Version => RR18Q2

Notes
(0102316)
hgbot   
2018-02-12 08:57   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: d835e1d643a59d3af554d7381336f161512b7c50
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 13:27:07 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/d835e1d643a59d3af554d7381336f161512b7c50 [^]

Fixed issue 37706 : Added new API for adding return lines to receipt

---
M src/org/openbravo/retail/returns/ReturnsComponentProvider.java
M web/org.openbravo.retail.returns/js/modalReturnLines.js
A web/org.openbravo.retail.returns/js/returnUtils.js
---
(0102317)
hgbot   
2018-02-12 08:57   
Repository: tools/automation/pi-mobile
Changeset: fe5ababd82fed7cfb99bac537a07ac6c808295c4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 13:27:15 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fe5ababd82fed7cfb99bac537a07ac6c808295c4 [^]

Verifies issue 37706 : Modified automated test 'I33227_VerifyReceiptAfterLockScreen'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33227_VerifyReceiptAfterLockScreen.java
---
(0102431)
hgbot   
2018-02-15 10:11   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: b1ef44a6d077fd4dc220ab381cae5343a04ec9b7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Feb 15 14:41:15 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/b1ef44a6d077fd4dc220ab381cae5343a04ec9b7 [^]

Fixed issue 37706 : Removed params in ReturnUtils addReturnLines

* context param ihas no scope, So its removed

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
M web/org.openbravo.retail.returns/js/returnUtils.js
---
(0102438)
ranjith_qualiantech_com   
2018-02-15 16:17   
autoSplitShipmentLines should be present in modalReturnLines instead of API
(0102475)
hgbot   
2018-02-18 09:57   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 313040b046bd931ef5e54c3c0e5a3c0142fd8024
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sun Feb 18 14:27:31 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/313040b046bd931ef5e54c3c0e5a3c0142fd8024 [^]

Fixed issue 37706 : Refactored addReturnLines API

* Split shipment lines should be in modalReturnLines

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
M web/org.openbravo.retail.returns/js/returnUtils.js
---
(0102573)
ranjith_qualiantech_com   
2018-02-22 06:51   
API should be modified to avoid OBPOS_layawaysOrdersWithReturnsNotAllowed
(0102809)
hgbot   
2018-02-23 10:13   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 4d736419e1979841515e9d42ea9d789cefd1fa7b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Feb 23 14:38:06 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/4d736419e1979841515e9d42ea9d789cefd1fa7b [^]

Fixed issue 37706 : Refactored addReturnLines API

* API should be independent and showLoading should be hidden while completing the process
* Added allowLayawayWithReturn to product option to validate while creating line

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
M web/org.openbravo.retail.returns/js/returnUtils.js
---
(0102810)
hgbot   
2018-02-23 10:14   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 115114c685433ec4d8efd34f72c84b2130fb0b20
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Feb 23 14:43:07 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/115114c685433ec4d8efd34f72c84b2130fb0b20 [^]

Related to issue 37706 : Validate Layaway with Return using product options

* AllowLayaways With Negative Lines should be validated with product option "allowLayawayWithReturn"

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---